-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix query to get most recent actor catalog fetch event for some sources #21726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfsiega-airbyte
temporarily deployed
to
more-secrets
January 23, 2023 17:27
— with
GitHub Actions
Inactive
mfsiega-airbyte
temporarily deployed
to
more-secrets
January 23, 2023 17:27
— with
GitHub Actions
Inactive
benmoriceau
approved these changes
Jan 23, 2023
mfsiega-airbyte
temporarily deployed
to
more-secrets
January 23, 2023 17:41
— with
GitHub Actions
Inactive
mfsiega-airbyte
temporarily deployed
to
more-secrets
January 23, 2023 17:41
— with
GitHub Actions
Inactive
mfsiega-airbyte
temporarily deployed
to
more-secrets
January 23, 2023 18:01
— with
GitHub Actions
Inactive
mfsiega-airbyte
temporarily deployed
to
more-secrets
January 23, 2023 18:01
— with
GitHub Actions
Inactive
mfsiega-airbyte
temporarily deployed
to
more-secrets
January 23, 2023 18:19
— with
GitHub Actions
Inactive
mfsiega-airbyte
temporarily deployed
to
more-secrets
January 23, 2023 18:19
— with
GitHub Actions
Inactive
Airbyte Code Coverage
|
@benmoriceau just FYI - I noticed that the query was choking on an empty list of source ids. Short-circuiting seemed simplest, do you mind taking another look? |
mfsiega-airbyte
temporarily deployed
to
more-secrets
January 23, 2023 19:33
— with
GitHub Actions
Inactive
mfsiega-airbyte
temporarily deployed
to
more-secrets
January 23, 2023 19:33
— with
GitHub Actions
Inactive
benmoriceau
approved these changes
Jan 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fix the query to get the most recent actor catalog fetch event for some sources.
This query is both inefficient -- fails to apply the source id filter -- and possibly incorrect -- if two rows exist with the same
actor_id, actor_catalog_id, created_at
values, it will crash. This is unlikely sincecreated_at
is a timestamp, but the frontend actually ends up issuing two simultaneous discovery workflows, so it ends up happening more often than you'd expect. See #21208.How
row_number()
instead ofrank()
, which handles duplicates.sourceId
filter.