Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🪟 🔧 Add auto-detect schema changes feature flag #20035

Merged
merged 3 commits into from
Dec 6, 2022

Conversation

edmundito
Copy link
Contributor

What

Resolves #19920

Ensures that auto-detect schema changes can be enabled with LaunchDarkly.

How

Updates the current flags to use LaunchDarkly. It still allows a developer to enable the feature with the env variable.

Recommended reading order

Start with airbyte-webapp/src/hooks/connection/useIsAutoDetectSchemaChangesEnabled.ts

@edmundito edmundito requested a review from a team as a code owner December 2, 2022 20:58
@octavia-squidington-iv octavia-squidington-iv added area/platform issues related to the platform area/frontend Related to the Airbyte webapp labels Dec 2, 2022
Copy link
Contributor

@krishnaglick krishnaglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have not tested locally, code LGTM

@edmundito edmundito force-pushed the edmundito/schema-changes-launchdarkly branch from c8b096d to fa1b17e Compare December 5, 2022 13:42
@edmundito
Copy link
Contributor Author

@krishnaglick updated with improved mocking and brought the changes in from #19755

@edmundito edmundito changed the title Add auto-detect schema changes feature flag 🪟 🔧 Add auto-detect schema changes feature flag Dec 5, 2022
@edmundito edmundito merged commit b5fdbaf into master Dec 6, 2022
@edmundito edmundito deleted the edmundito/schema-changes-launchdarkly branch December 6, 2022 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/frontend Related to the Airbyte webapp area/platform issues related to the platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add feature flag for auto-detect schema changes
3 participants