Added stylelintignore for generated coverage files. #20097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teallarson
approved these changes
Dec 5, 2022
ambirdsall
approved these changes
Dec 5, 2022
airbyte-webapp/.stylelintignore
Outdated
| @@ -0,0 +1 @@ | |||
| coverage/**/*.css | |||
There was a problem hiding this comment.
nit of all nits, but could you put a final newline in this file? .editorconfig is agnostic except for python files, where insert_final_newline = true is explicitly set, but our files nearly universally have them. Perhaps most importantly, though, is that I think github's big red "no final newline here" icon is kind of ugly 🤷 😅
There was a problem hiding this comment.
Is there a reason to scope this specifically to *.css files? IIUC, everything in coverage/ is autogenerated, so why not ignore coverage/**/*?
There was a problem hiding this comment.
I used the inline editor, I think it got the newline
🎸 ✨
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added stylelintignore for generated coverage files.