Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added stylelintignore for generated coverage files. #20097

Merged
merged 2 commits into from
Dec 7, 2022
Merged

Added stylelintignore for generated coverage files. #20097

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
061a579
Added stylelintignore for generated coverage files.
krishnaglick Dec 5, 2022
6b9b919
Alex CR
krishnaglick Dec 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions airbyte-webapp/.stylelintignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
coverage/**/*.css
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit of all nits, but could you put a final newline in this file? .editorconfig is agnostic except for python files, where insert_final_newline = true is explicitly set, but our files nearly universally have them. Perhaps most importantly, though, is that I think github's big red "no final newline here" icon is kind of ugly 🤷 😅

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason to scope this specifically to *.css files? IIUC, everything in coverage/ is autogenerated, so why not ignore coverage/**/*?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used the inline editor, I think it got the newline