Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Destination doc and warning updates #20110

Merged
merged 6 commits into from
Dec 6, 2022
Merged

Conversation

evantahler
Copy link
Contributor

@evantahler evantahler commented Dec 6, 2022

Closes #20075.

Working though the list of connector issues here #19993 (comment) solving missing chagelogs and missing docs pages entirely.

After this update, a missing strict-encrypt connector or destination-jdbc won't trigger a failure. We now use 🔵 for skipped connectors in this check.

Screenshot 2022-12-05 at 5 09 06 PM


To test the python code, add a file like this the root of your airbyte project changed_files.txt:

airbyte-integrations/connectors/source-faker/main.py
airbyte-integrations/connectors/destination-jdbc/foo.java

and then run python3 ./tools/bin/ci_check_dependency.py ./changed_files.txt to see the generated comment markdown at comment_body.md

@octavia-squidington-iv octavia-squidington-iv added the area/documentation Improvements or additions to documentation label Dec 6, 2022
@evantahler evantahler changed the title Doc updates Destination doc and warning updates Dec 6, 2022
@evantahler evantahler temporarily deployed to more-secrets December 6, 2022 01:11 Inactive
@evantahler evantahler temporarily deployed to more-secrets December 6, 2022 01:12 Inactive
@evantahler evantahler marked this pull request as ready for review December 6, 2022 01:12
tools/bin/ci_check_dependency.py Outdated Show resolved Hide resolved
tools/bin/ci_check_dependency.py Outdated Show resolved Hide resolved
tools/bin/ci_check_dependency.py Outdated Show resolved Hide resolved
docs/integrations/destinations/dev-null.md Outdated Show resolved Hide resolved
docs/integrations/destinations/csv.md Outdated Show resolved Hide resolved
@evantahler
Copy link
Contributor Author

Thanks for the typo-catches @alafanechere!

@evantahler evantahler temporarily deployed to more-secrets December 6, 2022 16:54 Inactive
@evantahler evantahler temporarily deployed to more-secrets December 6, 2022 16:54 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/faker
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resolve ❌ destinations in connector dependency workflow
3 participants