Fix CI Dependency Check Failures #20666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
37 tasks
octavia-squidington-iv
added
area/connectors
|
Hmm we had a Slack thread about it a few months ago. DM'ing the link :) |
evantahler
temporarily deployed
to
more-secrets
GitHub Actions
Inactive
evantahler
temporarily deployed
to
more-secrets
GitHub Actions
Inactive
alafanechere
approved these changes
Dec 20, 2022
|
|
||
| | Version | Date | Pull Request | Subject | | ||
| | :------ | :--------- | :------------------------------------------------------- | :---------------------------- | | ||
| | 0.1.3 | 2022-03-23 | [10563](https://github.com/airbytehq/airbyte/pull/10563) | 🎉 Source Yahoo Finance Price | |
There was a problem hiding this comment.
This connector is not published to docker hub. I think we should mention it in the doc.
| @@ -17,9 +17,20 @@ | |||
| "/integration_tests/", "/unit_tests/", | |||
| # Common | |||
| "acceptance-test-config.yml", "acceptance-test-docker.sh", ".md", ".dockerignore", ".gitignore", "requirements.txt"] | |||
| IGNORED_SOURCES = [ | |||
| re.compile("^source-e2e-test-cloud$"), | |||
| re.compile("^source-mongodb$"), | |||
There was a problem hiding this comment.
FYI source-mongodb-v2 is the maintained MongoDb source. The other one is legacy.
Co-authored-by: Augustin <[email protected]>
Co-authored-by: Augustin <[email protected]>
Co-authored-by: Augustin <[email protected]>
Co-authored-by: Augustin <[email protected]>
Co-authored-by: Augustin <[email protected]>
evantahler
temporarily deployed
to
more-secrets
GitHub Actions
Inactive
evantahler
temporarily deployed
to
more-secrets
GitHub Actions
Inactive
evantahler
temporarily deployed
to
more-secrets
GitHub Actions
Inactive
evantahler
temporarily deployed
to
more-secrets
GitHub Actions
Inactive
|
/approve-and-merge reason="We decided that this PR was safe to merge during the code freeze as it only contains changes for docs and python code for writing comments on PRs." |
|
Enough! Let's do this |
octavia-approvington
approved these changes
Dec 20, 2022
This was referenced Jan 6, 2023
This was referenced Jan 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #20324
Continuing the fine work in #20274, #20110, and #19865, this PR once again attempts to add missing documentation and metadata connectors need.
AS OF THIS PULL REQUEST, EVERY CONNECTOR HAS A DOC, CHANGELOG, AND IS PROPERLY PUBLISHED
Except...
Notes:
These problems will remain after this PR, and should be addressed by the connector contributors:
Google Analytics
There's something very strange going on with the Google Analytics Sources:
source-google-analytics-data-apiis using the doc calledsources/google-analytics-v4.md(v0.0.3 is current)source-google-analytics-v4is using the doc calledsources/google-analytics-universal-analytics(v0.1.32 is current)Link to slack thread about latest converstation and an issue (https://github.com/airbytehq/airbyte-internal-issues/issues/771) with more information
Mongo
I don't really understand what happened with MongoDB. There's a "v2" connector (not v2 of the version)
source-yahoo-finance-price
Not published. We should publish this connector.
destination-kvdb
Not Published
destination-mysql-strict-encrypt
Version doesn't match
destination-mysql