Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source Stripe: enable high strictness level #21419

Original file line number Diff line number Diff line change
@@ -1,50 +1,69 @@
connector_image: airbyte/source-stripe:dev
tests:
test_strictness_level: high
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

acceptance_tests:
spec:
tests:
- spec_path: "source_stripe/spec.yaml"
connection:
- config_path: "secrets/config.json"
status: "succeed"
- config_path: "secrets/connected_account_config.json"
status: "succeed"
- config_path: "integration_tests/invalid_config.json"
status: "failed"
tests:
- config_path: "secrets/config.json"
status: "succeed"
- config_path: "integration_tests/invalid_config.json"
status: "failed"
discovery:
- config_path: "secrets/config.json"
backward_compatibility_tests_config:
disable_for_version: "2.0.0"
- config_path: "secrets/connected_account_config.json"
backward_compatibility_tests_config:
disable_for_version: "2.0.0"
tests:
- config_path: "secrets/config.json"
backward_compatibility_tests_config:
disable_for_version: "2.0.0"
Comment on lines +15 to +17
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this version incompatible, but not a breaking (major semver) change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I see from previous commits there was an invoices schema fix. Some field types were changed: number -> integer, integer -> string. That is why we disabling this compatibility test

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess those changes are scope-increasing, so that should be OK

basic_read:
- config_path: "secrets/config.json"
configured_catalog_path: "integration_tests/full_refresh_configured_catalog.json"
empty_streams: ["bank_accounts", "checkout_sessions", "checkout_sessions_line_items", "external_account_bank_accounts"]
# TEST 1 - Reading catalog without invoice_line_items
- config_path: "secrets/config.json"
configured_catalog_path: "integration_tests/non_invoice_line_items_catalog.json"
empty_streams: ["transfers"]
timeout_seconds: 3600
# TEST 2 - Reading data from account that has no records for stream Disputes
- config_path: "secrets/connected_account_config.json"
configured_catalog_path: "integration_tests/connected_account_configured_catalog.json"
timeout_seconds: 3600
tests:
- config_path: "secrets/config.json"
empty_streams:
- name: "bank_accounts"
bypass_reason: "This stream can't be seeded in our sandbox account"
- name: "external_account_bank_accounts"
bypass_reason: "This stream can't be seeded in our sandbox account"
- name: "external_account_cards"
bypass_reason: "This stream can't be seeded in our sandbox account"
- name: "checkout_sessions"
bypass_reason: "This stream can't be seeded in our sandbox account"
- name: "checkout_sessions_line_items"
bypass_reason: "This stream can't be seeded in our sandbox account"
- name: "transfers"
bypass_reason: "This stream can't be seeded in our sandbox account"
expect_records:
path: "integration_tests/expected_records.jsonl"
extra_fields: no
exact_order: no
extra_records: yes
ignored_fields:
invoices:
- name: invoice_pdf
bypass_reason: "URL changes upon each request for privacy/security"
- name: hosted_invoice_url
bypass_reason: "URL changes upon each request for privacy/security"
charges:
- name: receipt_url
bypass_reason: "URL changes upon each request for privacy/security"
- name: receipt_number
bypass_reason: "fast changing data"
payment_intents:
- name: receipt_url
bypass_reason: "URL changes upon each request for privacy/security"
- name: charges/data/*/receipt_url
bypass_reason: "URL changes upon each request for privacy/security"
incremental:
- config_path: "secrets/config.json"
configured_catalog_path: "integration_tests/non_invoice_line_items_catalog.json"
future_state_path: "integration_tests/abnormal_state.json"
- config_path: "secrets/connected_account_config.json"
configured_catalog_path: "integration_tests/connected_account_configured_catalog.json"
future_state_path: "integration_tests/abnormal_state.json"
tests:
- config_path: "secrets/config.json"
future_state:
future_state_path: "integration_tests/abnormal_state.json"
full_refresh:
- config_path: "secrets/config.json"
configured_catalog_path: "integration_tests/non_invoice_line_items_catalog.json"
timeout_seconds: 3600
- config_path: "secrets/config.json"
configured_catalog_path: "integration_tests/full_refresh_configured_catalog.json"
- config_path: "secrets/connected_account_config.json"
configured_catalog_path: "integration_tests/connected_account_configured_catalog.json"
ignored_fields:
"invoices":
- invoice_pdf
- hosted_invoice_url
tests:
- config_path: "secrets/config.json"
timeout_seconds: 3600
ignored_fields:
invoices:
- name: invoice_pdf
bypass_reason: "URL changes upon each request for privacy/security"
- name: hosted_invoice_url
bypass_reason: "URL changes upon each request for privacy/security"
Empty file.
Loading