Source Stripe: enable high strictness level #21419

roman-yermilov-gl · 2023-01-13T19:26:04Z

What

Enable high strictness level

roman-yermilov-gl · 2023-01-13T19:27:24Z

/test connector=connectors/source-stripe

🕑 connectors/source-stripe https://github.com/airbytehq/airbyte/actions/runs/3914314848
✅ connectors/source-stripe https://github.com/airbytehq/airbyte/actions/runs/3914314848
Python tests coverage:

Name                        Stmts   Miss  Cover
-----------------------------------------------
source_stripe/source.py        22      0   100%
source_stripe/__init__.py       2      0   100%
source_stripe/streams.py      304     27    91%
-----------------------------------------------
TOTAL                         328     27    92%
	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          12      4    67%   16-19
	 source_acceptance_test/config.py                       141      5    96%   87, 93, 239, 243-244
	 source_acceptance_test/conftest.py                     211     95    55%   36, 42-44, 49, 54, 77, 83, 89-91, 110, 115-117, 123-125, 131-132, 137-138, 143, 149, 158-167, 173-178, 193, 217, 248, 254, 262-267, 275-285, 293-306, 311-317, 324-335, 342-358
	 source_acceptance_test/plugin.py                        69     25    64%   22-23, 31, 36, 120-140, 144-148
	 source_acceptance_test/tests/test_core.py              402    115    71%   53, 58, 93-104, 109-116, 120-121, 125-126, 308, 346-363, 376-387, 391-396, 402, 435-440, 478-485, 528-530, 533, 598-606, 618-621, 626, 682-683, 689, 692, 728-738, 751-776
	 source_acceptance_test/tests/test_incremental.py       160     14    91%   56-63, 68-81, 244
	 source_acceptance_test/utils/asserts.py                 39      2    95%   62-63
	 source_acceptance_test/utils/common.py                  94     10    89%   16-17, 32-38, 72, 75
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/connector_runner.py       133     33    75%   24-27, 46-47, 50-54, 57-58, 73-75, 78-80, 83-85, 88-90, 93-95, 124-125, 159-161, 208
	 source_acceptance_test/utils/json_schema_helper.py     107     13    88%   30-31, 38, 41, 65-68, 96, 120, 192-194
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1609    339    79%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:94: The previous and actual specifications are identical.
SKIPPED [2] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:377: The previous and actual discovered catalogs are identical.
================== 45 passed, 3 skipped in 1410.55s (0:23:30) ==================

roman-yermilov-gl · 2023-02-07T15:01:17Z

/test connector=connectors/source-stripe

🕑 connectors/source-stripe https://github.com/airbytehq/airbyte/actions/runs/4115219133
❌ connectors/source-stripe https://github.com/airbytehq/airbyte/actions/runs/4115219133
🐛 https://gradle.com/s/vbsoizbws7wo6

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestDiscovery::test_backward_compatibility[inputs0] - co...
FAILED test_core.py::TestBasicRead::test_read[inputs0] - AssertionError: All ...
FAILED test_incremental.py::TestIncremental::test_two_sequential_reads[inputs0]
FAILED test_incremental.py::TestIncremental::test_read_sequential_slices[inputs0]
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:98: The previous and actual specifications are identical.
============= 4 failed, 32 passed, 1 skipped in 3159.79s (0:52:39) =============

bazarnov

LGMT, but schema change should be complete.

airbyte-integrations/connectors/source-stripe/source_stripe/schemas/invoices.json

github-actions · 2023-02-08T10:30:05Z

Airbyte Code Coverage

There is no coverage information present for the Files changed

Total Project Coverage	24.66%	❌

roman-yermilov-gl · 2023-02-08T10:31:10Z

/test connector=connectors/source-stripe

🕑 connectors/source-stripe https://github.com/airbytehq/airbyte/actions/runs/4123174914
❌ connectors/source-stripe https://github.com/airbytehq/airbyte/actions/runs/4123174914
🐛 https://gradle.com/s/kirqaiviutpcg

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestDiscovery::test_backward_compatibility[inputs0] - co...
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:98: The previous and actual specifications are identical.
============= 1 failed, 35 passed, 1 skipped in 181.53s (0:03:01) ==============

roman-yermilov-gl · 2023-02-08T11:46:51Z

/test connector=connectors/source-stripe

🕑 connectors/source-stripe https://github.com/airbytehq/airbyte/actions/runs/4123768156
❌ connectors/source-stripe https://github.com/airbytehq/airbyte/actions/runs/4123768156
🐛 https://gradle.com/s/k2j5jc4v65u72

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestDiscovery::test_backward_compatibility[inputs0] - co...
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:98: The previous and actual specifications are identical.
============= 1 failed, 35 passed, 1 skipped in 178.05s (0:02:58) ==============

roman-yermilov-gl · 2023-02-08T12:29:24Z

/test connector=connectors/source-stripe

🕑 connectors/source-stripe https://github.com/airbytehq/airbyte/actions/runs/4124104287
❌ connectors/source-stripe https://github.com/airbytehq/airbyte/actions/runs/4124104287
🐛

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:98: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:516: Backward compatibility tests are disabled for version 1.0.1.
================== 35 passed, 2 skipped in 181.83s (0:03:01) ===================

roman-yermilov-gl · 2023-02-08T19:17:57Z

/test connector=connectors/source-stripe

🕑 connectors/source-stripe https://github.com/airbytehq/airbyte/actions/runs/4127621366
✅ connectors/source-stripe https://github.com/airbytehq/airbyte/actions/runs/4127621366
Python tests coverage:

Name                        Stmts   Miss  Cover
-----------------------------------------------
source_stripe/source.py        22      0   100%
source_stripe/__init__.py       2      0   100%
source_stripe/streams.py      308     28    91%
-----------------------------------------------
TOTAL                         332     28    92%
	 Name                                                    Stmts   Miss  Cover   Missing
	 -------------------------------------------------------------------------------------
	 connector_acceptance_test/base.py                          12      4    67%   16-19
	 connector_acceptance_test/config.py                       141      5    96%   87, 93, 239, 243-244
	 connector_acceptance_test/conftest.py                     217    101    53%   37, 43-45, 50, 55, 78, 84, 90-92, 111, 116-118, 124-126, 132-133, 138-139, 144, 150, 159-168, 174-179, 194, 218, 249, 255, 263-271, 279-292, 300-313, 318-324, 331-342, 349-365
	 connector_acceptance_test/plugin.py                        69     25    64%   22-23, 31, 36, 120-140, 144-148
	 connector_acceptance_test/tests/test_core.py              476    117    75%   53, 58, 97-108, 113-120, 124-125, 129-130, 380, 400, 438, 476-493, 506-517, 521-526, 532, 565-570, 608-615, 658-660, 663, 728-736, 748-751, 756, 812-813, 819, 822, 858-868, 881-906
	 connector_acceptance_test/tests/test_incremental.py       160     14    91%   58-65, 70-83, 246
	 connector_acceptance_test/utils/asserts.py                 39      2    95%   62-63
	 connector_acceptance_test/utils/common.py                  94     10    89%   16-17, 32-38, 72, 75
	 connector_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 connector_acceptance_test/utils/connector_runner.py       133     33    75%   24-27, 46-47, 50-54, 57-58, 73-75, 78-80, 83-85, 88-90, 93-95, 124-125, 159-161, 208
	 connector_acceptance_test/utils/json_schema_helper.py     114     13    89%   31-32, 39, 42, 66-69, 97, 121, 203-205
	 -------------------------------------------------------------------------------------
	 TOTAL                                                    1696    347    80%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:98: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:516: Backward compatibility tests are disabled for version 1.0.1.
================== 35 passed, 2 skipped in 188.44s (0:03:08) ===================

evantahler · 2023-02-09T18:22:09Z

airbyte-config/init/src/main/resources/seed/source_definitions.yaml

+  allowedHosts:
+    hosts:
+      - "api.stripe.com"


👍 allowedhosts

evantahler · 2023-02-09T18:26:01Z

airbyte-integrations/connectors/source-stripe/acceptance-test-config.yml

+          - name: "charges"
+            bypass_reason: "This stream produces unique data every time it runs. Fields: receipt_url"


This is the most important stream in the connector, and I feel uncomfortable certifying this connector to GA bypassing a test on this stream. It's probably time to adjust SAT so that basic-read can ignore a singe column that is changing, like it is here. This is a great example of a reasonable source changing data on every read (a protected PDF download link for a receipt is only valid for a short amount of time)

@roman-yermilov-gl - do you feel comfortable working on #21737 to unblock this?

cc @YowanR as I'm rejecting this, and cc @alafanechere who may have some advice on how to work on #21737

do you feel comfortable working on #21737 to unblock this? - yes I do

I replied in #21737 . I would also be interested in trying out a different approach: what would happen if you removed this receipt_url field from the stream schema at the configured catalog level and remove it from the expected records? It'll probably be considered as an additional property that'll be ignored if you set extra_fields: true in the expected records config.

It looks like a kind of workaround for current case, but we need a solution for many other connectors that fail because of expected_records.

…trictness-level

roman-yermilov-gl · 2023-02-28T14:32:19Z

/test connector=connectors/source-stripe

🕑 connectors/source-stripe https://github.com/airbytehq/airbyte/actions/runs/4294062970
✅ connectors/source-stripe https://github.com/airbytehq/airbyte/actions/runs/4294062970
Python tests coverage:

Name                                     Stmts   Miss  Cover
------------------------------------------------------------
source_stripe/source.py                     22      0   100%
source_stripe/__init__.py                    2      0   100%
source_stripe/streams.py                   311     27    91%
source_stripe/availability_strategy.py      19      2    89%
------------------------------------------------------------
TOTAL                                      354     29    92%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:509: The previous and actual discovered catalogs are identical.
================== 35 passed, 2 skipped in 235.37s (0:03:55) ===================

…el' of github.com:airbytehq/airbyte into ryermilov/source-stripe-enable-high-test-strictness-level

…trictness-level

evantahler · 2023-02-28T16:43:01Z

airbyte-integrations/connectors/source-stripe/acceptance-test-config.yml

+      - config_path: "secrets/config.json"
+        backward_compatibility_tests_config:
+          disable_for_version: "2.0.0"


Why is this version incompatible, but not a breaking (major semver) change?

As I see from previous commits there was an invoices schema fix. Some field types were changed: number -> integer, integer -> string. That is why we disabling this compatibility test

I guess those changes are scope-increasing, so that should be OK

evantahler · 2023-02-28T16:43:12Z

airbyte-integrations/connectors/source-stripe/acceptance-test-config.yml

@@ -1,50 +1,67 @@
 connector_image: airbyte/source-stripe:dev
-tests:
+test_strictness_level: high


evantahler · 2023-02-28T16:43:43Z

airbyte-integrations/connectors/source-stripe/acceptance-test-config.yml

+        ignored_fields:
+          invoices:
+            - name: invoice_pdf
+              bypass_reason: "URL changes upon each request for privacy/security"
+            - name: hosted_invoice_url
+              bypass_reason: "URL changes upon each request for privacy/security"
+          charges:
+            - name: receipt_url
+              bypass_reason: "URL changes upon each request for privacy/security"
+          payment_intents:
+            - name: receipt_url
+              bypass_reason: "URL changes upon each request for privacy/security"
+            - name: charges/data/*/receipt_url
+              bypass_reason: "URL changes upon each request for privacy/security"


evantahler · 2023-02-28T16:44:46Z

airbyte-integrations/connectors/source-stripe/integration_tests/expected_records.jsonl

+{"stream": "customer_balance_transactions", "data": {"id": "cbtxn_1MX2zPEcXtiJtvvhr4L2D3Q1", "object": "customer_balance_transaction", "amount": -50000, "created": 1675345091, "credit_note": null, "currency": "usd", "customer": "cus_NGoTFiJFVbSsvZ", "description": null, "ending_balance": 0, "invoice": "in_1MX2yFEcXtiJtvvhMXhUCgKx", "livemode": false, "metadata": {}, "type": "applied_to_invoice"}, "emitted_at": 1677521324571}
+{"stream": "customer_balance_transactions", "data": {"id": "cbtxn_1MWIPLEcXtiJtvvhLnQYjVCj", "object": "customer_balance_transaction", "amount": 50000, "created": 1675166031, "credit_note": null, "currency": "usd", "customer": "cus_NGoTFiJFVbSsvZ", "description": "Test credit balance", "ending_balance": 50000, "invoice": null, "livemode": false, "metadata": {}, "type": "adjustment"}, "emitted_at": 1677521324572}
+{"stream": "customers", "data": {"id": "cus_LIiHR6omh14Xdg", "object": "customer", "address": {"city": "san francisco", "country": "US", "line1": "san francisco", "line2": "", "postal_code": "", "state": "CA"}, "balance": 0, "created": 1646998902, "currency": "usd", "default_currency": "usd", "default_source": "card_1MSHU1EcXtiJtvvhytSN6V54", "delinquent": false, "description": "test", "discount": null, "email": "test@airbyte_integration_test.com", "invoice_prefix": "09A6A98F", "invoice_settings": {"custom_fields": null, "default_payment_method": null, "footer": null, "rendering_options": null}, "livemode": false, "metadata": {}, "name": "Test", "next_invoice_sequence": 3, "phone": null, "preferred_locales": [], "shipping": {"address": {"city": "", "country": "US", "line1": "", "line2": "", "postal_code": "", "state": ""}, "name": "", "phone": ""}, "tax_exempt": "none", "test_clock": null}, "emitted_at": 1677521325916}
+{"stream": "customers", "data": {"id": "cus_Kou8knsO3qQOwU", "object": "customer", "address": null, "balance": 0, "created": 1640123795, "currency": "usd", "default_currency": "usd", "default_source": "src_1MSID8EcXtiJtvvhxIT9lXRy", "delinquent": false, "description": null, "discount": null, "email": "[email protected]", "invoice_prefix": "CA35DF83", "invoice_settings": {"custom_fields": null, "default_payment_method": null, "footer": null, "rendering_options": null}, "livemode": false, "metadata": {}, "name": "edgao-test-customer-1", "next_invoice_sequence": 1, "phone": null, "preferred_locales": [], "shipping": null, "tax_exempt": "none", "test_clock": null}, "emitted_at": 1677521325917}


👍 airbyte employee

evantahler · 2023-02-28T16:45:26Z

airbyte-integrations/connectors/source-stripe/integration_tests/expected_records.jsonl

+{"stream": "invoices", "data": {"id": "in_1MX2yFEcXtiJtvvhMXhUCgKx", "object": "invoice", "account_country": "US", "account_name": "Airbyte, Inc.", "account_tax_ids": null, "amount_due": 72680, "amount_paid": 72680, "amount_remaining": 0, "amount_shipping": 0, "application": null, "application_fee_amount": null, "attempt_count": 1, "attempted": true, "auto_advance": false, "automatic_tax": {"enabled": true, "status": "complete"}, "billing_reason": "manual", "charge": "ch_3MX2zPEcXtiJtvvh1BUGw8EC", "collection_method": "send_invoice", "created": 1675345019, "currency": "usd", "custom_fields": null, "customer": "cus_NGoTFiJFVbSsvZ", "customer_address": {"city": "", "country": "US", "line1": "Street 2, 34567", "line2": "", "postal_code": "94114", "state": "CA"}, "customer_email": "[email protected]", "customer_name": "Test Customer 2", "customer_phone": null, "customer_shipping": {"address": {"city": "", "country": "US", "line1": "Street 2, 34567", "line2": "", "postal_code": "94114", "state": "CA"}, "name": "Test Customer 2", "phone": ""}, "customer_tax_exempt": "none", "customer_tax_ids": [], "default_payment_method": null, "default_source": null, "default_tax_rates": [], "description": "Thanks for your business!", "discount": null, "discounts": [], "due_date": 1677937018, "ending_balance": 0, "footer": "Test Invoice", "from_invoice": null, "hosted_invoice_url": "https://invoice.stripe.com/i/acct_1JwnoiEcXtiJtvvh/test_YWNjdF8xSndub2lFY1h0aUp0dnZoLF9OSGNDT3BXU2sxR0NJUDNaTTZnbXFINW10NHNiaWhDLDY4MDYyMDMx0200A6qC4sqI?s=ap", "invoice_pdf": "https://pay.stripe.com/invoice/acct_1JwnoiEcXtiJtvvh/test_YWNjdF8xSndub2lFY1h0aUp0dnZoLF9OSGNDT3BXU2sxR0NJUDNaTTZnbXFINW10NHNiaWhDLDY4MDYyMDMx0200A6qC4sqI/pdf?s=ap", "last_finalization_error": null, "latest_revision": null, "lines": {"object": "list", "data": [{"id": "il_1MX2yfEcXtiJtvvhiunY2j1x", "object": "line_item", "amount": 25200, "amount_excluding_tax": 25200, "currency": "usd", "description": "edgao-test-product", "discount_amounts": [{"amount": 2520, "discount": "di_1MX2ysEcXtiJtvvh8ORqRVKm"}], "discountable": true, "discounts": ["di_1MX2ysEcXtiJtvvh8ORqRVKm"], "invoice_item": "ii_1MX2yfEcXtiJtvvhfhyOG7SP", "livemode": false, "metadata": {}, "period": {"end": 1675345045, "start": 1675345045}, "plan": null, "price": {"id": "price_1K9GbqEcXtiJtvvhJ3lZe4i5", "object": "price", "active": true, "billing_scheme": "per_unit", "created": 1640124902, "currency": "usd", "custom_unit_amount": null, "livemode": false, "lookup_key": null, "metadata": {}, "nickname": null, "product": "prod_KouQ5ez86yREmB", "recurring": null, "tax_behavior": "inclusive", "tiers_mode": null, "transform_quantity": null, "type": "one_time", "unit_amount": 12600, "unit_amount_decimal": "12600"}, "proration": false, "proration_details": {"credited_items": null}, "quantity": 2, "subscription": null, "tax_amounts": [{"amount": 0, "inclusive": true, "tax_rate": "txr_1MX2yfEcXtiJtvvhVcMEMTRj"}], "tax_rates": [], "type": "invoiceitem", "unit_amount_excluding_tax": "12600"}], "has_more": false, "total_count": 1, "url": "/v1/invoices/in_1MX2yFEcXtiJtvvhMXhUCgKx/lines"}, "livemode": false, "metadata": {}, "next_payment_attempt": null, "number": "C09C1837-0001", "on_behalf_of": null, "paid": true, "paid_out_of_band": false, "payment_intent": "pi_3MX2zPEcXtiJtvvh12VBcp6m", "payment_settings": {"default_mandate": null, "payment_method_options": null, "payment_method_types": null}, "period_end": 1675345018, "period_start": 1675345018, "post_payment_credit_notes_amount": 0, "pre_payment_credit_notes_amount": 0, "quote": null, "receipt_number": null, "rendering_options": null, "shipping_cost": null, "shipping_details": null, "starting_balance": 50000, "statement_descriptor": null, "status": "paid", "status_transitions": {"finalized_at": 1675345090, "marked_uncollectible_at": null, "paid_at": 1675345122, "voided_at": null}, "subscription": null, "subtotal": 22680, "subtotal_excluding_tax": 22680, "tax": 0, "test_clock": null, "total": 22680, "total_discount_amounts": [{"amount": 2520, "discount": "di_1MX2ysEcXtiJtvvh8ORqRVKm"}], "total_excluding_tax": 22680, "total_tax_amounts": [{"amount": 0, "inclusive": true, "tax_rate": "txr_1MX2yfEcXtiJtvvhVcMEMTRj"}], "transfer_data": null, "webhooks_delivered_at": 1675345019}, "emitted_at": 1677521337360}
+{"stream": "invoices", "data": {"id": "in_1MSID7EcXtiJtvvh8OUKak6h", "object": "invoice", "account_country": "US", "account_name": "Airbyte, Inc.", "account_tax_ids": null, "amount_due": 0, "amount_paid": 0, "amount_remaining": 0, "amount_shipping": 0, "application": null, "application_fee_amount": null, "attempt_count": 0, "attempted": false, "auto_advance": false, "automatic_tax": {"enabled": false, "status": null}, "billing_reason": "manual", "charge": null, "collection_method": "send_invoice", "created": 1674211961, "currency": "usd", "custom_fields": null, "customer": "cus_Kou8knsO3qQOwU", "customer_address": null, "customer_email": "[email protected]", "customer_name": "edgao-test-customer-1", "customer_phone": null, "customer_shipping": null, "customer_tax_exempt": "none", "customer_tax_ids": [], "default_payment_method": null, "default_source": null, "default_tax_rates": [], "description": null, "discount": null, "discounts": [], "due_date": 1676803961, "ending_balance": null, "footer": null, "from_invoice": null, "hosted_invoice_url": null, "invoice_pdf": null, "last_finalization_error": null, "latest_revision": null, "lines": {"object": "list", "data": [], "has_more": false, "total_count": 0, "url": "/v1/invoices/in_1MSID7EcXtiJtvvh8OUKak6h/lines"}, "livemode": false, "metadata": {}, "next_payment_attempt": null, "number": null, "on_behalf_of": null, "paid": false, "paid_out_of_band": false, "payment_intent": null, "payment_settings": {"default_mandate": null, "payment_method_options": null, "payment_method_types": null}, "period_end": 1674211961, "period_start": 1674211961, "post_payment_credit_notes_amount": 0, "pre_payment_credit_notes_amount": 0, "quote": null, "receipt_number": null, "rendering_options": null, "shipping_cost": null, "shipping_details": null, "starting_balance": 0, "statement_descriptor": null, "status": "draft", "status_transitions": {"finalized_at": null, "marked_uncollectible_at": null, "paid_at": null, "voided_at": null}, "subscription": null, "subtotal": 0, "subtotal_excluding_tax": 0, "tax": null, "test_clock": null, "total": 0, "total_discount_amounts": [], "total_excluding_tax": 0, "total_tax_amounts": [], "transfer_data": null, "webhooks_delivered_at": 1674211961}, "emitted_at": 1677521337361}
+{"stream": "invoices", "data": {"id": "in_1MSIC3EcXtiJtvvhTUqweBiR", "object": "invoice", "account_country": "US", "account_name": "Airbyte, Inc.", "account_tax_ids": null, "amount_due": 0, "amount_paid": 0, "amount_remaining": 0, "amount_shipping": 0, "application": null, "application_fee_amount": null, "attempt_count": 0, "attempted": false, "auto_advance": false, "automatic_tax": {"enabled": false, "status": null}, "billing_reason": "manual", "charge": null, "collection_method": "send_invoice", "created": 1674211895, "currency": "usd", "custom_fields": null, "customer": "cus_LIiHR6omh14Xdg", "customer_address": {"city": "san francisco", "country": "US", "line1": "san francisco", "line2": "", "postal_code": "", "state": "CA"}, "customer_email": "test@airbyte_integration_test.com", "customer_name": "Test", "customer_phone": null, "customer_shipping": {"address": {"city": "", "country": "US", "line1": "", "line2": "", "postal_code": "", "state": ""}, "name": "", "phone": ""}, "customer_tax_exempt": "none", "customer_tax_ids": [], "default_payment_method": null, "default_source": null, "default_tax_rates": [], "description": null, "discount": null, "discounts": [], "due_date": 1676803894, "ending_balance": null, "footer": null, "from_invoice": null, "hosted_invoice_url": null, "invoice_pdf": null, "last_finalization_error": null, "latest_revision": null, "lines": {"object": "list", "data": [], "has_more": false, "total_count": 0, "url": "/v1/invoices/in_1MSIC3EcXtiJtvvhTUqweBiR/lines"}, "livemode": false, "metadata": {}, "next_payment_attempt": null, "number": null, "on_behalf_of": null, "paid": false, "paid_out_of_band": false, "payment_intent": null, "payment_settings": {"default_mandate": null, "payment_method_options": null, "payment_method_types": null}, "period_end": 1676887929, "period_start": 1674209529, "post_payment_credit_notes_amount": 0, "pre_payment_credit_notes_amount": 0, "quote": null, "receipt_number": null, "rendering_options": null, "shipping_cost": null, "shipping_details": null, "starting_balance": 0, "statement_descriptor": null, "status": "draft", "status_transitions": {"finalized_at": null, "marked_uncollectible_at": null, "paid_at": null, "voided_at": null}, "subscription": null, "subtotal": 0, "subtotal_excluding_tax": 0, "tax": null, "test_clock": null, "total": 0, "total_discount_amounts": [], "total_excluding_tax": 0, "total_tax_amounts": [], "transfer_data": null, "webhooks_delivered_at": 1674211895}, "emitted_at": 1677521337362}
+{"stream": "invoices", "data": {"id": "in_1MSHsIEcXtiJtvvhYaiyckhp", "object": "invoice", "account_country": "US", "account_name": "Airbyte, Inc.", "account_tax_ids": null, "amount_due": 0, "amount_paid": 0, "amount_remaining": 0, "amount_shipping": 0, "application": null, "application_fee_amount": null, "attempt_count": 0, "attempted": false, "auto_advance": false, "automatic_tax": {"enabled": true, "status": "complete"}, "billing_reason": "manual", "charge": null, "collection_method": "send_invoice", "created": 1674210670, "currency": "usd", "custom_fields": null, "customer": "cus_LIiHR6omh14Xdg", "customer_address": {"city": "san francisco", "country": "US", "line1": "san francisco", "line2": "", "postal_code": "", "state": "CA"}, "customer_email": "test@airbyte_integration_test.com", "customer_name": "Test", "customer_phone": null, "customer_shipping": {"address": {"city": "", "country": "US", "line1": "", "line2": "", "postal_code": "", "state": ""}, "name": "", "phone": ""}, "customer_tax_exempt": "none", "customer_tax_ids": [], "default_payment_method": null, "default_source": null, "default_tax_rates": [], "description": null, "discount": null, "discounts": [], "due_date": 1676802670, "ending_balance": null, "footer": null, "from_invoice": null, "hosted_invoice_url": null, "invoice_pdf": null, "last_finalization_error": null, "latest_revision": null, "lines": {"object": "list", "data": [], "has_more": false, "total_count": 0, "url": "/v1/invoices/in_1MSHsIEcXtiJtvvhYaiyckhp/lines"}, "livemode": false, "metadata": {}, "next_payment_attempt": null, "number": null, "on_behalf_of": null, "paid": false, "paid_out_of_band": false, "payment_intent": null, "payment_settings": {"default_mandate": null, "payment_method_options": null, "payment_method_types": null}, "period_end": 1676887929, "period_start": 1674209529, "post_payment_credit_notes_amount": 0, "pre_payment_credit_notes_amount": 0, "quote": null, "receipt_number": null, "rendering_options": null, "shipping_cost": null, "shipping_details": null, "starting_balance": 0, "statement_descriptor": null, "status": "draft", "status_transitions": {"finalized_at": null, "marked_uncollectible_at": null, "paid_at": null, "voided_at": null}, "subscription": null, "subtotal": 0, "subtotal_excluding_tax": 0, "tax": null, "test_clock": null, "total": 0, "total_discount_amounts": [], "total_excluding_tax": 0, "total_tax_amounts": [], "transfer_data": null, "webhooks_delivered_at": 1674210670}, "emitted_at": 1677521337363}


👍 fake user

roman-yermilov-gl · 2023-02-28T20:48:40Z

/publish connector=connectors/source-stripe

🕑 Publishing the following connectors:
connectors/source-stripe
https://github.com/airbytehq/airbyte/actions/runs/4297259717

Connector	Did it publish?	Were definitions generated?
connectors/source-stripe	❌	❌

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

roman-yermilov-gl · 2023-02-28T23:08:37Z

/test connector=connectors/source-stripe

🕑 connectors/source-stripe https://github.com/airbytehq/airbyte/actions/runs/4298234425
✅ connectors/source-stripe https://github.com/airbytehq/airbyte/actions/runs/4298234425
Python tests coverage:

Name                                     Stmts   Miss  Cover
------------------------------------------------------------
source_stripe/source.py                     22      0   100%
source_stripe/__init__.py                    2      0   100%
source_stripe/streams.py                   311     27    91%
source_stripe/availability_strategy.py      19      2    89%
------------------------------------------------------------
TOTAL                                      354     29    92%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:509: The previous and actual discovered catalogs are identical.
================== 35 passed, 2 skipped in 232.83s (0:03:52) ===================

* Source Stripe: enable high strictness level * Source Stripe: better bypass_reason description * Source Stripe: add receipt_number to ignored fields * Source Stripe: rollback version and changelog

roman-yermilov-gl requested review from arsenlosenko, bazarnov and lazebnyi January 13, 2023 19:26

roman-yermilov-gl self-assigned this Jan 13, 2023

octavia-squidington-iv added area/connectors Connector related issues connectors/source/stripe labels Jan 13, 2023

roman-yermilov-gl force-pushed the ryermilov/source-stripe-enable-high-test-strictness-level branch from 05bde50 to d8fc49e Compare January 14, 2023 11:44

lazebnyi approved these changes Jan 16, 2023

View reviewed changes

roman-yermilov-gl linked an issue Jan 17, 2023 that may be closed by this pull request

Source Stripe: enable high test strictness level in SAT #19075

Closed

roman-yermilov-gl force-pushed the ryermilov/source-stripe-enable-high-test-strictness-level branch from d8fc49e to 91c20bb Compare February 7, 2023 14:52

octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Feb 7, 2023

roman-yermilov-gl requested a review from lazebnyi February 7, 2023 14:58

bazarnov requested changes Feb 7, 2023

View reviewed changes

airbyte-integrations/connectors/source-stripe/source_stripe/schemas/invoices.json Outdated Show resolved Hide resolved

roman-yermilov-gl temporarily deployed to more-secrets February 8, 2023 10:22 — with GitHub Actions Inactive

lazebnyi approved these changes Feb 8, 2023

View reviewed changes

roman-yermilov-gl temporarily deployed to more-secrets February 8, 2023 11:19 — with GitHub Actions Inactive

roman-yermilov-gl temporarily deployed to more-secrets February 8, 2023 12:24 — with GitHub Actions Inactive

lazebnyi requested a review from bazarnov February 8, 2023 13:29

bazarnov approved these changes Feb 8, 2023

View reviewed changes

roman-yermilov-gl force-pushed the ryermilov/source-stripe-enable-high-test-strictness-level branch from 08ebdc3 to 702412c Compare February 8, 2023 18:14

roman-yermilov-gl temporarily deployed to more-secrets February 8, 2023 18:16 — with GitHub Actions Inactive

roman-yermilov-gl requested a review from pedroslopez February 8, 2023 19:37

lazebnyi requested a review from evantahler February 9, 2023 13:31

evantahler requested changes Feb 9, 2023

View reviewed changes

evantahler mentioned this pull request Feb 9, 2023

[SAT] ignored_fields key for basic read test #21737

Closed

davydov-d mentioned this pull request Feb 15, 2023

Source Stripe: fix schema #22312

Merged

roman-yermilov-gl force-pushed the ryermilov/source-stripe-enable-high-test-strictness-level branch from 702412c to 4128779 Compare February 27, 2023 20:47

roman-yermilov-gl and others added 2 commits February 28, 2023 00:48

Source Stripe: enable high strictness level

4128779

Merge branch 'master' into ryermilov/source-stripe-enable-high-test-s…

ff7daae

…trictness-level

roman-yermilov-gl added 3 commits February 28, 2023 19:06

Source Stripe: better bypass_reason description

7018fc1

Merge branch 'ryermilov/source-stripe-enable-high-test-strictness-lev…

5533d38

…el' of github.com:airbytehq/airbyte into ryermilov/source-stripe-enable-high-test-strictness-level

Merge branch 'master' into ryermilov/source-stripe-enable-high-test-s…

46edb68

…trictness-level

roman-yermilov-gl requested review from lazebnyi, bazarnov, evantahler and alafanechere February 28, 2023 16:39

evantahler approved these changes Feb 28, 2023

View reviewed changes

lazebnyi approved these changes Feb 28, 2023

View reviewed changes

Source Stripe: add receipt_number to ignored fields

f61ad80

octavia-squidington-iii removed the area/documentation Improvements or additions to documentation label Feb 28, 2023

Source Stripe: rollback version and changelog

5a6329f

roman-yermilov-gl merged commit 327ceaa into master Feb 28, 2023

roman-yermilov-gl deleted the ryermilov/source-stripe-enable-high-test-strictness-level branch February 28, 2023 23:53

evantahler mentioned this pull request Mar 1, 2023

[non-forked] 🐛 Source Stripe: Add missing field (cancel_at) to the Subscriptions stream #23452

Merged

14 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Source Stripe: enable high strictness level #21419

Source Stripe: enable high strictness level #21419

roman-yermilov-gl commented Jan 13, 2023

roman-yermilov-gl commented Jan 13, 2023 •

edited by github-actions bot

Loading

roman-yermilov-gl commented Feb 7, 2023 •

edited by github-actions bot

Loading

bazarnov left a comment

github-actions bot commented Feb 8, 2023

roman-yermilov-gl commented Feb 8, 2023 •

edited by github-actions bot

Loading

roman-yermilov-gl commented Feb 8, 2023 •

edited by github-actions bot

Loading

roman-yermilov-gl commented Feb 8, 2023 •

edited by github-actions bot

Loading

roman-yermilov-gl commented Feb 8, 2023 •

edited by github-actions bot

Loading

evantahler Feb 9, 2023

evantahler Feb 9, 2023

roman-yermilov-gl Feb 9, 2023

alafanechere Feb 9, 2023 •

edited

Loading

roman-yermilov-gl Feb 14, 2023

roman-yermilov-gl commented Feb 28, 2023 •

edited by github-actions bot

Loading

evantahler Feb 28, 2023

roman-yermilov-gl Feb 28, 2023

evantahler Feb 28, 2023

evantahler Feb 28, 2023

evantahler Feb 28, 2023

evantahler Feb 28, 2023

evantahler Feb 28, 2023

roman-yermilov-gl commented Feb 28, 2023 •

edited by github-actions bot

Loading

roman-yermilov-gl commented Feb 28, 2023 •

edited by github-actions bot

Loading

		- name: "charges"
		bypass_reason: "This stream produces unique data every time it runs. Fields: receipt_url"

Source Stripe: enable high strictness level #21419

Source Stripe: enable high strictness level #21419

Conversation

roman-yermilov-gl commented Jan 13, 2023

What

roman-yermilov-gl commented Jan 13, 2023 • edited by github-actions bot Loading

Build Passed

roman-yermilov-gl commented Feb 7, 2023 • edited by github-actions bot Loading

Build Failed

bazarnov left a comment

Choose a reason for hiding this comment

github-actions bot commented Feb 8, 2023

Airbyte Code Coverage

roman-yermilov-gl commented Feb 8, 2023 • edited by github-actions bot Loading

Build Failed

roman-yermilov-gl commented Feb 8, 2023 • edited by github-actions bot Loading

Build Failed

roman-yermilov-gl commented Feb 8, 2023 • edited by github-actions bot Loading

Build Passed

roman-yermilov-gl commented Feb 8, 2023 • edited by github-actions bot Loading

Build Passed

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

alafanechere Feb 9, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

roman-yermilov-gl commented Feb 28, 2023 • edited by github-actions bot Loading

Build Passed

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

roman-yermilov-gl commented Feb 28, 2023 • edited by github-actions bot Loading

roman-yermilov-gl commented Feb 28, 2023 • edited by github-actions bot Loading

Build Passed

roman-yermilov-gl commented Jan 13, 2023 •

edited by github-actions bot

Loading

roman-yermilov-gl commented Feb 7, 2023 •

edited by github-actions bot

Loading

roman-yermilov-gl commented Feb 8, 2023 •

edited by github-actions bot

Loading

roman-yermilov-gl commented Feb 8, 2023 •

edited by github-actions bot

Loading

roman-yermilov-gl commented Feb 8, 2023 •

edited by github-actions bot

Loading

roman-yermilov-gl commented Feb 8, 2023 •

edited by github-actions bot

Loading

alafanechere Feb 9, 2023 •

edited

Loading

roman-yermilov-gl commented Feb 28, 2023 •

edited by github-actions bot

Loading

roman-yermilov-gl commented Feb 28, 2023 •

edited by github-actions bot

Loading

roman-yermilov-gl commented Feb 28, 2023 •

edited by github-actions bot

Loading