ci_credentials: disable tooling test run by tox #21580

alafanechere · 2023-01-19T08:24:28Z

What

Closes #21578
tox is used in the CI to run tests on the python packages before we install them.
These python packages are installed to provide the required tooling for connector testing.
Actually testing them in this context does not look required.

tox was introduced by #8561 but I don't have context why it was added to the tooling install step. Maybe for env consistency guarantees 🤔

How

Remove tox commands from the /publish and /test commands.

alafanechere · 2023-01-19T08:29:52Z

/test connector=connectors/source-gitlab

🕑 connectors/source-gitlab https://github.com/airbytehq/airbyte/actions/runs/3956644355
✅ connectors/source-gitlab https://github.com/airbytehq/airbyte/actions/runs/3956644355
Python tests coverage:

Name                        Stmts   Miss  Cover
-----------------------------------------------
source_gitlab/__init__.py       2      0   100%
source_gitlab/source.py        61      3    95%
source_gitlab/streams.py      244     13    95%
-----------------------------------------------
TOTAL                         307     16    95%
	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          12      4    67%   16-19
	 source_acceptance_test/config.py                       141      5    96%   87, 93, 239, 243-244
	 source_acceptance_test/conftest.py                     211     95    55%   36, 42-44, 49, 54, 77, 83, 89-91, 110, 115-117, 123-125, 131-132, 137-138, 143, 149, 158-167, 173-178, 193, 217, 248, 254, 262-267, 275-285, 293-306, 311-317, 324-335, 342-358
	 source_acceptance_test/plugin.py                        69     25    64%   22-23, 31, 36, 120-140, 144-148
	 source_acceptance_test/tests/test_core.py              402    115    71%   53, 58, 93-104, 109-116, 120-121, 125-126, 308, 346-363, 376-387, 391-396, 402, 435-440, 478-485, 528-530, 533, 598-606, 618-621, 626, 682-683, 689, 692, 728-738, 751-776
	 source_acceptance_test/tests/test_incremental.py       160     14    91%   58-65, 70-83, 246
	 source_acceptance_test/utils/asserts.py                 39      2    95%   62-63
	 source_acceptance_test/utils/common.py                  94     10    89%   16-17, 32-38, 72, 75
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/connector_runner.py       133     33    75%   24-27, 46-47, 50-54, 57-58, 73-75, 78-80, 83-85, 88-90, 93-95, 124-125, 159-161, 208
	 source_acceptance_test/utils/json_schema_helper.py     107     13    88%   30-31, 38, 41, 65-68, 96, 120, 192-194
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1609    339    79%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:94: The previous and actual specifications are identical.
SKIPPED [2] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:377: The previous and actual discovered catalogs are identical.
================== 42 passed, 3 skipped in 337.62s (0:05:37) ===================

github-actions · 2023-01-19T08:37:19Z

Airbyte Code Coverage

There is no coverage information present for the Files changed

Total Project Coverage	26.77%	🍏

alafanechere · 2023-01-19T08:38:09Z

I can't actually run /test command from this branch to check the GHA change because the /test dispatches a workflow which will run on master. I'll manually dispatch a test run and share results here.

alafanechere · 2023-01-19T08:47:17Z

destination-clickhouse /test with GitHub action from this branch -> 🔴

The tests are not passing but this is for a reason unrelated to the current changes.

alafanechere · 2023-01-19T08:49:08Z

source-gitlab /test with Github actions from this branch -> ✅

alafanechere · 2023-01-19T09:42:13Z

/approve-and-merge reason="This fix is urgent to get connectors tests working again and the side effects are low"

octavia-approvington · 2023-01-19T09:42:53Z

Enough! Let's do this

* disable tox * rename steps * revert changes on experimental workflow * do not install tox

* api changes for writing discover catalog * api changes * format * worker change 1 * change return type of the API to return catalogId * worker to call api * typo * 🎉 Source GoogleSheets - migrated SAT to strictness level (#21399) * migrated SAT to strictness level * fixed expected records * revert file from another source * changed extension to txt * changed extension to txt * 🐛Destination-Bigquery: Added an explicit error message if sync fails due to a config issue (#21144) * [19998] Destination-Bigquery: Added an explicit error message in sync fails due to a config issue * ci-connector-ops: split workflows(#21474) * CI: nightly build alpha sources and destinations (#21562) * Revert "Change main class in strict-encrypt destination and bump versions on both destinations to keep them in sync (#21509)" (#21567) This reverts commit 1d202d1. * Fixes webhook updating logic (#21519) * ci_credentials: disable tooling test run by tox (#21580) * disable tox * rename steps * revert changes on experimental workflow * do not install tox * Revert "CI: nightly build alpha sources and destinations (#21562)" (#21589) This reverts commit 61f88f3. * Security update of default docker images (#21407) Because there is a lot of CVEs in those releases. Co-authored-by: Topher Lubaway <[email protected]> * 📝 add docs for how to add normalization (#21563) * add docs * add schema link * update based on feedback * 🪟 🚦 E2E tests: clean up matchers (#20887) * improve serviceTypeDropdownOption selector * add test ids to PathPopout component(s) * add unique id's to table dropdowns * extend submitButtonClick to support optional click options * update dropdown(pathPopout) matchers * add test-id to Overlay component * remove redundant function brackets * revert changes onSubmit button click * fix dropDown overlay issue * move all duplicated intercepters to beforeEach * add test id's to Connections, Sources and Destinations tables * add table helper functions * update source page actions * intercepter fixes * update createTestConnection function with optional replication settings * remove extra Connection name check * replace "cypress-postgres" with "pg-promise" npm package * update cypress config * Revert "update createTestConnection function with optional replication settings" This reverts commit 8e47c78. * Revert "remove extra Connection name check" This reverts commit dfb19c7. * replace openSourceDestinationFromGrid with specific selector * replace openSourceDestinationFromGrid with specific selector * turn on test * add test-id's * fix selectors * update test * update test snapshots * fix lost data-testid after resolve merge conflicts * remove extra check * move clickOnCellInTable helper to common.ts file * remove empty line and comments * fix dropdownType * replace partial string check with exact * extract interceptors and waiters to separate file * fix selector for predefined PK * fix selector * add comment regarding dropdown * 🪟 🎨 [Free connectors] Update modal copy (#21600) * move start/end time options out of optional block (#21541) * lingering fix * reflecting api changes * test fix * worker to call api to do discover work * recovered deleted html * self review * more converters refactor * fix connector test * fix test * fix * fix integration test * add unit test for converter * static fix * api client needs to have a timeout in case request does not get responded --------- Co-authored-by: midavadim <[email protected]> Co-authored-by: Eugene <[email protected]> Co-authored-by: Augustin <[email protected]> Co-authored-by: Greg Solovyev <[email protected]> Co-authored-by: Yatsuk Bogdan <[email protected]> Co-authored-by: Hervé Commowick <[email protected]> Co-authored-by: Topher Lubaway <[email protected]> Co-authored-by: Pedro S. Lopez <[email protected]> Co-authored-by: Vladimir <[email protected]> Co-authored-by: Joey Marshment-Howell <[email protected]> Co-authored-by: Lake Mossman <[email protected]>

* api changes for writing discover catalog * api changes * format * worker change 1 * change return type of the API to return catalogId * worker to call api * typo * 🎉 Source GoogleSheets - migrated SAT to strictness level (#21399) * migrated SAT to strictness level * fixed expected records * revert file from another source * changed extension to txt * changed extension to txt * 🐛Destination-Bigquery: Added an explicit error message if sync fails due to a config issue (#21144) * [19998] Destination-Bigquery: Added an explicit error message in sync fails due to a config issue * ci-connector-ops: split workflows(#21474) * CI: nightly build alpha sources and destinations (#21562) * Revert "Change main class in strict-encrypt destination and bump versions on both destinations to keep them in sync (#21509)" (#21567) This reverts commit 1d202d1. * Fixes webhook updating logic (#21519) * ci_credentials: disable tooling test run by tox (#21580) * disable tox * rename steps * revert changes on experimental workflow * do not install tox * Revert "CI: nightly build alpha sources and destinations (#21562)" (#21589) This reverts commit 61f88f3. * Security update of default docker images (#21407) Because there is a lot of CVEs in those releases. Co-authored-by: Topher Lubaway <[email protected]> * 📝 add docs for how to add normalization (#21563) * add docs * add schema link * update based on feedback * 🪟 🚦 E2E tests: clean up matchers (#20887) * improve serviceTypeDropdownOption selector * add test ids to PathPopout component(s) * add unique id's to table dropdowns * extend submitButtonClick to support optional click options * update dropdown(pathPopout) matchers * add test-id to Overlay component * remove redundant function brackets * revert changes onSubmit button click * fix dropDown overlay issue * move all duplicated intercepters to beforeEach * add test id's to Connections, Sources and Destinations tables * add table helper functions * update source page actions * intercepter fixes * update createTestConnection function with optional replication settings * remove extra Connection name check * replace "cypress-postgres" with "pg-promise" npm package * update cypress config * Revert "update createTestConnection function with optional replication settings" This reverts commit 8e47c78. * Revert "remove extra Connection name check" This reverts commit dfb19c7. * replace openSourceDestinationFromGrid with specific selector * replace openSourceDestinationFromGrid with specific selector * turn on test * add test-id's * fix selectors * update test * update test snapshots * fix lost data-testid after resolve merge conflicts * remove extra check * move clickOnCellInTable helper to common.ts file * remove empty line and comments * fix dropdownType * replace partial string check with exact * extract interceptors and waiters to separate file * fix selector for predefined PK * fix selector * add comment regarding dropdown * 🪟 🎨 [Free connectors] Update modal copy (#21600) * move start/end time options out of optional block (#21541) * lingering fix * reflecting api changes * test fix * reset to master * routing changes * remove unexpected merge * resolve dependency micronaut * resolve dependency * format * fix test * rename and refactor location of test files * test * redo the routing service * add test to config repository * query workspace not connection for discover/check * remove unused bean --------- Co-authored-by: midavadim <[email protected]> Co-authored-by: Eugene <[email protected]> Co-authored-by: Augustin <[email protected]> Co-authored-by: Greg Solovyev <[email protected]> Co-authored-by: Yatsuk Bogdan <[email protected]> Co-authored-by: Hervé Commowick <[email protected]> Co-authored-by: Topher Lubaway <[email protected]> Co-authored-by: Pedro S. Lopez <[email protected]> Co-authored-by: Vladimir <[email protected]> Co-authored-by: Joey Marshment-Howell <[email protected]> Co-authored-by: Lake Mossman <[email protected]>

alafanechere added 3 commits January 19, 2023 09:17

disable tox

857acb3

rename steps

3eb6cec

revert changes on experimental workflow

fdee88a

alafanechere marked this pull request as ready for review January 19, 2023 08:27

alafanechere temporarily deployed to more-secrets January 19, 2023 08:29 — with GitHub Actions Inactive

airbytehq deleted a comment from github-actions bot Jan 19, 2023

alafanechere temporarily deployed to more-secrets January 19, 2023 08:41 — with GitHub Actions Inactive

do not install tox

ae0415d

alafanechere temporarily deployed to more-secrets January 19, 2023 08:45 — with GitHub Actions Inactive

alafanechere temporarily deployed to more-secrets January 19, 2023 08:50 — with GitHub Actions Inactive

octavia-approvington approved these changes Jan 19, 2023

View reviewed changes

octavia-approvington merged commit 295fcec into master Jan 19, 2023

octavia-approvington deleted the augustin/disable-ci-tools-testing branch January 19, 2023 09:42

xiaohansong pushed a commit that referenced this pull request Jan 20, 2023

ci_credentials: disable tooling test run by tox (#21580)

35c83ff

* disable tox * rename steps * revert changes on experimental workflow * do not install tox

octavia-squidington-iii mentioned this pull request Jan 24, 2023

Bump Airbyte version from 0.40.28 to 0.40.29 #21767

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ci_credentials: disable tooling test run by tox #21580

ci_credentials: disable tooling test run by tox #21580

alafanechere commented Jan 19, 2023 •

edited

Loading

alafanechere commented Jan 19, 2023 •

edited by github-actions bot

Loading

github-actions bot commented Jan 19, 2023

alafanechere commented Jan 19, 2023

alafanechere commented Jan 19, 2023 •

edited

Loading

alafanechere commented Jan 19, 2023 •

edited

Loading

alafanechere commented Jan 19, 2023

octavia-approvington commented Jan 19, 2023

ci_credentials: disable tooling test run by tox #21580

ci_credentials: disable tooling test run by tox #21580

Conversation

alafanechere commented Jan 19, 2023 • edited Loading

What

How

alafanechere commented Jan 19, 2023 • edited by github-actions bot Loading

Build Passed

github-actions bot commented Jan 19, 2023

Airbyte Code Coverage

alafanechere commented Jan 19, 2023

alafanechere commented Jan 19, 2023 • edited Loading

alafanechere commented Jan 19, 2023 • edited Loading

alafanechere commented Jan 19, 2023

octavia-approvington commented Jan 19, 2023

alafanechere commented Jan 19, 2023 •

edited

Loading

alafanechere commented Jan 19, 2023 •

edited by github-actions bot

Loading

alafanechere commented Jan 19, 2023 •

edited

Loading

alafanechere commented Jan 19, 2023 •

edited

Loading