Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add @Ignore to test that can be unpredicatable #21621

Merged
merged 2 commits into from
Jan 19, 2023
Merged

add @Ignore to test that can be unpredicatable #21621

merged 2 commits into from
Jan 19, 2023

Conversation

colesnodgrass
Copy link
Member

What

  • skip test that can fail due to timing issues with watching for file updates
  • this has bit a few people already, so disabling this test until it can be relocated to a non-unit-test suite

How

  • @Ignore test that is unpredictable

jdpgrailsdev
jdpgrailsdev approved these changes Jan 19, 2023
View reviewed changes
Copy link
Contributor

@jdpgrailsdev jdpgrailsdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@colesnodgrass colesnodgrass temporarily deployed to more-secrets January 19, 2023 21:31 — with GitHub Actions Inactive
@colesnodgrass colesnodgrass temporarily deployed to more-secrets January 19, 2023 21:31 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

Airbyte Code Coverage

There is no coverage information present for the Files changed

Total Project Coverage 26.75% 🍏

@colesnodgrass colesnodgrass temporarily deployed to more-secrets January 19, 2023 21:54 — with GitHub Actions Inactive
@colesnodgrass colesnodgrass temporarily deployed to more-secrets January 19, 2023 21:54 — with GitHub Actions Inactive
@colesnodgrass colesnodgrass merged commit c569584 into master Jan 19, 2023
@colesnodgrass colesnodgrass deleted the cole/disable-test branch January 19, 2023 22:31
@octavia-squidington-iii octavia-squidington-iii mentioned this pull request Jan 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdpgrailsdev jdpgrailsdev jdpgrailsdev approved these changes

@benmoriceau benmoriceau benmoriceau approved these changes

@gosusnp gosusnp Awaiting requested review from gosusnp

@davinchia davinchia Awaiting requested review from davinchia

@alovew alovew Awaiting requested review from alovew

@mfsiega-airbyte mfsiega-airbyte Awaiting requested review from mfsiega-airbyte

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@colesnodgrass @jdpgrailsdev @benmoriceau