Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add @Ignore to test that can be unpredicatable #21621

Merged
merged 2 commits into from
Jan 19, 2023
Merged

add @Ignore to test that can be unpredicatable #21621

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a3b47c5
add @Ignore to test that can be unpredicatable
colesnodgrass Jan 19, 2023
5ced39c
Merge branch 'master' into cole/disable-test
colesnodgrass Jan 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions airbyte-featureflag/src/test/kotlin/ClientTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ import java.nio.file.Path
import java.util.concurrent.TimeUnit
import kotlin.io.path.createTempFile
import kotlin.io.path.writeText
import kotlin.test.Ignore
import kotlin.test.assertFailsWith
import kotlin.test.assertFalse
import kotlin.test.assertTrue
Expand All @@ -48,7 +49,16 @@ class ConfigFileClient {
}
}

/**
* Ignore this test for now as it is unreliable in a unit-test scenario due to the
* unpredictable nature of knowing when the WatchService (inside the ConfigFileClient) will
* actually see the changed file. Currently, this test sleeps for a few seconds, which works 90%
* of the time, however there has been instances where it has taken over 20 seconds.
*
* TODO: move this to a different test suite
*/
@Test
@Ignore
fun `verify platform reload capabilities`() {
val contents0 = """flags:
| - name: reload-test-true
Expand Down