Source freshdesk: deduplicate table names #22164

davydov-d · 2023-01-31T19:32:28Z

What

https://github.com/airbytehq/oncall/issues/1339

How

There's a nested object called business_hours in the business_hours stream. When normalization comes into action, there's a name collision so one of the tables has to be renamed

davydov-d · 2023-01-31T19:40:32Z

/test connector=connectors/source-freshdesk

🕑 connectors/source-freshdesk https://github.com/airbytehq/airbyte/actions/runs/4057723122

davydov-d · 2023-01-31T19:48:47Z

/test connector=connectors/source-freshdesk

🕑 connectors/source-freshdesk https://github.com/airbytehq/airbyte/actions/runs/4057780052
❌ connectors/source-freshdesk https://github.com/airbytehq/airbyte/actions/runs/4057780052
🐛 https://gradle.com/s/uhhx6p2gamgae

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestBasicRead::test_read[inputs0] - Failed: Stream conta...
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:98: The previous and actual specifications are identical.
============= 1 failed, 35 passed, 1 skipped in 346.37s (0:05:46) ==============

davydov-d · 2023-02-01T08:51:56Z

/test connector=connectors/source-freshdesk

🕑 connectors/source-freshdesk https://github.com/airbytehq/airbyte/actions/runs/4062546964
❌ connectors/source-freshdesk https://github.com/airbytehq/airbyte/actions/runs/4062546964
🐛 https://gradle.com/s/m7lysjo7j6gmy

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestBasicRead::test_read[inputs0] - Failed: Stream conta...
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:98: The previous and actual specifications are identical.
============= 1 failed, 35 passed, 1 skipped in 358.64s (0:05:58) ==============

davydov-d · 2023-02-01T12:01:25Z

/test connector=connectors/source-freshdesk

🕑 connectors/source-freshdesk https://github.com/airbytehq/airbyte/actions/runs/4064107866
✅ connectors/source-freshdesk https://github.com/airbytehq/airbyte/actions/runs/4064107866
Python tests coverage:

Name                           Stmts   Miss  Cover
--------------------------------------------------
source_freshdesk/source.py        31      0   100%
source_freshdesk/__init__.py       2      0   100%
source_freshdesk/streams.py      229      4    98%
source_freshdesk/utils.py         20      1    95%
--------------------------------------------------
TOTAL                            282      5    98%
	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          12      4    67%   16-19
	 source_acceptance_test/config.py                       141      5    96%   87, 93, 239, 243-244
	 source_acceptance_test/conftest.py                     211     95    55%   36, 42-44, 49, 54, 77, 83, 89-91, 110, 115-117, 123-125, 131-132, 137-138, 143, 149, 158-167, 173-178, 193, 217, 248, 254, 262-267, 275-285, 293-306, 311-317, 324-335, 342-358
	 source_acceptance_test/plugin.py                        69     25    64%   22-23, 31, 36, 120-140, 144-148
	 source_acceptance_test/tests/test_core.py              476    117    75%   53, 58, 97-108, 113-120, 124-125, 129-130, 380, 400, 438, 476-493, 506-517, 521-526, 532, 565-570, 608-615, 658-660, 663, 728-736, 748-751, 756, 812-813, 819, 822, 858-868, 881-906
	 source_acceptance_test/tests/test_incremental.py       160     14    91%   58-65, 70-83, 246
	 source_acceptance_test/utils/asserts.py                 39      2    95%   62-63
	 source_acceptance_test/utils/common.py                  94     10    89%   16-17, 32-38, 72, 75
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/connector_runner.py       133     33    75%   24-27, 46-47, 50-54, 57-58, 73-75, 78-80, 83-85, 88-90, 93-95, 124-125, 159-161, 208
	 source_acceptance_test/utils/json_schema_helper.py     114     13    89%   31-32, 39, 42, 66-69, 97, 121, 203-205
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1690    341    80%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:98: The previous and actual specifications are identical.
================== 36 passed, 1 skipped in 351.47s (0:05:51) ===================

davydov-d · 2023-02-06T09:59:44Z

/publish connector=connectors/source-freshdesk

🕑 Publishing the following connectors:
connectors/source-freshdesk
https://github.com/airbytehq/airbyte/actions/runs/4102438203

Connector	Did it publish?	Were definitions generated?
connectors/source-freshdesk	✅	✅

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

github-actions · 2023-02-06T10:34:22Z

Airbyte Code Coverage

There is no coverage information present for the Files changed

Total Project Coverage	24.52%	❌

…-duplicate-naming

davydov-d · 2023-02-06T15:09:50Z

/approve-and-merge reason="On-call related connector release scheduled for Feb 06 10 AM EST"

octavia-approvington · 2023-02-06T15:10:26Z

It's time

* master: Discover worker starts to use API to write schema result (#21875) 🪟 🎉 Connector Builder Landing Page (#22122) Fix pnpm cache path (#22418) Add additional shorter setup guides (#22318) Source Amazon Ads: fix reports stream records primary keys (#21677) Connector acceptance test: Fix discovered catalog caching for different configs (#22301) 🪟🐛 Make modal scrollable (#21973) only compute diff if the schema discovery actually succeeded (#22377) Source Klaviyo: fix schema (#22071) 🪟 🔧 Switch to `pnpm` for package managing (#22053) Source Sentry: turn on default availability strategy (#22303) Source freshdesk: deduplicate table names (#22164)

* master: (86 commits) Discover worker starts to use API to write schema result (#21875) 🪟 🎉 Connector Builder Landing Page (#22122) Fix pnpm cache path (#22418) Add additional shorter setup guides (#22318) Source Amazon Ads: fix reports stream records primary keys (#21677) Connector acceptance test: Fix discovered catalog caching for different configs (#22301) 🪟🐛 Make modal scrollable (#21973) only compute diff if the schema discovery actually succeeded (#22377) Source Klaviyo: fix schema (#22071) 🪟 🔧 Switch to `pnpm` for package managing (#22053) Source Sentry: turn on default availability strategy (#22303) Source freshdesk: deduplicate table names (#22164) Update connector-acceptance-tests-reference.md (#22370) Update the default security groups for the EC2 runner (#22347) Trace refresh schema operations (#22326) Remove manual docker upgrades from workflows (#22344) Update CODEOWNERS for connector acceptance tests to connector ops (#22341) 🐛 source: airtable - handle singleSelect types (#22311) Source tiktok: chunk advertiser IDs (#22309) 🪟 🧪 E2E Tests for auto-detect schema changes (#20682) ...

* master: (24 commits) Discover worker starts to use API to write schema result (#21875) 🪟 🎉 Connector Builder Landing Page (#22122) Fix pnpm cache path (#22418) Add additional shorter setup guides (#22318) Source Amazon Ads: fix reports stream records primary keys (#21677) Connector acceptance test: Fix discovered catalog caching for different configs (#22301) 🪟🐛 Make modal scrollable (#21973) only compute diff if the schema discovery actually succeeded (#22377) Source Klaviyo: fix schema (#22071) 🪟 🔧 Switch to `pnpm` for package managing (#22053) Source Sentry: turn on default availability strategy (#22303) Source freshdesk: deduplicate table names (#22164) Update connector-acceptance-tests-reference.md (#22370) Update the default security groups for the EC2 runner (#22347) Trace refresh schema operations (#22326) Remove manual docker upgrades from workflows (#22344) Update CODEOWNERS for connector acceptance tests to connector ops (#22341) 🐛 source: airtable - handle singleSelect types (#22311) Source tiktok: chunk advertiser IDs (#22309) 🪟 🧪 E2E Tests for auto-detect schema changes (#20682) ...

#1339 source freshdesk: deduplicate table names

ed91e32

octavia-squidington-iv added area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/freshdesk labels Jan 31, 2023

#1339 source freshdesk: upd changelog

e83a745

davydov-d requested review from lazebnyi and roman-yermilov-gl January 31, 2023 19:44

#1339 source freshdeskL upd expected records

bbddf8b

#1339 source freshdesk: upd expected records

0a72e1a

#1339 source freshdesk - updated expected records

7bc9a43

davydov-d requested review from girarda and pedroslopez February 1, 2023 12:01

lazebnyi approved these changes Feb 1, 2023

View reviewed changes

girarda approved these changes Feb 1, 2023

View reviewed changes

auto-bump connector version

6b04906

airbyteio temporarily deployed to more-secrets February 6, 2023 10:27 — with GitHub Actions Inactive

Merge branch 'master' into ddavydov/#1339-source-freshdesk-fix-nested…

f4ac303

…-duplicate-naming

davydov-d temporarily deployed to more-secrets February 6, 2023 14:32 — with GitHub Actions Inactive

octavia-approvington approved these changes Feb 6, 2023

View reviewed changes

octavia-approvington merged commit a6c310c into master Feb 6, 2023

octavia-approvington deleted the ddavydov/#1339-source-freshdesk-fix-nested-duplicate-naming branch February 6, 2023 15:10

github-actions bot mentioned this pull request Feb 7, 2023

Bump helm chart version reference to 0.43.28 #22489

Closed

This was referenced Feb 8, 2023

Bump Airbyte version from 0.40.32 to 0.40.33 #22578

Closed

Bump Airbyte version from 0.40.32 to 0.40.33 #22689

Closed

Bump Airbyte version from 0.40.32 to 0.40.33 #22839

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Source freshdesk: deduplicate table names #22164

Source freshdesk: deduplicate table names #22164

davydov-d commented Jan 31, 2023

davydov-d commented Jan 31, 2023 •

edited by github-actions bot

Loading

davydov-d commented Jan 31, 2023 •

edited by github-actions bot

Loading

davydov-d commented Feb 1, 2023 •

edited by github-actions bot

Loading

davydov-d commented Feb 1, 2023 •

edited by github-actions bot

Loading

davydov-d commented Feb 6, 2023 •

edited by github-actions bot

Loading

github-actions bot commented Feb 6, 2023

davydov-d commented Feb 6, 2023

octavia-approvington commented Feb 6, 2023

Source freshdesk: deduplicate table names #22164

Source freshdesk: deduplicate table names #22164

Conversation

davydov-d commented Jan 31, 2023

What

How

davydov-d commented Jan 31, 2023 • edited by github-actions bot Loading

davydov-d commented Jan 31, 2023 • edited by github-actions bot Loading

Build Failed

davydov-d commented Feb 1, 2023 • edited by github-actions bot Loading

Build Failed

davydov-d commented Feb 1, 2023 • edited by github-actions bot Loading

Build Passed

davydov-d commented Feb 6, 2023 • edited by github-actions bot Loading

github-actions bot commented Feb 6, 2023

Airbyte Code Coverage

davydov-d commented Feb 6, 2023

octavia-approvington commented Feb 6, 2023

davydov-d commented Jan 31, 2023 •

edited by github-actions bot

Loading

davydov-d commented Jan 31, 2023 •

edited by github-actions bot

Loading

davydov-d commented Feb 1, 2023 •

edited by github-actions bot

Loading

davydov-d commented Feb 1, 2023 •

edited by github-actions bot

Loading

davydov-d commented Feb 6, 2023 •

edited by github-actions bot

Loading