Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the default security groups for the EC2 runner #22347

Merged
merged 3 commits into from
Feb 3, 2023
Merged

Update the default security groups for the EC2 runner #22347

merged 3 commits into from
Feb 3, 2023

Conversation

perangel
Copy link
Contributor

@perangel perangel commented Feb 2, 2023

What

Historically, if a developer ever needs to SSH into a running EC2 runner to debug an issue, they would first need to update the security groups in the "start runner" action and then re-run the workflow.

This changes updates the default security groups for the EC2 runner so that SSH is allowed by default.
This should be safe, given that in order to SSH into a machine you would need to either have an SSH key whose public key is authorized on the instance, or access to the AWS console

How

Describe the solution

Recommended reading order

  1. x.java
  2. y.python

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the connector is published, connector added to connector index as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here
Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub and connector version bumped by running the /publish command described here
Connector Generator
  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed

@perangel perangel requested a review from a team February 2, 2023 21:05
perangel
perangel commented Feb 2, 2023
View reviewed changes
.github/actions/start-aws-runner/action.yml
@@ -18,7 +18,7 @@ inputs:
default: "subnet-0469a9e68a379c1d3"
required: true
security-group-id:
default: "sg-0793f3c9413f21970"
default: "sg-0793f3c9413f21970,sg-023656a050e7d5634"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see: https://internal-docs.airbyte.io/How-Tos/ssh_onto_ci_runner

@perangel perangel temporarily deployed to more-secrets February 2, 2023 21:07 — with GitHub Actions Inactive
@perangel perangel temporarily deployed to more-secrets February 2, 2023 21:07 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Feb 2, 2023

Airbyte Code Coverage

There is no coverage information present for the Files changed

Total Project Coverage 24.52% ❌

@perangel perangel temporarily deployed to more-secrets February 2, 2023 21:24 — with GitHub Actions Inactive
@perangel perangel temporarily deployed to more-secrets February 2, 2023 21:24 — with GitHub Actions Inactive
@perangel perangel enabled auto-merge (squash) February 2, 2023 21:46
@perangel perangel temporarily deployed to more-secrets February 3, 2023 14:48 — with GitHub Actions Inactive
@perangel perangel temporarily deployed to more-secrets February 3, 2023 14:48 — with GitHub Actions Inactive
@perangel
Copy link
Contributor Author

perangel commented Feb 3, 2023

/approve-and-merge reason="QoL improvement for CI workflow debugging on EC2 runners"

@octavia-approvington
Copy link
Contributor

A crack team of mammals has made a decision.
imagine a seal of approval

@octavia-approvington octavia-approvington merged commit 8939f69 into master Feb 3, 2023
@octavia-approvington octavia-approvington deleted the perangel/ci/update-default-ci-runner-security-groups branch February 3, 2023 15:07
robbinhan pushed a commit to robbinhan/airbyte that referenced this pull request Feb 6, 2023
@perangel @robbinhan
Update the default security groups for the EC2 runner (airbytehq#22347)
77e7bc4
letiescanciano added a commit that referenced this pull request Feb 6, 2023
@letiescanciano
Merge branch 'master' into leti/add-request-schemas-erds-in-source-docs
4eeeed0 
* master: (86 commits)
  Discover worker starts to use API to write schema result (#21875)
  🪟 🎉  Connector Builder Landing Page (#22122)
  Fix pnpm cache path (#22418)
  Add additional shorter setup guides (#22318)
  Source Amazon Ads: fix reports stream records primary keys (#21677)
  Connector acceptance test: Fix discovered catalog caching for different configs (#22301)
  🪟🐛 Make modal scrollable (#21973)
  only compute diff if the schema discovery actually succeeded (#22377)
  Source Klaviyo: fix schema (#22071)
  🪟 🔧 Switch to `pnpm` for package managing (#22053)
  Source Sentry: turn on default availability strategy (#22303)
  Source freshdesk: deduplicate table names (#22164)
  Update connector-acceptance-tests-reference.md (#22370)
  Update the default security groups for the EC2 runner (#22347)
  Trace refresh schema operations (#22326)
  Remove manual docker upgrades from workflows (#22344)
  Update CODEOWNERS for connector acceptance tests to connector ops (#22341)
  🐛 source: airtable - handle singleSelect types (#22311)
  Source tiktok: chunk advertiser IDs (#22309)
  🪟 🧪 E2E Tests for auto-detect schema changes (#20682)
  ...
letiescanciano added a commit that referenced this pull request Feb 6, 2023
@letiescanciano
Merge branch 'master' into leeti/add-clear-cta-to-trial-expired-message
fc9d567 
* master: (24 commits)
  Discover worker starts to use API to write schema result (#21875)
  🪟 🎉  Connector Builder Landing Page (#22122)
  Fix pnpm cache path (#22418)
  Add additional shorter setup guides (#22318)
  Source Amazon Ads: fix reports stream records primary keys (#21677)
  Connector acceptance test: Fix discovered catalog caching for different configs (#22301)
  🪟🐛 Make modal scrollable (#21973)
  only compute diff if the schema discovery actually succeeded (#22377)
  Source Klaviyo: fix schema (#22071)
  🪟 🔧 Switch to `pnpm` for package managing (#22053)
  Source Sentry: turn on default availability strategy (#22303)
  Source freshdesk: deduplicate table names (#22164)
  Update connector-acceptance-tests-reference.md (#22370)
  Update the default security groups for the EC2 runner (#22347)
  Trace refresh schema operations (#22326)
  Remove manual docker upgrades from workflows (#22344)
  Update CODEOWNERS for connector acceptance tests to connector ops (#22341)
  🐛 source: airtable - handle singleSelect types (#22311)
  Source tiktok: chunk advertiser IDs (#22309)
  🪟 🧪 E2E Tests for auto-detect schema changes (#20682)
  ...
@github-actions github-actions bot mentioned this pull request Feb 7, 2023
Closed
This was referenced Feb 8, 2023
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@git-phu git-phu git-phu approved these changes

@octavia-approvington octavia-approvington octavia-approvington approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@perangel @octavia-approvington @git-phu