Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Add normalization strict incremental feature flag" #22612

Conversation

benmoriceau
Copy link
Contributor

Reverts #22514

Revert in order to unlock OSS deployment. Aim to restore soon

@benmoriceau benmoriceau requested a review from a team as a code owner February 8, 2023 23:16
@octavia-squidington-iii octavia-squidington-iii added area/platform issues related to the platform area/worker Related to worker kubernetes labels Feb 8, 2023
@benmoriceau benmoriceau temporarily deployed to more-secrets February 8, 2023 23:18 — with GitHub Actions Inactive
@benmoriceau benmoriceau temporarily deployed to more-secrets February 8, 2023 23:18 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Feb 8, 2023

Airbyte Code Coverage

File Coverage [42.49%]
AirbyteIntegrationLauncher.java 100% 🍏
FeatureFlagHelper.java 94.92% 🍏
Configs.java 64.52% 🍏
EnvConfigs.java 44.94%
NormalizationActivityImpl.java 9.59%
EnvVariableFeatureFlags.java 0%
OrchestratorConstants.java 0%
ContainerOrchestratorConfigBeanFactory.java 0%
Total Project Coverage 24.66%

Copy link
Contributor

@gosusnp gosusnp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did we confirm the issue or is it a precaution?

@mfsiega-airbyte
Copy link
Contributor

Becoming less convinced that this is related, and more convinced that it is an infra thing.

@benmoriceau benmoriceau enabled auto-merge (squash) February 8, 2023 23:59
@benmoriceau benmoriceau merged commit 8702cdf into master Feb 9, 2023
@benmoriceau benmoriceau deleted the revert-22514-gosusnp/normalization-strict-incremental-feature-flag branch February 9, 2023 00:01
@benmoriceau benmoriceau restored the revert-22514-gosusnp/normalization-strict-incremental-feature-flag branch February 9, 2023 00:02
benmoriceau added a commit that referenced this pull request Feb 9, 2023
benmoriceau added a commit that referenced this pull request Feb 9, 2023
danidelvalle pushed a commit to danidelvalle/airbyte that referenced this pull request Feb 9, 2023
danidelvalle pushed a commit to danidelvalle/airbyte that referenced this pull request Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/platform issues related to the platform area/worker Related to worker kubernetes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants