Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Revert "Add normalization strict incremental feature flag"" #22619

Merged
merged 1 commit into from
Feb 9, 2023
Merged

Revert "Revert "Add normalization strict incremental feature flag"" #22619

merged 1 commit into from
Feb 9, 2023

Conversation

benmoriceau
Copy link
Contributor

Reverts #22612

Right after the revert got merge, we figured out that this was not the root cause. So I'm restoring it.

@benmoriceau benmoriceau requested a review from a team as a code owner February 9, 2023 00:04
@benmoriceau benmoriceau enabled auto-merge (squash) February 9, 2023 00:04
@octavia-squidington-iii octavia-squidington-iii added area/platform issues related to the platform area/worker Related to worker kubernetes labels Feb 9, 2023
@benmoriceau benmoriceau temporarily deployed to more-secrets February 9, 2023 00:05 — with GitHub Actions Inactive
@benmoriceau benmoriceau temporarily deployed to more-secrets February 9, 2023 00:05 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Feb 9, 2023

Airbyte Code Coverage

File Coverage [41.7%] ❌
AirbyteIntegrationLauncher.java 100% 🍏
FeatureFlagHelper.java 72.5% 🍏
Configs.java 64.52% 🍏
EnvConfigs.java 44.62% ❌
NormalizationActivityImpl.java 14.55% ❌
EnvVariableFeatureFlags.java 0% ❌
OrchestratorConstants.java 0% ❌
ContainerOrchestratorConfigBeanFactory.java 0% ❌
Total Project Coverage 24.66% ❌

@benmoriceau benmoriceau merged commit b9609ab into master Feb 9, 2023
@benmoriceau benmoriceau deleted the revert-22612-revert-22514-gosusnp/normalization-strict-incremental-feature-flag branch February 9, 2023 00:43
@github-actions github-actions bot mentioned this pull request Feb 9, 2023
Closed
danidelvalle pushed a commit to danidelvalle/airbyte that referenced this pull request Feb 9, 2023
@benmoriceau @danidelvalle-frontiers
Revert "Revert "Add normalization strict incremental feature flag (ai…
042ecb5 
…rbytehq#22514)" (airbytehq#22612)" (airbytehq#22619)

This reverts commit 8702cdf.
This was referenced Feb 10, 2023
Closed
Closed
@sh4sh
Copy link
Contributor

sh4sh commented Feb 17, 2023

Sharing here for visibility, issue #22687 has been reported where the airbyte-worker helm chart appears to be impacted from this change.

A pull request has been submitted to resolve this: #22697

To summarize, on the latest v0.44.41 charts airbyte-worker pod doesn't start and throws this error:

Events:
  Type     Reason     Age                    From               Message
  ----     ------     ----                   ----               -------
  Normal   Scheduled  5m17s                  default-scheduler  Successfully assigned default/airbyte-worker-767db5b6c7-xslxz to docker-desktop
  Warning  Failed     3m4s (x12 over 5m16s)  kubelet            Error: couldn't find key STRICT_COMPARISON_NORMALIZATION_TAG in ConfigMap default/airbyte-airbyte-env

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gosusnp gosusnp gosusnp approved these changes

@mfsiega-airbyte mfsiega-airbyte mfsiega-airbyte approved these changes

@malikdiarra malikdiarra Awaiting requested review from malikdiarra

Assignees
No one assigned
Labels
area/platform issues related to the platform area/worker Related to worker kubernetes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@benmoriceau @sh4sh @gosusnp @mfsiega-airbyte @octavia-squidington-iii