Disable flaky testDowntimeDuringSync test #22621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gosusnp
requested review from
colesnodgrass,
jdpgrailsdev,
benmoriceau,
cgardens and
alovew
benmoriceau
reviewed
Feb 9, 2023
| @@ -104,6 +105,7 @@ void setup() throws URISyntaxException, IOException, SQLException { | |||
| // This test is flaky. Warnings are suppressed until that condition us understood | |||
| // See: https://github.com/airbytehq/airbyte/issues/19948 | |||
| @Test | |||
| @Disabled("Flaky test, to be investigated before re-enabling") | |||
There was a problem hiding this comment.
Do we have an issue to track that?
There was a problem hiding this comment.
The comment above the test reference https://github.com/airbytehq/airbyte/issues/19948
benmoriceau
approved these changes
Feb 9, 2023
Airbyte Code Coverage
|
danidelvalle
pushed a commit
to danidelvalle/airbyte
that referenced
this pull request
Feb 9, 2023
This was referenced Feb 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Disable flaky testDowntimeDuringSync test
How
Disable flaky testDowntimeDuringSync test