Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable flaky testDowntimeDuringSync test #22621

Merged
merged 1 commit into from
Feb 9, 2023
Merged

Disable flaky testDowntimeDuringSync test #22621

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ...acceptanceTests/java/io/airbyte/test/acceptance/ContainerOrchestratorAcceptanceTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@
import org.junit.jupiter.api.AfterEach;
import org.junit.jupiter.api.BeforeAll;
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Disabled;
import org.junit.jupiter.api.Test;
import org.junit.jupiter.api.condition.EnabledIfEnvironmentVariable;
import org.slf4j.Logger;
Expand Down Expand Up @@ -104,6 +105,7 @@ void setup() throws URISyntaxException, IOException, SQLException {
// This test is flaky. Warnings are suppressed until that condition us understood
// See: https://github.com/airbytehq/airbyte/issues/19948
@Test
@Disabled("Flaky test, to be investigated before re-enabling")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have an issue to track that?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment above the test reference https://github.com/airbytehq/airbyte/issues/19948

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh I missed that

@SuppressWarnings("PMD.JUnitTestsShouldIncludeAssert")
void testDowntimeDuringSync() throws Exception {
// NOTE: PMD assert warning suppressed because the assertion was flaky. The test will throw if the
Expand Down