Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Source Stripe: Add missing field (cancel_at) to the Subscriptions stream #22898

Conversation

mrhallak
Copy link
Contributor

@mrhallak mrhallak commented Feb 13, 2023

What

The change solves this issue where the cancel_at field is not showing on the UI nor the final table.

How

I added the field to the configured catalog and schema.

Recommended reading order

  1. Schemas
  2. Configured catalog
  3. Docs

🚨 User Impact 🚨

No breaking changes

Pre-merge Checklist

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation bounty community connectors/source/stripe labels Feb 13, 2023
@mrhallak mrhallak changed the title Add missing field to the stream Source Stripe: Add missing field (cancel_at) to the Subscriptions stream Feb 13, 2023
@mrhallak mrhallak changed the title Source Stripe: Add missing field (cancel_at) to the Subscriptions stream 🐛 Source Stripe: Add missing field (cancel_at) to the Subscriptions stream Feb 13, 2023
@natalyjazzviolin
Copy link
Contributor

natalyjazzviolin commented Feb 24, 2023

/test connector=connectors/source-stripe

🕑 connectors/source-stripe https://github.com/airbytehq/airbyte/actions/runs/4266031507
✅ connectors/source-stripe https://github.com/airbytehq/airbyte/actions/runs/4266031507
Python tests coverage:

Name                                     Stmts   Miss  Cover
------------------------------------------------------------
source_stripe/source.py                     22      0   100%
source_stripe/__init__.py                    2      0   100%
source_stripe/streams.py                   311     27    91%
source_stripe/availability_strategy.py      19      2    89%
------------------------------------------------------------
TOTAL                                      354     29    92%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:98: The previous and actual specifications are identical.
============ 55 passed, 1 skipped, 37 warnings in 312.42s (0:05:12) ============

Copy link
Contributor

@natalyjazzviolin natalyjazzviolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good - just remove the version bumps on those two files!

@natalyjazzviolin
Copy link
Contributor

Running the build on a non-forked branch here: #23452

@natalyjazzviolin
Copy link
Contributor

Closing this in favor of the non-forked PR to make sure we see that the build is passing. Waiting on a review from @airbytehq/connector-operations:
#23452

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation bounty community connectors/source/stripe
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants