Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[non-forked] 🐛 Source Stripe: Add missing field (cancel_at) to the Subscriptions stream #23452

Merged
merged 15 commits into from
Mar 13, 2023

Conversation

natalyjazzviolin
Copy link
Contributor

@natalyjazzviolin natalyjazzviolin commented Feb 24, 2023

What

This PR is a non-forked version of #22898 to run the build.

Closes #22897 where the cancel_at field is not showing on the UI nor the final table.

How

Field added to the configured catalog and schema.

Recommended reading order

  1. Schemas
  2. Configured catalog
  3. Docs

🚨 User Impact 🚨

No breaking changes

Pre-merge Checklist

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

@natalyjazzviolin natalyjazzviolin changed the title DO NOT MERGE non-forked PR #22898 [non-forked] 🐛 Source Stripe: Add missing field (cancel_at) to the Subscriptions stream Feb 28, 2023
@natalyjazzviolin natalyjazzviolin requested a review from a team February 28, 2023 18:49
@natalyjazzviolin
Copy link
Contributor Author

natalyjazzviolin commented Feb 28, 2023

/test connector=connectors/source-stripe

🕑 connectors/source-stripe https://github.com/airbytehq/airbyte/actions/runs/4296392395
❌ connectors/source-stripe https://github.com/airbytehq/airbyte/actions/runs/4296392395
🐛 https://gradle.com/s/tqujeodcujpvm

Build Failed

Test summary info:

=========================== short test summary info ============================
ERROR test_core.py::TestBasicRead::test_read[inputs0] - Failed: A bypass_reas...
ERROR test_core.py::TestBasicRead::test_read[inputs1] - Failed: A bypass_reas...
ERROR test_core.py::TestBasicRead::test_read[inputs2] - Failed: High strictne...
ERROR test_full_refresh.py::TestFullRefresh::test_sequential_reads[inputs2]
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical.
======= 51 passed, 1 skipped, 37 warnings, 4 errors in 268.66s (0:04:28) =======

> Task :airbyte-integrations:connectors:source-stripe:connectorAcceptanceTest FAILED

Deprecated Gradle features were used in this build, making it incompatible with Gradle 8.0.

You can use '--warning-mode all' to show the individual deprecation warnings and determine if they come from your own scripts or plugins.

See https://docs.gradle.org/7.6/userguide/command_line_interface.html#sec:command_line_warnings
27 actionable tasks: 9 executed, 18 up-to-date

Publishing build scan...
https://gradle.com/s/tqujeodcujpvm

S3 cache writes: 1, elapsed: 643ms, sent to cache: 446 B

@evantahler
Copy link
Contributor

@natalyjazzviolin - I merged in the latest master branch which contained #21419. Re-running your tests now

@evantahler
Copy link
Contributor

evantahler commented Mar 1, 2023

/test connector=connectors/source-stripe

🕑 connectors/source-stripe https://github.com/airbytehq/airbyte/actions/runs/4298615159
✅ connectors/source-stripe https://github.com/airbytehq/airbyte/actions/runs/4298615159
Python tests coverage:

Name                                     Stmts   Miss  Cover
------------------------------------------------------------
source_stripe/source.py                     22      0   100%
source_stripe/__init__.py                    2      0   100%
source_stripe/streams.py                   311     27    91%
source_stripe/availability_strategy.py      19      2    89%
------------------------------------------------------------
TOTAL                                      354     29    92%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical.
================== 36 passed, 1 skipped in 237.55s (0:03:57) ===================

Copy link
Contributor

@evantahler evantahler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 assuming the latest /test passes!

LABEL io.airbyte.version=3.0.0
LABEL io.airbyte.version=3.0.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 patch version for an backwards-compatible change.

@evantahler
Copy link
Contributor

evantahler commented Mar 13, 2023

/publish connector=connectors/source-stripe

🕑 Publishing the following connectors:
connectors/source-stripe
https://github.com/airbytehq/airbyte/actions/runs/4408176515


Connector Did it publish? Were definitions generated?
connectors/source-stripe

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@evantahler evantahler enabled auto-merge (squash) March 13, 2023 18:28
@evantahler evantahler merged commit 96f6f76 into master Mar 13, 2023
@evantahler evantahler deleted the nataly/non-forked-pr-22898 branch March 13, 2023 18:48
adriennevermorel pushed a commit to adriennevermorel/airbyte that referenced this pull request Mar 17, 2023
…bscriptions stream (airbytehq#23452)

* Add missing field to the stream

* Update stripe.md

* Update connectors.md

* Update stripe.md

* Revert version bump.

* Enables high test strictness level.

* Automated Change

* auto-bump connector version

---------

Co-authored-by: Mohamad Hallak <[email protected]>
Co-authored-by: Sergio Ropero <[email protected]>
Co-authored-by: natalyjazzviolin <[email protected]>
Co-authored-by: Evan Tahler <[email protected]>
Co-authored-by: Octavia Squidington III <[email protected]>
erohmensing pushed a commit that referenced this pull request Mar 22, 2023
…bscriptions stream (#23452)

* Add missing field to the stream

* Update stripe.md

* Update connectors.md

* Update stripe.md

* Revert version bump.

* Enables high test strictness level.

* Automated Change

* auto-bump connector version

---------

Co-authored-by: Mohamad Hallak <[email protected]>
Co-authored-by: Sergio Ropero <[email protected]>
Co-authored-by: natalyjazzviolin <[email protected]>
Co-authored-by: Evan Tahler <[email protected]>
Co-authored-by: Octavia Squidington III <[email protected]>
erohmensing pushed a commit that referenced this pull request Mar 22, 2023
…bscriptions stream (#23452)

* Add missing field to the stream

* Update stripe.md

* Update connectors.md

* Update stripe.md

* Revert version bump.

* Enables high test strictness level.

* Automated Change

* auto-bump connector version

---------

Co-authored-by: Mohamad Hallak <[email protected]>
Co-authored-by: Sergio Ropero <[email protected]>
Co-authored-by: natalyjazzviolin <[email protected]>
Co-authored-by: Evan Tahler <[email protected]>
Co-authored-by: Octavia Squidington III <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/stripe from/connector-ops
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Source Stripe: Missing field cancel_at in Stripe connector
5 participants