copy seed configurations from config/init to server #4417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgardens
changed the title
cgardens
force-pushed
the
cgardens/share_resources_across_subprojects
branch
from
fdca037
to
e297242
Compare
github-actions
bot
added
the
area/documentation
cgardens
force-pushed
the
cgardens/share_resources_across_subprojects
branch
2 times, most recently
from
9da0d52
to
18c39e1
Compare
cgardens
requested review from
subodh1810 and
davinchia
and removed request for
subodh1810
|
I pushed a commit to replace |
subodh1810
approved these changes
Jun 30, 2021
There was a problem hiding this comment.
The part 2 has a green build #4428 (review)
Once we merge it into this branch, this should also have a green build
davinchia
approved these changes
Jun 30, 2021
There was a problem hiding this comment.
Reviewed 21 of 88 files at r1, 2 of 47 files at r2.
Reviewable status: 23 of 133 files reviewed, all discussions resolved (waiting on @cgardens)
Co-authored-by: subodh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the boilerplate part of this issue: #4412. Separating it out so that the actual change for what we are doing can be in its own PR.
Basically it is reverting all of the seed configs back to living and being generated in
airbyte-config/init. It also updates any references to the paths of source_definitions and destination_definitions.This change is