-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(source-gcs): added oauth flow #45414
base: master
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
airbyte-integrations/connectors/source-gcs/source_gcs/config_migrations.py
Show resolved
Hide resolved
"order": 0, | ||
"type": "string" | ||
"discriminator": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I expect the discriminator fields to trip up the Terraform provider. Maybe we need a method similar to this one where we remove them from the schemas
airbyte/airbyte-cdk/python/airbyte_cdk/sources/file_based/config/abstract_file_based_spec.py
Lines 58 to 60 in fc12432
def remove_discriminator(schema: Dict[str, Any]) -> None: | |
"""pydantic adds "discriminator" to the schema for oneOfs, which is not treated right by the platform as we inline all references""" | |
dpath.delete(schema, "properties/**/discriminator") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed def remove_discriminator
from Config class, so both discriminators are being removed from spec
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR looks good! @darynaishchenko just to confirm - we need to update our app's scopes to be able to test the new flow, correct?
@girarda, We need:
Ask google support to test it for verification. Scopes have been already added to our app. cc: @DanyloGL |
What
Add supporting OAuth
Additionally:
resolves: https://github.com/airbytehq/airbyte-internal-issues/issues/9745 (remove discriminator fields)
How
Extended spec with advanced_auth, added credentials object with config migration that adds deprecated
service_account
field into credentials object.Added and updated unit tests.
PR for the platform: https://github.com/airbytehq/airbyte-platform-internal/pull/13923
Review guide
airbyte-integrations/connectors/source-gcs/source_gcs/config.py
airbyte-integrations/connectors/source-gcs/source_gcs/source.py
airbyte-integrations/connectors/source-gcs/source_gcs/stream_reader.py
User Impact
Can this PR be safely reverted and rolled back?