-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(source-gcs): added oauth flow #45414
Open
darynaishchenko
wants to merge
17
commits into
master
Choose a base branch
from
daryna/source-gcs/enable-oauth
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 5 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
3639a58
added oauth flow
darynaishchenko 07d9a70
added config migrations
darynaishchenko 4433613
added unit tests
darynaishchenko 9f49cd7
bump version
darynaishchenko 328aa7a
Merge branch 'master' into daryna/source-gcs/enable-oauth
darynaishchenko 9545597
Merge branch 'master' into daryna/source-gcs/enable-oauth
darynaishchenko e8ec691
fixed: changelog, discriminator
darynaishchenko 5cba3bb
Merge branch 'master' into daryna/source-gcs/enable-oauth
darynaishchenko d306b3c
format fix
darynaishchenko 6e206ad
fix config migrations
darynaishchenko df3340f
fix spec and legacy config transformations
darynaishchenko 473192d
fix unit tests
darynaishchenko 0598ffe
update uri and open_file
darynaishchenko 6fab547
Merge branch 'master' into daryna/source-gcs/enable-oauth
darynaishchenko bf51350
fix cat and unit tests
darynaishchenko 50a6bfd
fix unit tests
darynaishchenko 5c262e9
Merge branch 'master' into daryna/source-gcs/enable-oauth
darynaishchenko File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I expect the discriminator fields to trip up the Terraform provider. Maybe we need a method similar to this one where we remove them from the schemas
airbyte/airbyte-cdk/python/airbyte_cdk/sources/file_based/config/abstract_file_based_spec.py
Lines 58 to 60 in fc12432
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed
def remove_discriminator
from Config class, so both discriminators are being removed from spec