Destination Kafka: correct spec json and data types in config #6040

marcosmarxm · 2021-09-14T03:42:59Z

What

How

Default value in spec.json are not being sent to API request => change default to examples.
number type is converted to string and has conflict, convert to string in spec.json and convert in config parse function only.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
Credentials added to Github CI. Instructions.
/test connector=connectors/<name> command is passing.
New Connector version released on Dockerhub by running the /publish command described here

Updating a connector

Community member or Airbyter

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
Credentials added to Github CI. Instructions.
/test connector=connectors/<name> command is passing.
New Connector version released on Dockerhub by running the /publish command described here

Connector Generator

Issue acceptance criteria met
PR name follows PR naming conventions
If adding a new generator, add it to the list of scaffold modules being tested
The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
Documentation which references the generator is updated as needed.

marcosmarxm · 2021-09-14T03:47:56Z

After the change I was able to connect using the UI and create Kafka destination connector. The check function is not strong right now... need work.

sherifnada · 2021-09-14T03:56:33Z

airbyte-integrations/connectors/destination-kafka/src/main/resources/spec.json

      },
      "receive_buffer_bytes": {
        "title": "Receive buffer bytes",
        "description": "The size of the TCP receive buffer (SO_RCVBUF) to use when reading data. If the value is -1, the OS default will be used.",
        "type": "integer",
-        "default": 32768
+        "examples": [32768]


why not keep the default?

Right now Default value in spec.json is not being sent to API request => change the default to examples and force user to insert value.

I'll create another issue to investigate this in the front-end.

marcosmarxm · 2021-09-14T14:48:12Z

/test connector=connectors/destination-kafka

🕑 connectors/destination-kafka https://github.com/airbytehq/airbyte/actions/runs/1234111968
❌ connectors/destination-kafka https://github.com/airbytehq/airbyte/actions/runs/1234111968
🐛 https://gradle.com/s/u2kbuuipzjb6g

marcosmarxm · 2021-09-14T23:40:32Z

/test connector=connectors/destination-kafka

🕑 connectors/destination-kafka https://github.com/airbytehq/airbyte/actions/runs/1235630817
✅ connectors/destination-kafka https://github.com/airbytehq/airbyte/actions/runs/1235630817

marcosmarxm · 2021-09-15T02:34:52Z

/publish connector=connectors/destination-kafka

🕑 connectors/destination-kafka https://github.com/airbytehq/airbyte/actions/runs/1236019204
✅ connectors/destination-kafka https://github.com/airbytehq/airbyte/actions/runs/1236019204

* Update check connection method * #5796 silence printing full config when config validation fails (#5879) * - #5796 silence printing full config when config validation fails * fix unit tests after config validation check changes Co-authored-by: Marcos Eliziario Santos <[email protected]> * Format google-search-console schemas (#6047) * Update ads_insights.json (#5946) fix ads_insights schema according to [facebook docs](https://developers.facebook.com/docs/marketing-api/reference/adgroup/insights/) and my own data * Bump connectors version + update docs (#6060) * 🐛 Source Facebook Marketing: Convert values' types according to schema types (#4978) * Convert values' types according to schema types * Put streams back to `configured_catalog.json` Put back `ads_insights` and `ads_insights_age_and_gender` streams. * Pickup changes from #5946 * Implement change request + fix previous PR * Update schema * Remove items_type from convert_to_schema_types() * Bump connectors version * add oauth to connector_base dependencies (#6064) * use spec when persisting source configs (#6036) * switch most usages of writing sources to using specs * fix other usages * fix test * only wait on the server in the scheduler, not the worker * fix * rephrase sanity check and remove stdout * 🎉 Source Stripe: Add `PaymentIntents` stream (#6004) * Add `PaymentIntents` stream * Update docs * Implement change request + few updates Split `source.py` file into `source.py` and `streams.py` files. Update `payment_intents.json` file. * Bump connectors version + update docs * Add skeleton for databricks destination (#5629) Co-authored-by: Liren Tu <[email protected]> Co-authored-by: LiRen Tu <[email protected]> * Revert "Add skeleton for databricks destination (#5629)" (#6066) This reverts commit 79256c4. * 🎉 New Destination: Databricks (#5998) Implement new destination connector for databricks delta lake. Resolves #2075. Co-authored-by: George Claireaux <[email protected]> Co-authored-by: Sherif A. Nada <[email protected]> * Source PostHog: add support for self-hosted instances (#6058) * publish #6058 (#6059) * Destination Kafka: correct spec json and data types in config (#6040) * correct spec json and data types in config * bump version * correct tests * correct config parser NPE * format files Co-authored-by: Marcos Marx <[email protected]> * Fix or delete broken links (#6069) * Fix more doc issues (#6072) * 🎉 Added optional platform flag for build image script (#6000) * Fix dependabot security alert. (#6073) * Pin set value to greater than 4.0.1 to fix security warning. * Format the rest of the connectors. * add coverage report (#6045) Co-authored-by: Dmytro Rezchykov <[email protected]> * Fix the format of the data returned by Google Ads oauth to match the config accepted by the connector (#6032) * update salesforce docs (#6081) * 🎉 Source Github: add caching for all streams (#5949) * Source Github: add checking for all streams * bump version, update changelogs * Disable automatic migration acceptance test (#5988) - The automatic migration acceptance test no longer works because of the new Flyway migration system. - The file-based migration system is being deprecated. * 🎉 CDK: Add requests native authenticator support (#5731) * Add requests native auth class * Update init file. Update type annotations. Bump version. * Update TokenAuthenticator implementation. Update Oauth2Authenticator implemetation. Add CHANGELOG.md record. * Update Oauth2Authenticator default value setting. Update CHANGELOG.md * Add requests native authenticator tests * Add CDK requests native __call__ method tests. Update CHANGELOG.md * Add outdated auth deprication messages * Update requests native auth __call__ method tests * Bump CDK version to 0.1.20 * Interface changes to support separating secrets from the config (#6065) * Interface changes to support separating secrets from the config * Cleanup from PR comments and whitespace * Update log message for empty env variable (#6115) Co-authored-by: Jared Rhizor <[email protected]> * Bump Airbyte version from 0.29.17-alpha to 0.29.18-alpha (#6125) Co-authored-by: davinchia <[email protected]> * return auth spec in the API when getting definition specification (#6121) * Ignore python test coverage files (#6144) * CDK: support nested refs resolving (#6044) Co-authored-by: Dmytro Rezchykov <[email protected]> * feat: path for nested fields (#6130) * feat: path for nested fields * fix: clipRule error * fix: remove field name * Fix request middleware for ConnectionService (#6148) * Jamakase/update onboarding flow (#5656) * Doc explains normalization full-refresh implications (#6097) * update docs * add info in quickstart connection page * update abhi comments Co-authored-by: Marcos Marx <[email protected]> * Fix migration validation issue (#6154) Resolves #6151. * Bump Airbyte version from 0.29.18-alpha to 0.29.19-alpha (#6156) Co-authored-by: tuliren <[email protected]> * Add information on which destinations support Incremental - Deduped History in their docs (#6031) Co-authored-by: Abhi Vaidyanatha <[email protected]> * Update Airbyte Spec acknowledgements. (#6155) Co-authored-by: Abhi Vaidyanatha <[email protected]> * Update new integration request * Add back the migration acceptance test (#6163) * 🎉 Create a Helm Chart For Airbyte (#5891) See number #1868. This creates an initial helm chart for installing Airbyte in Kubernetes to make it easier for users who are more familiar with helm. It also includes GitHub actions to help continually test that the chart works in the most basic case. All of the templates are based off of the kustomize folder, but minio and postgres have been removed in favor of adding the bitnami helm charts as dependencies since they have an active community and allow easily tweaking their install. * Fix OAuth Summary strings (#6143) Co-authored-by: Marcos Eliziario Santos <[email protected]> Co-authored-by: Marcos Eliziario Santos <[email protected]> Co-authored-by: oleh.zorenko <[email protected]> Co-authored-by: Mauro <[email protected]> Co-authored-by: Sherif A. Nada <[email protected]> Co-authored-by: Jared Rhizor <[email protected]> Co-authored-by: George Claireaux <[email protected]> Co-authored-by: Liren Tu <[email protected]> Co-authored-by: LiRen Tu <[email protected]> Co-authored-by: coeurdestenebres <[email protected]> Co-authored-by: Marcos Marx <[email protected]> Co-authored-by: Marcos Marx <[email protected]> Co-authored-by: Harsha Teja Kanna <[email protected]> Co-authored-by: Davin Chia <[email protected]> Co-authored-by: Dmytro <[email protected]> Co-authored-by: Dmytro Rezchykov <[email protected]> Co-authored-by: Yevhenii <[email protected]> Co-authored-by: Jenny Brown <[email protected]> Co-authored-by: davinchia <[email protected]> Co-authored-by: Iakov Salikov <[email protected]> Co-authored-by: Artem Astapenko <[email protected]> Co-authored-by: tuliren <[email protected]> Co-authored-by: Abhi Vaidyanatha <[email protected]> Co-authored-by: Abhi Vaidyanatha <[email protected]> Co-authored-by: Jonathan Stacks <[email protected]> Co-authored-by: Christophe Duong <[email protected]>

* Add GET_FBA_INVENTORY_AGED_DATA data * Add GET_MERCHANT_LISTINGS_ALL_DATA stream support * Update schemas * Update configured_catalog.json * Update connector to airbyte-cdk * Add amazon seller partner test creds * Update state sample files * Apply code format * Update acceptance-test-config.yml * Add dummy integration test * Refactor auth signature. Update streams.py * Remove print_function import from auth.py * Refactor source class. Add pydantic spec. PR fixes. * Add dummy integration test * Typing added. Add _create_prepared_request docstring. * Add extra streams and schemas * Update docs and spec * Post merge code fixes * Fix test setup * Fix test setup * Add sample_state.json * Update reports streams logics. Update test and config files. * Update tests config. Small code style fixes. * Add reports stream slices. Update check_connection method. * Post review fixes. * Streams update * Add reports document retrieval and decrypting. Update schemas and configs. * Add CVS parsing into result rows * Update ReportsAmazonSPStream class to be the child of Stream class. Update GET_FLAT_FILE_OPEN_LISTINGS_DATA and GET_MERCHANT_LISTINGS_ALL_DATA schemas. * Schema updates * Source check method updated * Update ReportsAmazonSPStream retry report logics * Update check_connection source method * Update reports read_records method. Update report schemas. * Update streams.py * Update acceptance tests config. Add small code fixes. * Update report read_records logics * Add reports streams rate limit handling logics. Add rate limit unit tests. * Source Amazon SP: Update reports streams logics. (#5311) * Update check connection method * #5796 silence printing full config when config validation fails (#5879) * - #5796 silence printing full config when config validation fails * fix unit tests after config validation check changes Co-authored-by: Marcos Eliziario Santos <[email protected]> * Format google-search-console schemas (#6047) * Update ads_insights.json (#5946) fix ads_insights schema according to [facebook docs](https://developers.facebook.com/docs/marketing-api/reference/adgroup/insights/) and my own data * Bump connectors version + update docs (#6060) * 🐛 Source Facebook Marketing: Convert values' types according to schema types (#4978) * Convert values' types according to schema types * Put streams back to `configured_catalog.json` Put back `ads_insights` and `ads_insights_age_and_gender` streams. * Pickup changes from #5946 * Implement change request + fix previous PR * Update schema * Remove items_type from convert_to_schema_types() * Bump connectors version * add oauth to connector_base dependencies (#6064) * use spec when persisting source configs (#6036) * switch most usages of writing sources to using specs * fix other usages * fix test * only wait on the server in the scheduler, not the worker * fix * rephrase sanity check and remove stdout * 🎉 Source Stripe: Add `PaymentIntents` stream (#6004) * Add `PaymentIntents` stream * Update docs * Implement change request + few updates Split `source.py` file into `source.py` and `streams.py` files. Update `payment_intents.json` file. * Bump connectors version + update docs * Add skeleton for databricks destination (#5629) Co-authored-by: Liren Tu <[email protected]> Co-authored-by: LiRen Tu <[email protected]> * Revert "Add skeleton for databricks destination (#5629)" (#6066) This reverts commit 79256c4. * 🎉 New Destination: Databricks (#5998) Implement new destination connector for databricks delta lake. Resolves #2075. Co-authored-by: George Claireaux <[email protected]> Co-authored-by: Sherif A. Nada <[email protected]> * Source PostHog: add support for self-hosted instances (#6058) * publish #6058 (#6059) * Destination Kafka: correct spec json and data types in config (#6040) * correct spec json and data types in config * bump version * correct tests * correct config parser NPE * format files Co-authored-by: Marcos Marx <[email protected]> * Fix or delete broken links (#6069) * Fix more doc issues (#6072) * 🎉 Added optional platform flag for build image script (#6000) * Fix dependabot security alert. (#6073) * Pin set value to greater than 4.0.1 to fix security warning. * Format the rest of the connectors. * add coverage report (#6045) Co-authored-by: Dmytro Rezchykov <[email protected]> * Fix the format of the data returned by Google Ads oauth to match the config accepted by the connector (#6032) * update salesforce docs (#6081) * 🎉 Source Github: add caching for all streams (#5949) * Source Github: add checking for all streams * bump version, update changelogs * Disable automatic migration acceptance test (#5988) - The automatic migration acceptance test no longer works because of the new Flyway migration system. - The file-based migration system is being deprecated. * 🎉 CDK: Add requests native authenticator support (#5731) * Add requests native auth class * Update init file. Update type annotations. Bump version. * Update TokenAuthenticator implementation. Update Oauth2Authenticator implemetation. Add CHANGELOG.md record. * Update Oauth2Authenticator default value setting. Update CHANGELOG.md * Add requests native authenticator tests * Add CDK requests native __call__ method tests. Update CHANGELOG.md * Add outdated auth deprication messages * Update requests native auth __call__ method tests * Bump CDK version to 0.1.20 * Interface changes to support separating secrets from the config (#6065) * Interface changes to support separating secrets from the config * Cleanup from PR comments and whitespace * Update log message for empty env variable (#6115) Co-authored-by: Jared Rhizor <[email protected]> * Bump Airbyte version from 0.29.17-alpha to 0.29.18-alpha (#6125) Co-authored-by: davinchia <[email protected]> * return auth spec in the API when getting definition specification (#6121) * Ignore python test coverage files (#6144) * CDK: support nested refs resolving (#6044) Co-authored-by: Dmytro Rezchykov <[email protected]> * feat: path for nested fields (#6130) * feat: path for nested fields * fix: clipRule error * fix: remove field name * Fix request middleware for ConnectionService (#6148) * Jamakase/update onboarding flow (#5656) * Doc explains normalization full-refresh implications (#6097) * update docs * add info in quickstart connection page * update abhi comments Co-authored-by: Marcos Marx <[email protected]> * Fix migration validation issue (#6154) Resolves #6151. * Bump Airbyte version from 0.29.18-alpha to 0.29.19-alpha (#6156) Co-authored-by: tuliren <[email protected]> * Add information on which destinations support Incremental - Deduped History in their docs (#6031) Co-authored-by: Abhi Vaidyanatha <[email protected]> * Update Airbyte Spec acknowledgements. (#6155) Co-authored-by: Abhi Vaidyanatha <[email protected]> * Update new integration request * Add back the migration acceptance test (#6163) * 🎉 Create a Helm Chart For Airbyte (#5891) See number #1868. This creates an initial helm chart for installing Airbyte in Kubernetes to make it easier for users who are more familiar with helm. It also includes GitHub actions to help continually test that the chart works in the most basic case. All of the templates are based off of the kustomize folder, but minio and postgres have been removed in favor of adding the bitnami helm charts as dependencies since they have an active community and allow easily tweaking their install. * Fix OAuth Summary strings (#6143) Co-authored-by: Marcos Eliziario Santos <[email protected]> Co-authored-by: Marcos Eliziario Santos <[email protected]> Co-authored-by: oleh.zorenko <[email protected]> Co-authored-by: Mauro <[email protected]> Co-authored-by: Sherif A. Nada <[email protected]> Co-authored-by: Jared Rhizor <[email protected]> Co-authored-by: George Claireaux <[email protected]> Co-authored-by: Liren Tu <[email protected]> Co-authored-by: LiRen Tu <[email protected]> Co-authored-by: coeurdestenebres <[email protected]> Co-authored-by: Marcos Marx <[email protected]> Co-authored-by: Marcos Marx <[email protected]> Co-authored-by: Harsha Teja Kanna <[email protected]> Co-authored-by: Davin Chia <[email protected]> Co-authored-by: Dmytro <[email protected]> Co-authored-by: Dmytro Rezchykov <[email protected]> Co-authored-by: Yevhenii <[email protected]> Co-authored-by: Jenny Brown <[email protected]> Co-authored-by: davinchia <[email protected]> Co-authored-by: Iakov Salikov <[email protected]> Co-authored-by: Artem Astapenko <[email protected]> Co-authored-by: tuliren <[email protected]> Co-authored-by: Abhi Vaidyanatha <[email protected]> Co-authored-by: Abhi Vaidyanatha <[email protected]> Co-authored-by: Jonathan Stacks <[email protected]> Co-authored-by: Christophe Duong <[email protected]> * Bump source version. Update source docs. * Mock time.sleep in test_reports_stream_send_request_backoff_exception test * Acceptance test basic_read test disabled Co-authored-by: Marcos Eliziario Santos <[email protected]> Co-authored-by: Marcos Eliziario Santos <[email protected]> Co-authored-by: oleh.zorenko <[email protected]> Co-authored-by: Mauro <[email protected]> Co-authored-by: Sherif A. Nada <[email protected]> Co-authored-by: Jared Rhizor <[email protected]> Co-authored-by: George Claireaux <[email protected]> Co-authored-by: Liren Tu <[email protected]> Co-authored-by: LiRen Tu <[email protected]> Co-authored-by: coeurdestenebres <[email protected]> Co-authored-by: Marcos Marx <[email protected]> Co-authored-by: Marcos Marx <[email protected]> Co-authored-by: Harsha Teja Kanna <[email protected]> Co-authored-by: Davin Chia <[email protected]> Co-authored-by: Dmytro <[email protected]> Co-authored-by: Dmytro Rezchykov <[email protected]> Co-authored-by: Yevhenii <[email protected]> Co-authored-by: Jenny Brown <[email protected]> Co-authored-by: davinchia <[email protected]> Co-authored-by: Iakov Salikov <[email protected]> Co-authored-by: Artem Astapenko <[email protected]> Co-authored-by: tuliren <[email protected]> Co-authored-by: Abhi Vaidyanatha <[email protected]> Co-authored-by: Abhi Vaidyanatha <[email protected]> Co-authored-by: Jonathan Stacks <[email protected]> Co-authored-by: Christophe Duong <[email protected]>

correct spec json and data types in config

0395b73

github-actions bot added the area/connectors Connector related issues label Sep 14, 2021

marcosmarxm requested review from sherifnada and davinchia September 14, 2021 03:44

sherifnada approved these changes Sep 14, 2021

View reviewed changes

sherifnada linked an issue Sep 14, 2021 that may be closed by this pull request

Kafka Destination connector Issue in UI #5789

Closed

bump version

d7c5aca

github-actions bot added the area/documentation Improvements or additions to documentation label Sep 14, 2021

jrhizor temporarily deployed to more-secrets September 14, 2021 14:50 Inactive

Marcos Marx added 2 commits September 14, 2021 20:39

correct tests

691f99c

Merge branch 'master' into marcos/dest-kafka-spec

c215338

jrhizor temporarily deployed to more-secrets September 14, 2021 23:43 Inactive

Marcos Marx added 3 commits September 14, 2021 21:18

correct config parser NPE

9747424

format files

3da7c87

merge master

76180ed

jrhizor temporarily deployed to more-secrets September 15, 2021 02:37 Inactive

marcosmarxm merged commit 9dafec6 into master Sep 15, 2021

marcosmarxm deleted the marcos/dest-kafka-spec branch September 15, 2021 03:22

jrhizor mentioned this pull request Sep 16, 2021

Bump Airbyte version from 0.29.17-alpha to 0.29.18-alpha #6125

Merged

sherifnada mentioned this pull request Sep 24, 2021

Error while creating Kafka Destination #5333

Closed

karinakuz added connectors/destinations-streaming connectors/destination/kafka labels Jan 14, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Destination Kafka: correct spec json and data types in config #6040

Destination Kafka: correct spec json and data types in config #6040

marcosmarxm commented Sep 14, 2021 •

edited

Loading

marcosmarxm commented Sep 14, 2021

sherifnada Sep 14, 2021

marcosmarxm Sep 14, 2021

marcosmarxm Sep 14, 2021

marcosmarxm commented Sep 14, 2021 •

edited by github-actions bot

Loading

marcosmarxm commented Sep 14, 2021 •

edited by github-actions bot

Loading

marcosmarxm commented Sep 15, 2021 •

edited by github-actions bot

Loading

Destination Kafka: correct spec json and data types in config #6040

Destination Kafka: correct spec json and data types in config #6040

Conversation

marcosmarxm commented Sep 14, 2021 • edited Loading

What

How

Recommended reading order

Pre-merge Checklist

Community member or Airbyter

Airbyter

Community member or Airbyter

Airbyter

marcosmarxm commented Sep 14, 2021

sherifnada Sep 14, 2021

Choose a reason for hiding this comment

marcosmarxm Sep 14, 2021

Choose a reason for hiding this comment

marcosmarxm Sep 14, 2021

Choose a reason for hiding this comment

marcosmarxm commented Sep 14, 2021 • edited by github-actions bot Loading

marcosmarxm commented Sep 14, 2021 • edited by github-actions bot Loading

marcosmarxm commented Sep 15, 2021 • edited by github-actions bot Loading

marcosmarxm commented Sep 14, 2021 •

edited

Loading

marcosmarxm commented Sep 14, 2021 •

edited by github-actions bot

Loading

marcosmarxm commented Sep 14, 2021 •

edited by github-actions bot

Loading

marcosmarxm commented Sep 15, 2021 •

edited by github-actions bot

Loading