-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add coverage report #6045
Add coverage report #6045
Conversation
75d9145
to
65bd698
Compare
/test connector=connectors/source-braintree
|
65bd698
to
bee52bd
Compare
/test connector=connectors/source-braintree
|
5d1c0ee
to
565b93f
Compare
4c8b9fc
to
38e30ee
Compare
38e30ee
to
7d08911
Compare
dfd142d
to
1526474
Compare
1526474
to
969f9c3
Compare
6edd443
to
dbcf0e2
Compare
/test connector=connectors/source-braintree
|
dbcf0e2
to
241b4b3
Compare
/test connector=connectors/source-braintree
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great! Well done @avida
How does this handle multiple pytest runs? For example in a single /test
command there can be unit tests, custom integration tests, and acceptance tests. Ideally we output coverage from unit tests and custom integration tests (integration_tests
directory) combined but I understand it might be difficult.
If that's not possible/easy to do, maybe let's add a header to the coverage report printed to make it clear that the coverage comes from unit tests?
Also we should be prepared that a connector was not written in python and will not have a coverage output
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feel free to merge once you've addressed the above comment
/test connector=source-mysql
|
/test connector=connectors/source-mysql
|
7d18988
to
1c793c5
Compare
/test connector=source-mysql
|
1c793c5
to
2f6015e
Compare
/test connector=source-braintree
|
/test connector=source-mysql
|
2f6015e
to
821a962
Compare
It only captures output for python unittest. What do you mean by integration/acceptance test coverge? If it code under "airbyte-integrations/bases/source-acceptance-test/source_acceptance_test/tests" directory it would be not so difficult.
Done
Updated, in case that would be no python unittest output it update comment with "No python unittest run" line. |
/test connector=source-braintree
|
/test connector=source-mysql
|
821a962
to
531aa93
Compare
531aa93
to
a7ddb7c
Compare
/test connector=source-braintree
|
* Update check connection method * #5796 silence printing full config when config validation fails (#5879) * - #5796 silence printing full config when config validation fails * fix unit tests after config validation check changes Co-authored-by: Marcos Eliziario Santos <[email protected]> * Format google-search-console schemas (#6047) * Update ads_insights.json (#5946) fix ads_insights schema according to [facebook docs](https://developers.facebook.com/docs/marketing-api/reference/adgroup/insights/) and my own data * Bump connectors version + update docs (#6060) * 🐛 Source Facebook Marketing: Convert values' types according to schema types (#4978) * Convert values' types according to schema types * Put streams back to `configured_catalog.json` Put back `ads_insights` and `ads_insights_age_and_gender` streams. * Pickup changes from #5946 * Implement change request + fix previous PR * Update schema * Remove items_type from convert_to_schema_types() * Bump connectors version * add oauth to connector_base dependencies (#6064) * use spec when persisting source configs (#6036) * switch most usages of writing sources to using specs * fix other usages * fix test * only wait on the server in the scheduler, not the worker * fix * rephrase sanity check and remove stdout * 🎉 Source Stripe: Add `PaymentIntents` stream (#6004) * Add `PaymentIntents` stream * Update docs * Implement change request + few updates Split `source.py` file into `source.py` and `streams.py` files. Update `payment_intents.json` file. * Bump connectors version + update docs * Add skeleton for databricks destination (#5629) Co-authored-by: Liren Tu <[email protected]> Co-authored-by: LiRen Tu <[email protected]> * Revert "Add skeleton for databricks destination (#5629)" (#6066) This reverts commit 79256c4. * 🎉 New Destination: Databricks (#5998) Implement new destination connector for databricks delta lake. Resolves #2075. Co-authored-by: George Claireaux <[email protected]> Co-authored-by: Sherif A. Nada <[email protected]> * Source PostHog: add support for self-hosted instances (#6058) * publish #6058 (#6059) * Destination Kafka: correct spec json and data types in config (#6040) * correct spec json and data types in config * bump version * correct tests * correct config parser NPE * format files Co-authored-by: Marcos Marx <[email protected]> * Fix or delete broken links (#6069) * Fix more doc issues (#6072) * 🎉 Added optional platform flag for build image script (#6000) * Fix dependabot security alert. (#6073) * Pin set value to greater than 4.0.1 to fix security warning. * Format the rest of the connectors. * add coverage report (#6045) Co-authored-by: Dmytro Rezchykov <[email protected]> * Fix the format of the data returned by Google Ads oauth to match the config accepted by the connector (#6032) * update salesforce docs (#6081) * 🎉 Source Github: add caching for all streams (#5949) * Source Github: add checking for all streams * bump version, update changelogs * Disable automatic migration acceptance test (#5988) - The automatic migration acceptance test no longer works because of the new Flyway migration system. - The file-based migration system is being deprecated. * 🎉 CDK: Add requests native authenticator support (#5731) * Add requests native auth class * Update init file. Update type annotations. Bump version. * Update TokenAuthenticator implementation. Update Oauth2Authenticator implemetation. Add CHANGELOG.md record. * Update Oauth2Authenticator default value setting. Update CHANGELOG.md * Add requests native authenticator tests * Add CDK requests native __call__ method tests. Update CHANGELOG.md * Add outdated auth deprication messages * Update requests native auth __call__ method tests * Bump CDK version to 0.1.20 * Interface changes to support separating secrets from the config (#6065) * Interface changes to support separating secrets from the config * Cleanup from PR comments and whitespace * Update log message for empty env variable (#6115) Co-authored-by: Jared Rhizor <[email protected]> * Bump Airbyte version from 0.29.17-alpha to 0.29.18-alpha (#6125) Co-authored-by: davinchia <[email protected]> * return auth spec in the API when getting definition specification (#6121) * Ignore python test coverage files (#6144) * CDK: support nested refs resolving (#6044) Co-authored-by: Dmytro Rezchykov <[email protected]> * feat: path for nested fields (#6130) * feat: path for nested fields * fix: clipRule error * fix: remove field name * Fix request middleware for ConnectionService (#6148) * Jamakase/update onboarding flow (#5656) * Doc explains normalization full-refresh implications (#6097) * update docs * add info in quickstart connection page * update abhi comments Co-authored-by: Marcos Marx <[email protected]> * Fix migration validation issue (#6154) Resolves #6151. * Bump Airbyte version from 0.29.18-alpha to 0.29.19-alpha (#6156) Co-authored-by: tuliren <[email protected]> * Add information on which destinations support Incremental - Deduped History in their docs (#6031) Co-authored-by: Abhi Vaidyanatha <[email protected]> * Update Airbyte Spec acknowledgements. (#6155) Co-authored-by: Abhi Vaidyanatha <[email protected]> * Update new integration request * Add back the migration acceptance test (#6163) * 🎉 Create a Helm Chart For Airbyte (#5891) See number #1868. This creates an initial helm chart for installing Airbyte in Kubernetes to make it easier for users who are more familiar with helm. It also includes GitHub actions to help continually test that the chart works in the most basic case. All of the templates are based off of the kustomize folder, but minio and postgres have been removed in favor of adding the bitnami helm charts as dependencies since they have an active community and allow easily tweaking their install. * Fix OAuth Summary strings (#6143) Co-authored-by: Marcos Eliziario Santos <[email protected]> Co-authored-by: Marcos Eliziario Santos <[email protected]> Co-authored-by: oleh.zorenko <[email protected]> Co-authored-by: Mauro <[email protected]> Co-authored-by: Sherif A. Nada <[email protected]> Co-authored-by: Jared Rhizor <[email protected]> Co-authored-by: George Claireaux <[email protected]> Co-authored-by: Liren Tu <[email protected]> Co-authored-by: LiRen Tu <[email protected]> Co-authored-by: coeurdestenebres <[email protected]> Co-authored-by: Marcos Marx <[email protected]> Co-authored-by: Marcos Marx <[email protected]> Co-authored-by: Harsha Teja Kanna <[email protected]> Co-authored-by: Davin Chia <[email protected]> Co-authored-by: Dmytro <[email protected]> Co-authored-by: Dmytro Rezchykov <[email protected]> Co-authored-by: Yevhenii <[email protected]> Co-authored-by: Jenny Brown <[email protected]> Co-authored-by: davinchia <[email protected]> Co-authored-by: Iakov Salikov <[email protected]> Co-authored-by: Artem Astapenko <[email protected]> Co-authored-by: tuliren <[email protected]> Co-authored-by: Abhi Vaidyanatha <[email protected]> Co-authored-by: Abhi Vaidyanatha <[email protected]> Co-authored-by: Jonathan Stacks <[email protected]> Co-authored-by: Christophe Duong <[email protected]>
* Add GET_FBA_INVENTORY_AGED_DATA data * Add GET_MERCHANT_LISTINGS_ALL_DATA stream support * Update schemas * Update configured_catalog.json * Update connector to airbyte-cdk * Add amazon seller partner test creds * Update state sample files * Apply code format * Update acceptance-test-config.yml * Add dummy integration test * Refactor auth signature. Update streams.py * Remove print_function import from auth.py * Refactor source class. Add pydantic spec. PR fixes. * Add dummy integration test * Typing added. Add _create_prepared_request docstring. * Add extra streams and schemas * Update docs and spec * Post merge code fixes * Fix test setup * Fix test setup * Add sample_state.json * Update reports streams logics. Update test and config files. * Update tests config. Small code style fixes. * Add reports stream slices. Update check_connection method. * Post review fixes. * Streams update * Add reports document retrieval and decrypting. Update schemas and configs. * Add CVS parsing into result rows * Update ReportsAmazonSPStream class to be the child of Stream class. Update GET_FLAT_FILE_OPEN_LISTINGS_DATA and GET_MERCHANT_LISTINGS_ALL_DATA schemas. * Schema updates * Source check method updated * Update ReportsAmazonSPStream retry report logics * Update check_connection source method * Update reports read_records method. Update report schemas. * Update streams.py * Update acceptance tests config. Add small code fixes. * Update report read_records logics * Add reports streams rate limit handling logics. Add rate limit unit tests. * Source Amazon SP: Update reports streams logics. (#5311) * Update check connection method * #5796 silence printing full config when config validation fails (#5879) * - #5796 silence printing full config when config validation fails * fix unit tests after config validation check changes Co-authored-by: Marcos Eliziario Santos <[email protected]> * Format google-search-console schemas (#6047) * Update ads_insights.json (#5946) fix ads_insights schema according to [facebook docs](https://developers.facebook.com/docs/marketing-api/reference/adgroup/insights/) and my own data * Bump connectors version + update docs (#6060) * 🐛 Source Facebook Marketing: Convert values' types according to schema types (#4978) * Convert values' types according to schema types * Put streams back to `configured_catalog.json` Put back `ads_insights` and `ads_insights_age_and_gender` streams. * Pickup changes from #5946 * Implement change request + fix previous PR * Update schema * Remove items_type from convert_to_schema_types() * Bump connectors version * add oauth to connector_base dependencies (#6064) * use spec when persisting source configs (#6036) * switch most usages of writing sources to using specs * fix other usages * fix test * only wait on the server in the scheduler, not the worker * fix * rephrase sanity check and remove stdout * 🎉 Source Stripe: Add `PaymentIntents` stream (#6004) * Add `PaymentIntents` stream * Update docs * Implement change request + few updates Split `source.py` file into `source.py` and `streams.py` files. Update `payment_intents.json` file. * Bump connectors version + update docs * Add skeleton for databricks destination (#5629) Co-authored-by: Liren Tu <[email protected]> Co-authored-by: LiRen Tu <[email protected]> * Revert "Add skeleton for databricks destination (#5629)" (#6066) This reverts commit 79256c4. * 🎉 New Destination: Databricks (#5998) Implement new destination connector for databricks delta lake. Resolves #2075. Co-authored-by: George Claireaux <[email protected]> Co-authored-by: Sherif A. Nada <[email protected]> * Source PostHog: add support for self-hosted instances (#6058) * publish #6058 (#6059) * Destination Kafka: correct spec json and data types in config (#6040) * correct spec json and data types in config * bump version * correct tests * correct config parser NPE * format files Co-authored-by: Marcos Marx <[email protected]> * Fix or delete broken links (#6069) * Fix more doc issues (#6072) * 🎉 Added optional platform flag for build image script (#6000) * Fix dependabot security alert. (#6073) * Pin set value to greater than 4.0.1 to fix security warning. * Format the rest of the connectors. * add coverage report (#6045) Co-authored-by: Dmytro Rezchykov <[email protected]> * Fix the format of the data returned by Google Ads oauth to match the config accepted by the connector (#6032) * update salesforce docs (#6081) * 🎉 Source Github: add caching for all streams (#5949) * Source Github: add checking for all streams * bump version, update changelogs * Disable automatic migration acceptance test (#5988) - The automatic migration acceptance test no longer works because of the new Flyway migration system. - The file-based migration system is being deprecated. * 🎉 CDK: Add requests native authenticator support (#5731) * Add requests native auth class * Update init file. Update type annotations. Bump version. * Update TokenAuthenticator implementation. Update Oauth2Authenticator implemetation. Add CHANGELOG.md record. * Update Oauth2Authenticator default value setting. Update CHANGELOG.md * Add requests native authenticator tests * Add CDK requests native __call__ method tests. Update CHANGELOG.md * Add outdated auth deprication messages * Update requests native auth __call__ method tests * Bump CDK version to 0.1.20 * Interface changes to support separating secrets from the config (#6065) * Interface changes to support separating secrets from the config * Cleanup from PR comments and whitespace * Update log message for empty env variable (#6115) Co-authored-by: Jared Rhizor <[email protected]> * Bump Airbyte version from 0.29.17-alpha to 0.29.18-alpha (#6125) Co-authored-by: davinchia <[email protected]> * return auth spec in the API when getting definition specification (#6121) * Ignore python test coverage files (#6144) * CDK: support nested refs resolving (#6044) Co-authored-by: Dmytro Rezchykov <[email protected]> * feat: path for nested fields (#6130) * feat: path for nested fields * fix: clipRule error * fix: remove field name * Fix request middleware for ConnectionService (#6148) * Jamakase/update onboarding flow (#5656) * Doc explains normalization full-refresh implications (#6097) * update docs * add info in quickstart connection page * update abhi comments Co-authored-by: Marcos Marx <[email protected]> * Fix migration validation issue (#6154) Resolves #6151. * Bump Airbyte version from 0.29.18-alpha to 0.29.19-alpha (#6156) Co-authored-by: tuliren <[email protected]> * Add information on which destinations support Incremental - Deduped History in their docs (#6031) Co-authored-by: Abhi Vaidyanatha <[email protected]> * Update Airbyte Spec acknowledgements. (#6155) Co-authored-by: Abhi Vaidyanatha <[email protected]> * Update new integration request * Add back the migration acceptance test (#6163) * 🎉 Create a Helm Chart For Airbyte (#5891) See number #1868. This creates an initial helm chart for installing Airbyte in Kubernetes to make it easier for users who are more familiar with helm. It also includes GitHub actions to help continually test that the chart works in the most basic case. All of the templates are based off of the kustomize folder, but minio and postgres have been removed in favor of adding the bitnami helm charts as dependencies since they have an active community and allow easily tweaking their install. * Fix OAuth Summary strings (#6143) Co-authored-by: Marcos Eliziario Santos <[email protected]> Co-authored-by: Marcos Eliziario Santos <[email protected]> Co-authored-by: oleh.zorenko <[email protected]> Co-authored-by: Mauro <[email protected]> Co-authored-by: Sherif A. Nada <[email protected]> Co-authored-by: Jared Rhizor <[email protected]> Co-authored-by: George Claireaux <[email protected]> Co-authored-by: Liren Tu <[email protected]> Co-authored-by: LiRen Tu <[email protected]> Co-authored-by: coeurdestenebres <[email protected]> Co-authored-by: Marcos Marx <[email protected]> Co-authored-by: Marcos Marx <[email protected]> Co-authored-by: Harsha Teja Kanna <[email protected]> Co-authored-by: Davin Chia <[email protected]> Co-authored-by: Dmytro <[email protected]> Co-authored-by: Dmytro Rezchykov <[email protected]> Co-authored-by: Yevhenii <[email protected]> Co-authored-by: Jenny Brown <[email protected]> Co-authored-by: davinchia <[email protected]> Co-authored-by: Iakov Salikov <[email protected]> Co-authored-by: Artem Astapenko <[email protected]> Co-authored-by: tuliren <[email protected]> Co-authored-by: Abhi Vaidyanatha <[email protected]> Co-authored-by: Abhi Vaidyanatha <[email protected]> Co-authored-by: Jonathan Stacks <[email protected]> Co-authored-by: Christophe Duong <[email protected]> * Bump source version. Update source docs. * Mock time.sleep in test_reports_stream_send_request_backoff_exception test * Acceptance test basic_read test disabled Co-authored-by: Marcos Eliziario Santos <[email protected]> Co-authored-by: Marcos Eliziario Santos <[email protected]> Co-authored-by: oleh.zorenko <[email protected]> Co-authored-by: Mauro <[email protected]> Co-authored-by: Sherif A. Nada <[email protected]> Co-authored-by: Jared Rhizor <[email protected]> Co-authored-by: George Claireaux <[email protected]> Co-authored-by: Liren Tu <[email protected]> Co-authored-by: LiRen Tu <[email protected]> Co-authored-by: coeurdestenebres <[email protected]> Co-authored-by: Marcos Marx <[email protected]> Co-authored-by: Marcos Marx <[email protected]> Co-authored-by: Harsha Teja Kanna <[email protected]> Co-authored-by: Davin Chia <[email protected]> Co-authored-by: Dmytro <[email protected]> Co-authored-by: Dmytro Rezchykov <[email protected]> Co-authored-by: Yevhenii <[email protected]> Co-authored-by: Jenny Brown <[email protected]> Co-authored-by: davinchia <[email protected]> Co-authored-by: Iakov Salikov <[email protected]> Co-authored-by: Artem Astapenko <[email protected]> Co-authored-by: tuliren <[email protected]> Co-authored-by: Abhi Vaidyanatha <[email protected]> Co-authored-by: Abhi Vaidyanatha <[email protected]> Co-authored-by: Jonathan Stacks <[email protected]> Co-authored-by: Christophe Duong <[email protected]>
What
Describe what the change is solving
It helps to add screenshots if it affects the frontend.
How
Describe the solution
Recommended reading order
x.java
y.python
Pre-merge Checklist
Expand the relevant checklist and delete the others.
New Connector
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/SUMMARY.md
docs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampledocs/integrations/README.md
airbyte-integrations/builds.md
Airbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing./publish
command described hereUpdating a connector
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampleAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing./publish
command described hereConnector Generator
-scaffold
in their name) have been updated with the latest scaffold by running./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates
then checking in your changes