Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Source Braintree: Dispute model should accept multiple Evidences #7324

Conversation

anatoliifetisov
Copy link
Contributor

What

As described in the issue #7323

How

Making Dispute model to be compliant with the actual data coming from Braintree

Pre-merge Checklist

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions
  • Connector version bumped like described here

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here

@CLAassistant
Copy link

CLAassistant commented Oct 25, 2021

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the area/connectors Connector related issues label Oct 25, 2021
@harshithmullapudi harshithmullapudi changed the title Dispute model should accept multiple Evidences 🐛 Source Braintree: Dispute model should accept multiple Evidences Oct 25, 2021
@harshithmullapudi
Copy link
Contributor

Hey @anatoliifetisov do you mind adding these https://docs.airbyte.io/connector-development#4.-publish-the-connector? It's ok if you are busy let us know we can work on that

@anatoliifetisov
Copy link
Contributor Author

@harshithmullapudi done!

@harshithmullapudi
Copy link
Contributor

@anatoliifetisov Sure thanks a lot for that. I will publish it sometime today. 🔥

@harshithmullapudi harshithmullapudi mentioned this pull request Oct 27, 2021
38 tasks
@harshithmullapudi harshithmullapudi temporarily deployed to more-secrets October 27, 2021 19:39 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets October 27, 2021 19:40 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets October 27, 2021 19:41 Inactive
@harshithmullapudi
Copy link
Contributor

harshithmullapudi commented Oct 27, 2021

@anatoliifetisov closing this as I added a small fix for integration tests in #7432 after rebasing it with yours

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants