Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Harshith/test pr 7324 #7432

Merged
merged 4 commits into from
Oct 27, 2021
Merged

Harshith/test pr 7324 #7432

merged 4 commits into from
Oct 27, 2021

Conversation

harshithmullapudi
Copy link
Contributor

@harshithmullapudi harshithmullapudi commented Oct 27, 2021 •
edited
Loading

What

To publish #7324

How

Describe the solution

Recommended reading order

  1. x.java
  2. y.python

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • docs/SUMMARY.md
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions
  • Connector added to connector index like described here

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions
  • Connector version bumped like described here

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here

Connector Generator

  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed.

@github-actions github-actions bot added the area/connectors Connector related issues label Oct 27, 2021
@harshithmullapudi harshithmullapudi temporarily deployed to more-secrets October 27, 2021 19:39 Inactive
@harshithmullapudi
Copy link
Contributor Author

harshithmullapudi commented Oct 27, 2021 •
edited by github-actions bot
Loading

/test connector=connectors/source-braintree

🕑 connectors/source-braintree https://github.com/airbytehq/airbyte/actions/runs/1391694420
❌ connectors/source-braintree https://github.com/airbytehq/airbyte/actions/runs/1391694420
🐛 https://gradle.com/s/bjdwix7uad32q

@jrhizor jrhizor temporarily deployed to more-secrets October 27, 2021 19:40 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets October 27, 2021 19:41 Inactive
@harshithmullapudi
Copy link
Contributor Author

harshithmullapudi commented Oct 27, 2021 •
edited by github-actions bot
Loading

/test connector=connectors/source-braintree

🕑 connectors/source-braintree https://github.com/airbytehq/airbyte/actions/runs/1391914434
✅ connectors/source-braintree https://github.com/airbytehq/airbyte/actions/runs/1391914434
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                 Stmts   Miss  Cover
	 ------------------------------------------------------------------------
	 source_acceptance_test/__init__.py                       2      0   100%
	 source_acceptance_test/base.py                          10      4    60%
	 source_acceptance_test/config.py                        74      8    89%
	 source_acceptance_test/conftest.py                     108    108     0%
	 source_acceptance_test/plugin.py                        47     47     0%
	 source_acceptance_test/tests/__init__.py                 4      0   100%
	 source_acceptance_test/tests/test_core.py              200     94    53%
	 source_acceptance_test/tests/test_full_refresh.py       18     11    39%
	 source_acceptance_test/tests/test_incremental.py        69     38    45%
	 source_acceptance_test/utils/__init__.py                 6      0   100%
	 source_acceptance_test/utils/asserts.py                 37      2    95%
	 source_acceptance_test/utils/common.py                  41     24    41%
	 source_acceptance_test/utils/compare.py                 47     20    57%
	 source_acceptance_test/utils/connector_runner.py        82     49    40%
	 source_acceptance_test/utils/json_schema_helper.py     115     14    88%
	 ------------------------------------------------------------------------
	 TOTAL                                                  860    419    51%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                           Stmts   Miss  Cover
	 ------------------------------------------------------------------
	 source_braintree/__init__.py                       2      0   100%
	 source_braintree/schemas/__init__.py               8      0   100%
	 source_braintree/schemas/cards.py                 86      0   100%
	 source_braintree/schemas/common.py                42      0   100%
	 source_braintree/schemas/customer.py              28      0   100%
	 source_braintree/schemas/discount.py              13      0   100%
	 source_braintree/schemas/dispute.py               37      0   100%
	 source_braintree/schemas/merchant_account.py      29      0   100%
	 source_braintree/schemas/plan.py                  21      0   100%
	 source_braintree/schemas/subscription.py          35      0   100%
	 source_braintree/schemas/transaction.py           99      0   100%
	 source_braintree/source.py                        18      0   100%
	 source_braintree/spec.py                          23      0   100%
	 source_braintree/streams.py                      100      0   100%
	 ------------------------------------------------------------------
	 TOTAL                                            541      0   100%

@harshithmullapudi harshithmullapudi temporarily deployed to more-secrets October 27, 2021 20:48 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets October 27, 2021 20:49 Inactive
@harshithmullapudi
Copy link
Contributor Author

harshithmullapudi commented Oct 27, 2021 •
edited by github-actions bot
Loading

/publish connector=connectors/source-braintree

🕑 connectors/source-braintree https://github.com/airbytehq/airbyte/actions/runs/1391936530
✅ connectors/source-braintree https://github.com/airbytehq/airbyte/actions/runs/1391936530

@harshithmullapudi harshithmullapudi mentioned this pull request Oct 27, 2021
Closed
15 tasks
@jrhizor jrhizor temporarily deployed to more-secrets October 27, 2021 20:56 Inactive
@harshithmullapudi harshithmullapudi merged commit 2e128cf into master Oct 27, 2021
@harshithmullapudi harshithmullapudi deleted the harshith/test-pr-7324 branch October 27, 2021 21:03
@anatoliifetisov
Copy link
Contributor

@harshithmullapudi oh, looks like the version bump in source_definitions.yaml was lost somehow

@harshithmullapudi
Copy link
Contributor Author

oops will add it.

@jrhizor jrhizor mentioned this pull request Nov 1, 2021
Merged
@marcosmarxm marcosmarxm mentioned this pull request Dec 14, 2021
Merged
40 tasks
schlattk pushed a commit to schlattk/airbyte that referenced this pull request Jan 4, 2022
@harshithmullapudi @anatoliifetisov @schlattk
Harshith/test pr 7324 (airbytehq#7432)
a84c07d 
* Allow Dispute model to accept multiple Evidences

* Bump connector's version

* fix: changed expected_records file based on changes

Co-authored-by: Anatolii Fetisov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area/connectors Connector related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@harshithmullapudi @anatoliifetisov @jrhizor