Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎉 Source Google Workspace Admin Reports: migrate to the CDK #7623

Conversation

vitaliizazmic
Copy link
Contributor

@vitaliizazmic vitaliizazmic commented Nov 4, 2021

What

Refactoring Source Google Workspace Admin Reports to use the CDK

Closes #7531

How

This task is part of issue #6164. The Source significantly relies on dead CDK code. So import BaseClient and BaseSource from base_python were replaced by import from deprecated package of the CDK. Gradle file, setup.py, Dockerfile, requirements.txt were updated. main_dev.py was renamed to main.py, updated, and added to .dockerignore.

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions
  • Connector version bumped like described here

@vitaliizazmic vitaliizazmic self-assigned this Nov 4, 2021
@github-actions github-actions bot added the area/connectors Connector related issues label Nov 4, 2021
Copy link
Contributor

@eliziario eliziario left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vitaliizazmic vitaliizazmic temporarily deployed to more-secrets November 8, 2021 15:11 Inactive
@vitaliizazmic vitaliizazmic temporarily deployed to more-secrets November 8, 2021 15:16 Inactive
@vitaliizazmic
Copy link
Contributor Author

vitaliizazmic commented Nov 8, 2021

/test connector=source-google-workspace-admin-reports

🕑 source-google-workspace-admin-reports https://github.com/airbytehq/airbyte/actions/runs/1435405876
❌ source-google-workspace-admin-reports https://github.com/airbytehq/airbyte/actions/runs/1435405876
🐛 https://gradle.com/s/q5pjr7oced432

@jrhizor jrhizor temporarily deployed to more-secrets November 8, 2021 15:18 Inactive
@vitaliizazmic
Copy link
Contributor Author

vitaliizazmic commented Nov 8, 2021

/test connector=source-google-workspace-admin-reports

🕑 source-google-workspace-admin-reports https://github.com/airbytehq/airbyte/actions/runs/1435454095
❌ source-google-workspace-admin-reports https://github.com/airbytehq/airbyte/actions/runs/1435454095
🐛 https://gradle.com/s/gfdxrl5zkxaas

@jrhizor jrhizor temporarily deployed to more-secrets November 8, 2021 15:29 Inactive
@vitaliizazmic
Copy link
Contributor Author

vitaliizazmic commented Nov 8, 2021

/test connector=source-google-workspace-admin-reports

🕑 source-google-workspace-admin-reports https://github.com/airbytehq/airbyte/actions/runs/1435516315
✅ source-google-workspace-admin-reports https://github.com/airbytehq/airbyte/actions/runs/1435516315
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                 Stmts   Miss  Cover
	 ------------------------------------------------------------------------
	 source_acceptance_test/__init__.py                       2      0   100%
	 source_acceptance_test/base.py                          10      4    60%
	 source_acceptance_test/config.py                        75      8    89%
	 source_acceptance_test/conftest.py                     108    108     0%
	 source_acceptance_test/plugin.py                        47     47     0%
	 source_acceptance_test/tests/__init__.py                 4      0   100%
	 source_acceptance_test/tests/test_core.py              200     94    53%
	 source_acceptance_test/tests/test_full_refresh.py       38     27    29%
	 source_acceptance_test/tests/test_incremental.py        69     38    45%
	 source_acceptance_test/utils/__init__.py                 6      0   100%
	 source_acceptance_test/utils/asserts.py                 37      2    95%
	 source_acceptance_test/utils/common.py                  41     24    41%
	 source_acceptance_test/utils/compare.py                 62     25    60%
	 source_acceptance_test/utils/connector_runner.py        82     49    40%
	 source_acceptance_test/utils/json_schema_helper.py     115     14    88%
	 ------------------------------------------------------------------------
	 TOTAL                                                  896    440    51%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                Stmts   Miss  Cover
	 -----------------------------------------------------------------------
	 source_google_workspace_admin_reports/__init__.py       2      2     0%
	 source_google_workspace_admin_reports/api.py          128    128     0%
	 source_google_workspace_admin_reports/client.py        26     26     0%
	 source_google_workspace_admin_reports/source.py         4      4     0%
	 source_google_workspace_admin_reports/__init__.py       2      2     0%/actions-runner/_work/airbyte/airbyte/airbyte-integrations/connectors/source-google-workspace-admin-reports/.venv/lib/python3.8/site-packages/coverage/control.py:761: CoverageWarning: No data was collected. (no-data-collected)
	 source_google_workspace_admin_reports/utils.py          6      6     0%
	 -----------------------------------------------------------------------
	 TOTAL                                                 166    166     0%

@jrhizor jrhizor temporarily deployed to more-secrets November 8, 2021 15:45 Inactive
@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label Nov 8, 2021
@vitaliizazmic
Copy link
Contributor Author

vitaliizazmic commented Nov 8, 2021

/publish connector=connectors/source-google-workspace-admin-reports

🕑 connectors/source-google-workspace-admin-reports https://github.com/airbytehq/airbyte/actions/runs/1435593502
✅ connectors/source-google-workspace-admin-reports https://github.com/airbytehq/airbyte/actions/runs/1435593502

@vitaliizazmic vitaliizazmic temporarily deployed to more-secrets November 8, 2021 16:02 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets November 8, 2021 16:04 Inactive
@vitaliizazmic vitaliizazmic temporarily deployed to more-secrets November 8, 2021 16:14 Inactive
@vitaliizazmic vitaliizazmic merged commit 3cbfb99 into master Nov 8, 2021
@vitaliizazmic vitaliizazmic deleted the vitalii/7531_google_workspace_admin_reports_refactor_to_use_the_cdk branch November 8, 2021 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Source Google Workspace Admin Reports: refactor to use the CDK
4 participants