Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🎉 Sources Appstore Singer: refactor to use the cdk #7757

Merged
merged 9 commits into from
Dec 9, 2021
Merged

🎉 Sources Appstore Singer: refactor to use the cdk #7757

merged 9 commits into from
Dec 9, 2021

Conversation

vitaliizazmic
Copy link
Contributor

@vitaliizazmic vitaliizazmic commented Nov 8, 2021 •
edited
Loading

What

Sources Appstore Singer to use the CDK

Closes #7652

How

This task is part of issue #6164 and #7244.

The Source Appstore Singer significantly relies on dead CDK code. So import BaseSource from base_python were replaced by import from deprecated package of the CDK. Gradle file, setup.py, Dockerfile, requirements.txt were updated. main_dev.py was renamed to main.py, updated, and added to .dockerignore.
SAT wasn't set up for the connector because packages versions conflicting error in dependencies appeared while installing source-acceptance-test package. Separated issue was created airbytehq/airbyte-internal-issues#319. Also test credentials is required.
.

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions
  • Connector version bumped like described here

@vitaliizazmic vitaliizazmic self-assigned this Nov 8, 2021
@github-actions github-actions bot added the area/connectors Connector related issues label Nov 8, 2021
@keu
Copy link
Contributor

keu commented Nov 18, 2021

please add SAT integration

keu
keu suggested changes Nov 18, 2021
View reviewed changes
Copy link
Contributor

@keu keu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SAT

@vitaliizazmic vitaliizazmic changed the title 🎉 Sources Appstore Singer and Kustomer Singer: refactor to use the cdk 🎉 Sources Appstore Singer: refactor to use the cdk Dec 8, 2021
@vitaliizazmic vitaliizazmic temporarily deployed to more-secrets December 8, 2021 22:52 Inactive
@vitaliizazmic vitaliizazmic temporarily deployed to more-secrets December 8, 2021 23:00 Inactive
@vitaliizazmic
Copy link
Contributor Author

vitaliizazmic commented Dec 8, 2021 •
edited by github-actions bot
Loading

/test connector=source-appstore-singer

🕑 source-appstore-singer https://github.com/airbytehq/airbyte/actions/runs/1556346352
❌ source-appstore-singer https://github.com/airbytehq/airbyte/actions/runs/1556346352
🐛 https://gradle.com/s/wbyn4ndasv54a

@vitaliizazmic vitaliizazmic temporarily deployed to more-secrets December 8, 2021 23:03 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets December 8, 2021 23:05 Inactive
@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label Dec 8, 2021
@vitaliizazmic vitaliizazmic temporarily deployed to more-secrets December 8, 2021 23:15 Inactive
@vitaliizazmic
Copy link
Contributor Author

vitaliizazmic commented Dec 8, 2021 •
edited by github-actions bot
Loading

/test connector=source-appstore-singer

🕑 source-appstore-singer https://github.com/airbytehq/airbyte/actions/runs/1556436631
❌ source-appstore-singer https://github.com/airbytehq/airbyte/actions/runs/1556436631
🐛 https://gradle.com/s/bqvsqdijz6ceu

@vitaliizazmic vitaliizazmic temporarily deployed to more-secrets December 8, 2021 23:35 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets December 8, 2021 23:36 Inactive
@vitaliizazmic
Copy link
Contributor Author

vitaliizazmic commented Dec 8, 2021 •
edited by github-actions bot
Loading

/test connector=source-appstore-singer

🕑 source-appstore-singer https://github.com/airbytehq/airbyte/actions/runs/1556475711
✅ source-appstore-singer https://github.com/airbytehq/airbyte/actions/runs/1556475711
No Python unittests run

@vitaliizazmic vitaliizazmic temporarily deployed to more-secrets December 8, 2021 23:50 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets December 8, 2021 23:51 Inactive
@vitaliizazmic
Copy link
Contributor Author

vitaliizazmic commented Dec 8, 2021 •
edited by github-actions bot
Loading

/publish connector=connectors/source-appstore-singer

🕑 connectors/source-appstore-singer https://github.com/airbytehq/airbyte/actions/runs/1556492940
✅ connectors/source-appstore-singer https://github.com/airbytehq/airbyte/actions/runs/1556492940

@jrhizor jrhizor temporarily deployed to more-secrets December 8, 2021 23:58 Inactive
@vitaliizazmic vitaliizazmic temporarily deployed to more-secrets December 9, 2021 00:07 Inactive
@vitaliizazmic vitaliizazmic merged commit 3d7e62d into master Dec 9, 2021
@vitaliizazmic vitaliizazmic deleted the vitalii/7652_appstore_singer_refactor_to_use_the_cdk branch December 9, 2021 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keu keu keu requested changes

@augan-rymkhan augan-rymkhan Awaiting requested review from augan-rymkhan

@eliziario eliziario Awaiting requested review from eliziario

@sergei-solonitcyn sergei-solonitcyn Awaiting requested review from sergei-solonitcyn

Assignees

@vitaliizazmic vitaliizazmic

Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/appstore-singer connectors/sources-api
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sources Appstore Singer and Kustomer Singer: refactor to use the CDK
4 participants
@vitaliizazmic @keu @jrhizor @igrankova