Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🎉 Source Google Sheets: migrate to the CDK #8470

Merged
merged 7 commits into from
Dec 7, 2021
Merged

🎉 Source Google Sheets: migrate to the CDK #8470

merged 7 commits into from
Dec 7, 2021

Conversation

vitaliizazmic
Copy link
Contributor

What

Refactoring Source Google Sheets to use the CDK

Closes #8313

How

This task is part of issue #6164. The Source significantly relies on dead CDK code. So import BaseClient and BaseSource from base_python were replaced by import from deprecated package of the CDK. Gradle file, setup.py, Dockerfile, requirements.txt were updated. main_dev.py was renamed to main.py, updated, and added to .dockerignore. Also SAT was enabled to Source.

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions
  • Connector version bumped like described here

@vitaliizazmic vitaliizazmic self-assigned this Dec 2, 2021
@github-actions github-actions bot added the area/connectors Connector related issues label Dec 2, 2021
@vitaliizazmic
Copy link
Contributor Author

vitaliizazmic commented Dec 2, 2021 •
edited by github-actions bot
Loading

/test connector=source-google-sheets

🕑 source-google-sheets https://github.com/airbytehq/airbyte/actions/runs/1531833253
❌ source-google-sheets https://github.com/airbytehq/airbyte/actions/runs/1531833253
🐛 https://gradle.com/s/qpg5yloy6psue

@jrhizor jrhizor temporarily deployed to more-secrets December 2, 2021 17:57 Inactive
@vitaliizazmic
Copy link
Contributor Author

vitaliizazmic commented Dec 2, 2021 •
edited by github-actions bot
Loading

/test connector=source-google-sheets

🕑 source-google-sheets https://github.com/airbytehq/airbyte/actions/runs/1531891466
❌ source-google-sheets https://github.com/airbytehq/airbyte/actions/runs/1531891466
🐛 https://gradle.com/s/5maw2itorzwsg

@vitaliizazmic vitaliizazmic temporarily deployed to more-secrets December 2, 2021 18:12 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets December 2, 2021 18:12 Inactive
@vitaliizazmic
Copy link
Contributor Author

vitaliizazmic commented Dec 2, 2021 •
edited by github-actions bot
Loading

/test connector=source-google-sheets

🕑 source-google-sheets https://github.com/airbytehq/airbyte/actions/runs/1531946639
❌ source-google-sheets https://github.com/airbytehq/airbyte/actions/runs/1531946639
🐛 https://gradle.com/s/szcdv3mxibjgu

@jrhizor jrhizor temporarily deployed to more-secrets December 2, 2021 18:27 Inactive
@vitaliizazmic vitaliizazmic temporarily deployed to more-secrets December 6, 2021 15:47 Inactive
@vitaliizazmic
Copy link
Contributor Author

vitaliizazmic commented Dec 6, 2021 •
edited by github-actions bot
Loading

/test connector=source-google-sheets

🕑 source-google-sheets https://github.com/airbytehq/airbyte/actions/runs/1545616640
❌ source-google-sheets https://github.com/airbytehq/airbyte/actions/runs/1545616640
🐛 https://gradle.com/s/ldd7zlm3k4bvg

@jrhizor jrhizor temporarily deployed to more-secrets December 6, 2021 16:44 Inactive
@vitaliizazmic
Copy link
Contributor Author

vitaliizazmic commented Dec 6, 2021 •
edited by github-actions bot
Loading

/test connector=source-google-sheets

🕑 source-google-sheets https://github.com/airbytehq/airbyte/actions/runs/1545977105
❌ source-google-sheets https://github.com/airbytehq/airbyte/actions/runs/1545977105
🐛 https://gradle.com/s/mhfz2ugpxnrpq

@vitaliizazmic vitaliizazmic temporarily deployed to more-secrets December 6, 2021 18:14 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets December 6, 2021 18:14 Inactive
@vitaliizazmic
Copy link
Contributor Author

vitaliizazmic commented Dec 7, 2021 •
edited by github-actions bot
Loading

/test connector=source-google-sheets

🕑 source-google-sheets https://github.com/airbytehq/airbyte/actions/runs/1548664160
✅ source-google-sheets https://github.com/airbytehq/airbyte/actions/runs/1548664160
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                 Stmts   Miss  Cover
	 ------------------------------------------------------------------------
	 source_acceptance_test/__init__.py                       2      0   100%
	 source_acceptance_test/base.py                          10      4    60%
	 source_acceptance_test/config.py                        76      8    89%
	 source_acceptance_test/conftest.py                     109    109     0%
	 source_acceptance_test/plugin.py                        47     47     0%
	 source_acceptance_test/tests/__init__.py                 4      0   100%
	 source_acceptance_test/tests/test_core.py              235     95    60%
	 source_acceptance_test/tests/test_full_refresh.py       38     27    29%
	 source_acceptance_test/tests/test_incremental.py        69     38    45%
	 source_acceptance_test/utils/__init__.py                 6      0   100%
	 source_acceptance_test/utils/asserts.py                 37      2    95%
	 source_acceptance_test/utils/common.py                  54     24    56%
	 source_acceptance_test/utils/compare.py                 62     25    60%
	 source_acceptance_test/utils/connector_runner.py        82     49    40%
	 source_acceptance_test/utils/json_schema_helper.py     115     14    88%
	 ------------------------------------------------------------------------
	 TOTAL                                                  946    442    53%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                Stmts   Miss  Cover
	 -----------------------------------------------------------------------
	 google_sheets_source/__init__.py                        2      0   100%
	 google_sheets_source/client.py                         22      5    77%
	 google_sheets_source/google_sheets_source.py          103     84    18%
	 google_sheets_source/helpers.py                       129     26    80%
	 google_sheets_source/models/__init__.py                 2      0   100%
	 google_sheets_source/models/spreadsheet.py             34      0   100%
	 google_sheets_source/models/spreadsheet_values.py      12      0   100%
	 -----------------------------------------------------------------------
	 TOTAL                                                 304    115    62%

@vitaliizazmic vitaliizazmic temporarily deployed to more-secrets December 7, 2021 09:11 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets December 7, 2021 09:11 Inactive
@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label Dec 7, 2021
@vitaliizazmic vitaliizazmic temporarily deployed to more-secrets December 7, 2021 09:53 Inactive
@vitaliizazmic
Copy link
Contributor Author

vitaliizazmic commented Dec 7, 2021 •
edited by github-actions bot
Loading

/publish connector=connectors/source-google-sheets

🕑 connectors/source-google-sheets https://github.com/airbytehq/airbyte/actions/runs/1548834139
✅ connectors/source-google-sheets https://github.com/airbytehq/airbyte/actions/runs/1548834139

@jrhizor jrhizor temporarily deployed to more-secrets December 7, 2021 09:57 Inactive
@vitaliizazmic vitaliizazmic temporarily deployed to more-secrets December 7, 2021 10:11 Inactive
@vitaliizazmic vitaliizazmic merged commit 487f9e7 into master Dec 7, 2021
@vitaliizazmic vitaliizazmic deleted the vitalii/8313_google_sheets_refactor_to_use_the_cdk branch December 7, 2021 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keu keu keu approved these changes

Assignees

@vitaliizazmic vitaliizazmic

Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Source Google Sheets: refactor to use the CDK
3 participants
@vitaliizazmic @keu @jrhizor