-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update/implement celery k8s executor #3398
Update/implement celery k8s executor #3398
Conversation
WalkthroughWalkthroughThis pull request introduces modifications to the Changes
Possibly related PRs
Poem
Tip New featuresWalkthrough comment now includes:
Notes:
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- k8s/workflows/values-prod.yaml (2 hunks)
Additional comments not posted (3)
k8s/workflows/values-prod.yaml (3)
14-15
: String formatting updated for consistency.The changes from single quotes to double quotes (
nameOverride
andfullnameOverride
) are minor but improve consistency in YAML files, where double quotes are generally preferred for strings that might be evaluated by parsers. This change is straightforward and does not impact functionality.
27-27
: Increased CPU request for the scheduler.The CPU request for the scheduler has been increased from
112m
to125m
. This adjustment seems to be a fine-tuning measure to possibly handle more load or improve scheduler responsiveness. It's important to ensure that this change is aligned with observed CPU usage metrics to avoid over-provisioning.
34-35
: Significant reduction in memory request for Celery.The memory request for the Celery component has been drastically reduced from
1250Mi
to125Mi
. This is a substantial decrease and could potentially lead to issues if Celery workers are memory-intensive. It's crucial to verify that this new setting can handle the typical workload without causing memory pressure or out-of-memory kills.
WHAT DOES THIS PR DO?
WHAT ISSUES ARE RELATED TO THIS PR?
Summary by CodeRabbit