Update/implement celery k8s executor

[NicholasTurner23]

WHAT DOES THIS PR DO?

• Fixes deployed celery worker OOMKilled error by kubernetes.

WHAT ISSUES ARE RELATED TO THIS PR?

• Jira cards
  • [] OPS-269

Summary by CodeRabbit

• New Features

  • Adjusted autoscaling parameters for the Celery worker, optimizing resource utilization.

• Performance Improvements

  • Increased memory allocation for the webserver container from 3000Mi to 4000Mi in both production and staging configurations, enhancing performance capabilities.

• Configuration Refinements

  • Standardized YAML formatting by changing single quotes to double quotes for certain fields in configuration files.

[coderabbitai]

Walkthrough

Walkthrough

This pull request introduces modifications to Kubernetes deployment configurations, specifically for the Celery worker's autoscaling parameters. The maximum and minimum worker processes have been adjusted to enhance resource management. Additionally, YAML configuration files have been updated for consistency in string formatting and increased memory limits for the webserver container, reflecting a refinement in resource allocation across environments.

Changes

File Path	Change Summary
k8s/workflows/templates/deployment.yaml	Modified Celery worker command arguments from --autoscale=8,3 to --autoscale=6,2.
k8s/workflows/values-prod.yaml	Changed nameOverride and fullnameOverride from single to double quotes; increased memory limit from 3000Mi to 4000Mi.
k8s/workflows/values-stage.yaml	Changed nameOverride and fullnameOverride from single to double quotes; increased memory limit from 3000Mi to 4000Mi.

Possibly related PRs

• Update/implement celery k8s executor #3393: This PR modifies the k8s/workflows/templates/deployment.yaml file, which is directly related to the main PR's changes in the same file, specifically regarding the Celery worker configuration.
• Update/implement celery k8s executor #3398: This PR also updates the k8s/workflows/values-prod.yaml file, which is relevant as it includes changes to resource requests for the Celery component, aligning with the main PR's focus on Celery worker autoscaling adjustments.

Suggested labels

data-engineering, data-mgt

Poem

In the land of code where changes flow,
Celery workers now dance in a new row.
Autoscale whispers, "Less is more,"
As memory grows, we open the door.
YAML sings in double quotes bright,
Resource management shines with new light. 🌟

Tip

New features

Walkthrough comment now includes:

• Possibly related PRs: A list of potentially related PRs to help you recall past context.
• Suggested labels: CodeRabbit can now suggest labels by learning from your past PRs. You can also provide custom labeling instructions in the UI or configuration file.

Notes:

• Please share any feedback in the discussion post on our Discord.
• Possibly related PRs, automatic label suggestions based on past PRs, learnings, and possibly related issues require data opt-in (enabled by default).

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Outside diff range, codebase verification and nitpick comments (3)

k8s/workflows/values-prod.yaml (1)

38-38: Memory limit increased to address OOM issues.

The memory limit for the webserver container has been increased from 3000Mi to 4000Mi. This change is crucial in addressing the OOM killed errors as described in the PR objectives. It is recommended to monitor the system's performance and resource utilization following this adjustment to ensure it meets the expected improvements without overallocation.

k8s/workflows/values-stage.yaml (1)

38-38: Increased memory limit for better resource management.

The memory limit for the celery container has been increased from 3000Mi to 4000Mi, mirroring the change made in the production environment. This adjustment is crucial for addressing potential OOM issues and should be monitored to assess its effectiveness and resource utilization.

k8s/workflows/templates/deployment.yaml (1)

86-86: Optimized autoscaling parameters for Celery worker.

The autoscale parameters for the Celery worker have been adjusted from --autoscale=8,3 to --autoscale=6,2. This change is intended to optimize resource usage and prevent OOM issues by reducing the number of concurrent worker processes. It is advisable to monitor the impact of this change on task processing times and overall system performance to ensure that it meets the operational requirements without adversely affecting throughput.

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 351ffdb and 40d882a.

Files selected for processing (3)

• k8s/workflows/templates/deployment.yaml (1 hunks)
• k8s/workflows/values-prod.yaml (2 hunks)
• k8s/workflows/values-stage.yaml (2 hunks)

Additional comments not posted (2)

k8s/workflows/values-prod.yaml (1)

14-15: String formatting consistency improved.

The changes from single to double quotes in nameOverride and fullnameOverride enhance consistency in YAML formatting. These changes are approved as they do not impact functionality.

k8s/workflows/values-stage.yaml (1)

14-15: Consistent string formatting across environments.

The changes from single to double quotes in nameOverride and fullnameOverride are consistent with the production environment settings, enhancing uniformity across deployments. These changes are approved.