Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add conversion to f-strings using flynt #308

Merged
merged 10 commits into from
Jan 22, 2023
Merged

Add conversion to f-strings using flynt #308

merged 10 commits into from
Jan 22, 2023

Conversation

akaihola
Copy link
Owner

@akaihola akaihola commented Feb 24, 2022 •
edited
Loading

Fixes #266.

@akaihola akaihola added the enhancement New feature or request label Feb 24, 2022
@akaihola akaihola added this to the 1.6.0 milestone Feb 24, 2022
@akaihola akaihola self-assigned this Feb 24, 2022
@akaihola akaihola marked this pull request as draft February 24, 2022 19:26
@akaihola akaihola force-pushed the flynt branch 3 times, most recently from 88a098a to 6cedbbb Compare March 14, 2022 17:52
@akaihola akaihola force-pushed the flynt branch 3 times, most recently from 860a125 to b0dd8f7 Compare March 26, 2022 21:43
@akaihola akaihola force-pushed the flynt branch 5 times, most recently from 1d54d63 to ad38367 Compare April 5, 2022 16:56
@akaihola akaihola force-pushed the flynt branch 3 times, most recently from d5109a1 to 5294ba9 Compare April 10, 2022 12:38
This was referenced Aug 27, 2022
Merged
Merged
@akaihola
Copy link
Owner Author

@jedie, the implementation is still in progress. I did two preparatery refactorings which will make it simpler to add new pre-processors (like flynt in addition to isort). Would you be willing to review them as well (#376 and #377)?

@akaihola
Copy link
Owner Author

@jedie, there's now a proof-of-concept implementation in this branch. It sits on top of two refactorin branches, and there aren't yet any unit tests. Also, no Flynt configuration whatsoever is being taken into account – and I think that's ok for the initial version of flynt support.

Feel free to test it!

@akaihola akaihola marked this pull request as ready for review December 28, 2022 21:54
@akaihola
Copy link
Owner Author

@jedie, this one is coming up in version 1.7.0. I've completed and cleaned up the branch, and marked this pull request as ready for review. Would you take a look?

There's quite a bit of clean-up and refactoring, and I tried to group things into separate commits for easier review.

@akaihola
Copy link
Owner Author

akaihola commented Dec 28, 2022 •
edited
Loading

@Carreau, FYI, merging this PR will make it easier to continue with pyupgrade support in #51. Would you be interested to review this one?

@akaihola akaihola mentioned this pull request Jan 2, 2023
Merged
3 tasks
@akaihola akaihola merged commit 4f9ea40 into master Jan 22, 2023
@akaihola akaihola deleted the flynt branch January 22, 2023 16:08
@hugovk hugovk mentioned this pull request Feb 27, 2024
Closed
@akaihola akaihola removed this from the Darker 1.7.0 milestone Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jedie jedie jedie left review comments

Assignees

@akaihola akaihola

Labels
enhancement New feature or request
Projects
Darker and Graylint development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No support for using flynt to convert old string literal formatting to f-strings
2 participants
@akaihola @jedie