Refactoring: Care only if import sorting was done, not whether isort was run or not. #376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 27, 2022
akaihola
force-pushed
the
isort-changed-simplification
branch
from
6dd15b5
to
13a37d7
Compare
|
@jedie, could you review this refactoring which was done in preparation for flynt support? You seem to have resigned as a collaborator on this repository, so I can't assign you as a reviewer. Did you do that on purpose, or would you like me to renew your collaborator status? |
akaihola
force-pushed
the
isort-changed-simplification
branch
from
219d451
to
8496360
Compare
...not whether isort was run or not. This is in preparation for unified exclusions, which is in preparation for `flynt` support.
akaihola
force-pushed
the
isort-changed-simplification
branch
from
8496360
to
a285b34
Compare
jedie
approved these changes
Aug 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactoring simplification is in preparation for unified exclusions (#377), which is in preparation for
flyntsupport (#266 & #308).Merge this before any of those.