Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AWS S3: add methods for the new actors API #2211

Merged
merged 2 commits into from
Mar 18, 2020
Merged

AWS S3: add methods for the new actors API #2211

merged 2 commits into from
Mar 18, 2020

Conversation

ennru
Copy link
Member

@ennru ennru commented Mar 18, 2020

Complement the S3Ext extension with access methods for ClassicActorSystemProvider which makes it usable without changed for the new actors API's akka.actor.typed.ActorSystem without depending on that module.

This can't be compiled against Akka 2.6 as ExtensionId in that version contains the apply(ClassicActorSystemProvider) method so it requires an override modifier in S3Ext.

See #2194, #2195, #2197

@ennru ennru added this to the 2.0.0 milestone Mar 18, 2020
@ennru ennru mentioned this pull request Mar 18, 2020
Merged
@ennru ennru mentioned this pull request Mar 18, 2020
Merged
@raboof raboof merged commit a7b6a9f into akka:master Mar 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raboof raboof raboof approved these changes

Assignees
No one assigned
Labels
p:aws-s3
Projects
None yet
Milestone
2.0.0-RC1
Development

Successfully merging this pull request may close these issues.
2 participants
@ennru @raboof