Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google Cloud Storage: add access with new actors API #2213

Merged
merged 1 commit into from
Mar 19, 2020

Conversation

ennru
Copy link
Member

@ennru ennru commented Mar 18, 2020

Complement the GCStorageExt extension with access methods for ClassicActorSystemProvider which makes it usable without changed for the new actors API's akka.actor.typed.ActorSystem without depending on that module.

This can't be compiled against Akka 2.6 as ExtensionId in that version contains the apply(ClassicActorSystemProvider) method so it requires an override modifier in GCStorageExt.

See #2194, #2195, #2197, #2211, #2212

Copy link
Member

@jrudolph jrudolph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -15,3 +15,6 @@ ProblemFilters.exclude[MissingClassProblem]("main.scala.*")
ProblemFilters.exclude[IncompatibleSignatureProblem]("akka.stream.alpakka.googlecloud.storage.StorageObject.*")
ProblemFilters.exclude[IncompatibleMethTypeProblem]("akka.stream.alpakka.googlecloud.storage.StorageObject.withCustomerEncryption")
ProblemFilters.exclude[IncompatibleMethTypeProblem]("akka.stream.alpakka.googlecloud.storage.StorageObject.withOwner")

# override of apply in extension with the concrete type instead of the generic type
ProblemFilters.exclude[IncompatibleResultTypeProblem]("akka.stream.alpakka.googlecloud.storage.GCStorageExt.apply")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has this really changed? Maybe it's just lightbend-labs/mima#433

@ennru ennru merged commit 9f26e38 into akka:master Mar 19, 2020
@ennru ennru deleted the gcs-classic-vs-typed branch March 19, 2020 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants