fix overflow in parameter sizes for ARP timeouts #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this issue rectified the lastest repo |
No, I don't believe it is. |
alexforencich
force-pushed
the
master
branch
2 times, most recently
from
3155340
to
80a2573
Compare
alexforencich
force-pushed
the
master
branch
2 times, most recently
from
ae942ad
to
870cebb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ARP sends a request 4 times with a 2 second delay then should wait for 30s before dropping packet.
The parameter declarations and literals default to integer (signed 32 bit).
The 30 sec cycle count doesn't fit in 31 bits of integer and overflows, result is a 9min wait before dropping packet.
log2(125000000 * 2) = 27.89
log2(125000000 * 30) = 31.80 (overflow)