Fix udp checksum header overflow #84
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ll header fifo causes a header to be dropped. Fixed by adding a final state in the state-machine to allow complete commit of header before going to back IDLE. This adds one clock cycle of dead time, which could affect throughput slightly. Another options would be to make the backpressure path from the fifo combinatorial, but this could cause timing issues on some systems.
alexforencich
force-pushed
the
master
branch
2 times, most recently
from
3155340
to
80a2573
Compare
alexforencich
force-pushed
the
master
branch
2 times, most recently
from
ae942ad
to
870cebb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is a potential solution for the issue in #83. This adds a state to the SM to wait for the header commit to reflect in the FIFO before going back to IDLE. This will cost one clock cycle throughput on the interface. One could also make the backpressure path combinatorial, but that could cause timing closure issues.