fix(algolia): fix getAlgoliaResults typings
#336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes some wrong types in the `getAlgoliaResults` function. We now make sure to receive records as inputs and to return hits (being their returned value with highlighting and snipetting).
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit a2200cf:
|
Haroenv
reviewed
Oct 12, 2020
| @@ -2,11 +2,11 @@ import { Hit } from '@algolia/client-search'; | |||
|
|
|||
| import { search, SearchParams } from './search'; | |||
|
|
|||
| export function getAlgoliaHits<THit>({ | |||
| export function getAlgoliaHits<TRecord>({ | |||
There was a problem hiding this comment.
what happened to the idea of making this an indexName indexed object of records? The client doesn't have the feature, but I think we could assert the type here?
There was a problem hiding this comment.
I think it makes more sense to implement this type mapping in the client first, and then to leverage that in Autocomplete. It'll avoid shipping any inconsistencies.
(The more I work on multi-index UIs with the search client, the more I need this type support btw 🙂)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes some wrong types in the
getAlgoliaResultsfunction. We now make sure to receive records as inputs and to return hits (being their returned value with highlighting and snippetting).