Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(theme): patch theme #497

Merged
merged 30 commits into from
Apr 1, 2021
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
4c954e3
feat(theme): patch theme
francoischalifour Mar 18, 2021
52bfd97
feat: convert CSS color vars to RGB and alpha tuples
francoischalifour Mar 19, 2021
cd6facd
feat: remove capitalize on header
francoischalifour Mar 19, 2021
b8728ca
feat: rename columns CSS classes
francoischalifour Mar 19, 2021
ed288f3
fix: fix scrollable class case
francoischalifour Mar 19, 2021
7fbeec3
chore: update comments
francoischalifour Mar 19, 2021
d64ed5a
fix: rename ItemIcon CSS modifiers
francoischalifour Mar 19, 2021
9a758ea
fix: fix DetachedContainer modal CSS modifier case
francoischalifour Mar 19, 2021
17cdd21
chore: improve stylelint config
francoischalifour Mar 19, 2021
a593a79
chore: update comments
francoischalifour Mar 19, 2021
87463e1
chore: run lint
francoischalifour Mar 19, 2021
75c56ed
chore(examples): update icon class
francoischalifour Mar 19, 2021
bd7e49b
fix: remove `aa-key-shadow` var
francoischalifour Mar 24, 2021
9c26026
feat: use base `z-index` var
francoischalifour Mar 24, 2021
71c229f
refactor: update CSS vars descriptions
francoischalifour Mar 24, 2021
8041ea3
docs: update comments
francoischalifour Mar 24, 2021
6e1daa2
fix: inherit font family
francoischalifour Mar 25, 2021
83c7478
fix: use CSS vars for font-weight
francoischalifour Mar 25, 2021
2635bed
fix: extract description mark to CSS var
francoischalifour Mar 25, 2021
4e08550
feat: design scrollbar
francoischalifour Mar 25, 2021
dd2aaa0
fix: edit spacing and alignments
francoischalifour Mar 26, 2021
b0db1c2
feat: design products
francoischalifour Mar 26, 2021
d6851a2
fix: fix bottom scroll on Safari mobile
sarahdayan Mar 26, 2021
2f38872
fix: fix stuck hover state issue on Safari mobile
sarahdayan Mar 26, 2021
bf8650e
chore(examples): set `categoriesPerItem` to 2
francoischalifour Mar 26, 2021
7b03561
chore: increase bundle size
francoischalifour Mar 29, 2021
0498db4
fix: give full opacity to scroll bar
francoischalifour Mar 29, 2021
3f2e262
Merge branch 'next' into feat/theme-patch
francoischalifour Mar 29, 2021
ecdb00f
docs(examples): update playground products
francoischalifour Mar 29, 2021
ec98541
Merge branch 'next' into feat/theme-patch
francoischalifour Mar 31, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion bundlesize.config.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
},
{
"path": "packages/autocomplete-js/dist/umd/index.production.js",
"maxSize": "14.50 kB"
"maxSize": "14.75 kB"
},
{
"path": "packages/autocomplete-preset-algolia/dist/umd/index.production.js",
Expand All @@ -23,6 +23,10 @@
{
"path": "packages/autocomplete-plugin-query-suggestions/dist/umd/index.production.js",
"maxSize": "4 kB"
},
{
"path": "packages/autocomplete-theme-classic/dist/theme.css",
"maxSize": "4 kB"
}
]
}
23 changes: 16 additions & 7 deletions packages/autocomplete-js/src/__tests__/render.test.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import { fireEvent, waitFor } from '@testing-library/dom';
import {
createElement as preactCreateElement,
Fragment,
Fragment as PreactFragment,
render,
} from 'preact';
Expand Down Expand Up @@ -358,16 +359,24 @@ describe('render', () => {
},
];
},
render({ createElement, children }, root) {
render({ createElement, children, sections }, root) {
expect(children).toEqual(
expect.objectContaining({
type: 'div',
type: Fragment,
props: {
className: expect.any(String),
children: expect.arrayContaining([
expect.any(Object),
expect.any(Object),
]),
children: [
expect.objectContaining({
props: {
className: 'aa-PanelLayout aa-Panel--Scrollable',
children: sections,
},
}),
expect.objectContaining({
props: {
className: 'aa-GradientBottom',
},
}),
],
},
})
);
Expand Down
5 changes: 4 additions & 1 deletion packages/autocomplete-js/src/render.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,10 @@ export function renderPanel<TItem extends BaseItem>(
));

const children = (
<div className="aa-PanelLayout aa-Panel--Scrollable">{sections}</div>
<Fragment>
<div className="aa-PanelLayout aa-Panel--Scrollable">{sections}</div>
<div className="aa-GradientBottom" />
</Fragment>
);
const elements = sections.reduce((acc, current) => {
acc[current.props['data-autocomplete-source-id']] = current;
Expand Down
Loading