Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

StateProof: State Proof Verification additions #377

Merged
merged 23 commits into from
Aug 31, 2022
Merged

StateProof: State Proof Verification additions #377

merged 23 commits into from
Aug 31, 2022

Conversation

almog-t
Copy link
Contributor

@almog-t almog-t commented Aug 28, 2022

No description provided.

@almog-t almog-t requested a review from id-ms August 28, 2022 10:44
@almog-t almog-t marked this pull request as ready for review August 28, 2022 12:03
@almog-t almog-t force-pushed the light_client_additions branch 2 times, most recently from 8d29b99 to c90fcca Compare August 29, 2022 12:29
id-ms
id-ms reviewed Aug 31, 2022
View reviewed changes
go.mod Outdated Show resolved Hide resolved
stateproofs/stateProofVerifier.go Outdated Show resolved Hide resolved
types/lightBlockHeader.go Outdated Show resolved Hide resolved
types/hashes.go Outdated Show resolved Hide resolved
@almog-t almog-t requested a review from winder August 31, 2022 11:40
winder
winder reviewed Aug 31, 2022
View reviewed changes
types/stateproof.go Outdated Show resolved Hide resolved
winder
winder reviewed Aug 31, 2022
View reviewed changes
Copy link
Contributor

@winder winder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Considering that this is so basic, I wonder why we bother to include it in the go SDK at all. A user should import the library and use it directly.

id-ms
id-ms approved these changes Aug 31, 2022
View reviewed changes
Copy link
Contributor

@id-ms id-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@almog-t almog-t merged commit aa81e62 into algorand:develop Aug 31, 2022
@almog-t almog-t deleted the light_client_additions branch September 1, 2022 11:22
This was referenced Sep 1, 2022
Closed
Merged
ahangsu added a commit that referenced this pull request Sep 2, 2022
@ahangsu @algojack
@barnjamin @michaeldiamant @algochoi @jasonpaulos @algobarb @tzaffi @Eric-Warehime @winder @almog-t
Enhancement: Merge develop to feature/box-storage (#384)
b21b064 
* Github-Actions: Adding pr title and label checks (#336)

* Dev Tools: Source map decoder (#335)

* Updated CHANGELOG.md

* AVM:  Consolidate TEAL and AVM versions (#345)

* Testing: Use Dev mode network for cucumber tests (#349)

* AVM: Use avm-abi repo (#352)

* Updated CHANGELOG.md

* Enhancement: Use Sandbox for Testing (#360)

Co-authored-by: Michael Diamant <[email protected]>

* Bug-Fix: passthru verbosity (#371)

* Enhancement: Deprecating use of langspec (#366)

Co-authored-by: Michael Diamant <[email protected]>

* StateProof: State proof support (#374)

* Regenerate client.

* Update txn and block objects, cucumber tests passing.

* Enable cucumber tests.

* Update types/stateproof.go

* Add transactions-root-256

* Remove unused code.

* Remove unused file

* Add txn commitments blockheader fields

* Rename signature, add allocbound definitions

* Add txn commitment to header

* PR comments

* Remove unused file

Co-authored-by: Will Winder <[email protected]>

* State Proofs: Use generic type for StateProof txn field. (#378)

* Use generic type for StateProof txn field.

* Add missing type.

* Remove GenericDigest.

* fix type assertion on source map version (#370)

* let the json package figure out how to decode the elements of the incoming map (#380)

* StateProof: State Proof Verification additions (#377)

* Regenerate client.

* Remove unused file

* moved files from stateproof verification repo

* now using updated go-stateproof-verification

* fixed go mod

* moved consts near their usage

* added working state proof verifier test

* added unit test and resources

* now using go 1.15 supported function

* changes to avoid dependency of stateproof verification on SDK

* added needed types to stateproof.go for message hashing

* reverted packages, now using up to date go-stateproof-verification

* CR: renamed verification functions

* hashing sp message is now in crypto

* removed hashing of light block header

* CR: now allocating space upfront in hashing state proof message

* attempting to use embedded files

* CR: using GenericDigest in block.go

* CR: Renamed package to match directory

* Removed go 1.15 from CI

* improved embed usage

* CR: removed stateproof verification logic

* tidied go mod file

Co-authored-by: Will Winder <[email protected]>
Co-authored-by: Eric Warehime <[email protected]>

* State Proofs: added compute leaf function for light block header to sdk (#382)

* added compute leaf function for light block header to sdk

* renamed blockheader256

* changed passed type to pointer

* reverted back to copying

* renamed light block header hash func (#383)

* Enable stpf cucumber unit tests (#386)

Co-authored-by: Jack <[email protected]>
Co-authored-by: Ben Guidarelli <[email protected]>
Co-authored-by: Jack Smith <[email protected]>
Co-authored-by: Michael Diamant <[email protected]>
Co-authored-by: algochoi <[email protected]>
Co-authored-by: Jason Paulos <[email protected]>
Co-authored-by: Barbara Poon <[email protected]>
Co-authored-by: Zeph Grunschlag <[email protected]>
Co-authored-by: Eric Warehime <[email protected]>
Co-authored-by: Will Winder <[email protected]>
Co-authored-by: Almog Tal <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@id-ms id-ms id-ms approved these changes

@winder winder winder approved these changes

Assignees
No one assigned
Labels
New Feature Team Sphinx
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@almog-t @winder @id-ms @Eric-Warehime