FOR REVIEW ONLY - go-algorand-sdk v1.20.0 #385
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Michael Diamant <[email protected]>
Co-authored-by: Michael Diamant <[email protected]>
* Regenerate client. * Update txn and block objects, cucumber tests passing. * Enable cucumber tests. * Update types/stateproof.go * Add transactions-root-256 * Remove unused code. * Remove unused file * Add txn commitments blockheader fields * Rename signature, add allocbound definitions * Add txn commitment to header * PR comments * Remove unused file Co-authored-by: Will Winder <[email protected]>
* Use generic type for StateProof txn field. * Add missing type. * Remove GenericDigest.
* Regenerate client. * Remove unused file * moved files from stateproof verification repo * now using updated go-stateproof-verification * fixed go mod * moved consts near their usage * added working state proof verifier test * added unit test and resources * now using go 1.15 supported function * changes to avoid dependency of stateproof verification on SDK * added needed types to stateproof.go for message hashing * reverted packages, now using up to date go-stateproof-verification * CR: renamed verification functions * hashing sp message is now in crypto * removed hashing of light block header * CR: now allocating space upfront in hashing state proof message * attempting to use embedded files * CR: using GenericDigest in block.go * CR: Renamed package to match directory * Removed go 1.15 from CI * improved embed usage * CR: removed stateproof verification logic * tidied go mod file Co-authored-by: Will Winder <[email protected]> Co-authored-by: Eric Warehime <[email protected]>
…dk (#382) * added compute leaf function for light block header to sdk * renamed blockheader256 * changed passed type to pointer * reverted back to copying
algojack
requested review from
winder,
tzaffi,
barnjamin,
michaeldiamant,
Eric-Warehime,
ahangsu,
almog-t and
a team
algojack
requested review from
egieseke,
algobarb,
algolucky and
onetechnical
tzaffi
previously requested changes
Sep 1, 2022
Opened PR to add those to develop #386 They're all passing, so I'm not personally too concerned w/ whether or not they are included in the release since they're just tests. I'll let others weigh in on that as well though. |
From my perspective we're fine now that tests are passing on develop with the stateproof tags in place. But it would be nice to bring those tests into the release as well if possible. |
winder
approved these changes
Sep 2, 2022
tzaffi
dismissed
their stale review
test are passing on develop after putting tags in place
tzaffi
approved these changes
Sep 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's Changed
Bugfixes
New Features
Enhancements
New Contributors
Full Changelog: v1.19.0...v1.20.0