Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dryrun crash on rewards calculation #2894

Merged
merged 1 commit into from
Sep 15, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion cmd/tealdbg/localLedger.go
Original file line number Diff line number Diff line change
Expand Up @@ -285,7 +285,10 @@ func (l *localLedger) CheckDup(config.ConsensusParams, basics.Round, basics.Roun
}

func (l *localLedger) LookupWithoutRewards(rnd basics.Round, addr basics.Address) (basics.AccountData, basics.Round, error) {
return l.balances[addr], rnd, nil
ad := l.balances[addr]
// Clear RewardsBase since tealdbg has no idea about rewards level so the underlying calculation with reward will fail.
ad.RewardsBase = 0
return ad, rnd, nil
}

func (l *localLedger) GetCreatorForRound(rnd basics.Round, cidx basics.CreatableIndex, ctype basics.CreatableType) (basics.Address, bool, error) {
Expand Down
2 changes: 1 addition & 1 deletion daemon/algod/api/server/v2/account.go
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ func AccountDataToAccount(
amount := record.MicroAlgos
pendingRewards, overflowed := basics.OSubA(amount, amountWithoutPendingRewards)
if overflowed {
return generated.Account{}, errors.New("overflow on pending reward calcuation")
return generated.Account{}, errors.New("overflow on pending reward calculation")
}

return generated.Account{
Expand Down
3 changes: 3 additions & 0 deletions daemon/algod/api/server/v2/dryrun.go
Original file line number Diff line number Diff line change
Expand Up @@ -273,6 +273,9 @@ func (dl *dryrunLedger) LookupWithoutRewards(rnd basics.Round, addr basics.Addre
return basics.AccountData{}, 0, err
}
out.MicroAlgos.Raw = acct.AmountWithoutPendingRewards
// Clear RewardsBase since dryrun has no idea about rewards level so the underlying calculation with reward will fail.
// The amount needed is known as acct.Amount but this method must return AmountWithoutPendingRewards
out.RewardsBase = 0
}
appi, ok := dl.accountApps[addr]
if ok {
Expand Down
61 changes: 61 additions & 0 deletions daemon/algod/api/server/v2/dryrun_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -1331,3 +1331,64 @@ func TestDryrunCost(t *testing.T) {
})
}
}

func TestDryrunBalanceWithReward(t *testing.T) {
partitiontest.PartitionTest(t)
t.Parallel()

ops, err := logic.AssembleString(`#pragma version 5
int 0
balance
int 0
>`)
require.NoError(t, err)
approval := ops.Program
ops, err = logic.AssembleString("int 1")
clst := ops.Program
require.NoError(t, err)
var appIdx basics.AppIndex = 1
creator := randomAddress()
rewardBase := uint64(10000000)
dr := DryrunRequest{
Txns: []transactions.SignedTxn{
{
Txn: transactions.Transaction{
Header: transactions.Header{Sender: creator},
Type: protocol.ApplicationCallTx,
ApplicationCallTxnFields: transactions.ApplicationCallTxnFields{
ApplicationID: appIdx,
},
},
},
},
Apps: []generated.Application{
{
Id: uint64(appIdx),
Params: generated.ApplicationParams{
Creator: creator.String(),
ApprovalProgram: approval,
ClearStateProgram: clst,
LocalStateSchema: &generated.ApplicationStateSchema{NumByteSlice: 1},
},
},
},
Accounts: []generated.Account{
{
Address: creator.String(),
Status: "Online",
Amount: 10000000,
AmountWithoutPendingRewards: 10000000,
RewardBase: &rewardBase,
},
},
}
dr.ProtocolVersion = string(dryrunProtoVersion)

var response generated.DryrunResponse
doDryrunRequest(&dr, &response)
require.NoError(t, err)
checkAppCallPass(t, &response)
if t.Failed() {
logResponse(t, &response)
}
}