-
Notifications
You must be signed in to change notification settings - Fork 471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix dryrun crash on rewards calculation #2894
Fix dryrun crash on rewards calculation #2894
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a good fix to me
Codecov Report
@@ Coverage Diff @@
## master #2894 +/- ##
==========================================
- Coverage 47.27% 47.27% -0.01%
==========================================
Files 355 355
Lines 57199 57202 +3
==========================================
+ Hits 27040 27041 +1
- Misses 27101 27102 +1
- Partials 3058 3059 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems right.
![GitHub Logo](https://raw.githubusercontent.com/algorand/go-algorand/master/release/release-banner.jpg) # Highlights This version adds debugging for itxn programs and includes a bugfix for dryrun crashes. **This release does not contain a protocol upgrade.** # Changes 1. TEAL * Added * Enable debugging itxn programs (#2900) * Fixed * Fix dryrun crash on rewards calculation (#2894) ## Additional Resources * [Algorand Forum](https://forum.algorand.org) * [Developer Documentation](https://developer.algorand.org)
Summary
dryrun/tealdbg ledgers do not have block info so cannot provide correct value of
rewardLevel
used in balance calculation forbalance
opcode. Fixed by clearingRewardBase
field in account data returned by dryrun/tealdbg ledgers.The crash was reported at the community forum.
Test Plan
Test added