Enable debugging itxn programs #2900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2900 +/- ##
==========================================
+ Coverage 47.10% 47.29% +0.19%
==========================================
Files 349 355 +6
Lines 56351 57179 +828
==========================================
+ Hits 26544 27043 +499
- Misses 26831 27078 +247
- Partials 2976 3058 +82
Continue to review full report at Codecov.
|
algorandskiy
force-pushed
the
pavel/tealdbg-itxn-submit-fix
branch
from
1199e34
to
591245f
Compare
algorandskiy
changed the title
algorandskiy
commented
Sep 16, 2021
| @@ -338,41 +338,6 @@ func (dl *dryrunLedger) GetCreatorForRound(rnd basics.Round, cidx basics.Creatab | |||
| return basics.Address{}, false, fmt.Errorf("unknown creatable type %d", ctype) | |||
| } | |||
|
|
|||
| func (dl *dryrunLedger) getAppParams(addr basics.Address, aidx basics.AppIndex) (params basics.AppParams, err error) { | |||
There was a problem hiding this comment.
removed some unused code
algorandskiy
force-pushed
the
pavel/tealdbg-itxn-submit-fix
branch
from
591245f
to
ece4d09
Compare
algorandskiy
force-pushed
the
pavel/tealdbg-itxn-submit-fix
branch
from
ece4d09
to
f2ad694
Compare
jasonpaulos
reviewed
Sep 16, 2021
| var response generated.DryrunResponse | ||
| doDryrunRequest(&dr, &response) | ||
| require.NoError(t, err) | ||
| checkAppCallPass(t, &response) |
There was a problem hiding this comment.
It seems like we neglected to add inner transactions to the DryrunTxnResult API type. @jannotti was there a reason for this, or did we just forgot about it?
Ideally any created inner transactions would be returned in that response and this test could verify they are there and properly formatted.
There was a problem hiding this comment.
Definitely not on purpose.
There was a problem hiding this comment.
I am incapable of expressing how much I hate that dryrun lives in its own universe where we have to do everything all over again.
algorandskiy
force-pushed
the
pavel/tealdbg-itxn-submit-fix
branch
from
1638429
to
c4e9dce
Compare
jannotti
approved these changes
Sep 16, 2021
algobarb
pushed a commit
that referenced
this pull request
Sep 17, 2021
Merged
tsachiherman
pushed a commit
that referenced
this pull request
Sep 17, 2021
 # Highlights This version adds debugging for itxn programs and includes a bugfix for dryrun crashes. **This release does not contain a protocol upgrade.** # Changes 1. TEAL * Added * Enable debugging itxn programs (#2900) * Fixed * Fix dryrun crash on rewards calculation (#2894) ## Additional Resources * [Algorand Forum](https://forum.algorand.org) * [Developer Documentation](https://developer.algorand.org)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Set special addressed in EvalParams when evaluating from tealdbg/dryrun
Test Plan
Tests added