Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AVM: Document what the field _is_ rather than pointer to table #4260

Merged
merged 1 commit into from
Jul 13, 2022

Conversation

jannotti
Copy link
Contributor

doc change only (table has been moved, so pointer to it was wrong) better to describe the field anyway

@jannotti jannotti requested a review from nullun July 13, 2022 20:19
@jannotti jannotti changed the title Document what the field _is_ rather than pointer to table AVM: Document what the field _is_ rather than pointer to table Jul 13, 2022
Copy link
Contributor

@nullun nullun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful, thank you!

@codecov
Copy link

codecov bot commented Jul 13, 2022

Codecov Report

Merging #4260 (8ebf4d6) into master (1335f16) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4260   +/-   ##
=======================================
  Coverage   55.13%   55.13%           
=======================================
  Files         395      395           
  Lines       50117    50117           
=======================================
+ Hits        27630    27634    +4     
+ Misses      20111    20103    -8     
- Partials     2376     2380    +4     
Impacted Files Coverage Δ
data/transactions/logic/fields.go 77.10% <ø> (ø)
cmd/algoh/blockWatcher.go 77.77% <0.00%> (-3.18%) ⬇️
ledger/tracker.go 76.95% <0.00%> (-2.18%) ⬇️
ledger/acctonline.go 77.83% <0.00%> (-1.11%) ⬇️
data/abi/abi_type.go 87.67% <0.00%> (-0.95%) ⬇️
ledger/acctupdates.go 70.34% <0.00%> (-0.61%) ⬇️
network/wsPeer.go 67.67% <0.00%> (-0.55%) ⬇️
catchup/service.go 69.38% <0.00%> (-0.25%) ⬇️
catchup/peerSelector.go 100.00% <0.00%> (+1.04%) ⬆️
node/node.go 24.31% <0.00%> (+1.93%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1335f16...8ebf4d6. Read the comment docs.

@jannotti jannotti merged commit 294ec79 into algorand:master Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants