Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ledger: Initialize the accountUpdatesLedgerEvaluator properly #4456

Merged
merged 1 commit into from
Aug 24, 2022

Conversation

jannotti
Copy link
Contributor

This fixes the purestake issue on betanet and includes an easy way to test for similar bugs.

@jannotti jannotti changed the title Initialize the accountUpdatesLedgerEvaluator properly Ledger: Initialize the accountUpdatesLedgerEvaluator properly Aug 24, 2022
@codecov
Copy link

codecov bot commented Aug 24, 2022

Codecov Report

Merging #4456 (43adafb) into master (87867c9) will decrease coverage by 0.02%.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##           master    #4456      +/-   ##
==========================================
- Coverage   55.26%   55.24%   -0.03%     
==========================================
  Files         398      398              
  Lines       50263    50265       +2     
==========================================
- Hits        27780    27771       -9     
- Misses      20167    20176       +9     
- Partials     2316     2318       +2     
Impacted Files Coverage Δ
ledger/ledger.go 66.34% <0.00%> (-0.22%) ⬇️
ledger/tracker.go 74.89% <100.00%> (+0.96%) ⬆️
util/db/dbutil.go 44.24% <0.00%> (-4.25%) ⬇️
network/wsPeer.go 65.47% <0.00%> (-2.20%) ⬇️
cmd/tealdbg/debugger.go 72.69% <0.00%> (-0.81%) ⬇️
network/wsNetwork.go 64.82% <0.00%> (+0.19%) ⬆️
catchup/service.go 70.12% <0.00%> (+0.74%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jannotti jannotti marked this pull request as ready for review August 24, 2022 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants