go-algorand v3.9.2-beta #4462
Merged
go-algorand v3.9.2-beta #4462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Catchpoints only have minimal data, and online accounts/txtail derive it by applying catchpoint * Deriving code is reused from DB schema migration but the migration only assumed MaxTxnLife worth of block history * In fact, it needs to restore MaxTxnLife + DeeperBlockHeaderHistory when used as part of catchpoint apply code path
onetechnical
requested review from
algorandskiy,
id-ms,
jannotti,
a team,
algobarb,
algojack,
algolucky and
egieseke
jannotti
reviewed
Aug 25, 2022
Comment on lines
+1209
to
+1210
| v33.ApprovedUpgrades[protocol.ConsensusV35] = 10000 | ||
| v34.ApprovedUpgrades[protocol.ConsensusV35] = 10000 |
There was a problem hiding this comment.
Both going to the same next version seems ok, I guess? It might cause some trouble in one of my testing functions - but I suppose that's fixable if it happens.
Tests: Remove using unreleased semicolon support in AVM test
* replaying transactions after catchpoint requires 1001 blocks from the very first replayed block
* Ensure blk opcode can be replayed after restart * Fix e2e fast catchup tests
Codecov Report
@@ Coverage Diff @@
## rel/beta #4462 +/- ##
============================================
+ Coverage 55.60% 55.61% +0.01%
============================================
Files 403 403
Lines 50807 50820 +13
============================================
+ Hits 28251 28265 +14
+ Misses 20161 20159 -2
- Partials 2395 2396 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
egieseke
approved these changes
Aug 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This release requires a protocol upgrade.
This release contains a consensus protocol upgrade, which implements the following spec: https://github.com/algorandfoundation/specs/tree/433d8e9a7274b6fca703d91213e05c7e6a589e69
Overview
Miscellaneous fixes to catchup and state proof totals calculation.
Changelog
Bug Fixes
Additional Resources