incentives: handle round 0 "top voters" lookups for easier testing #6159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature/heartbeats #6159 +/- ##
======================================================
- Coverage 56.29% 56.28% -0.02%
======================================================
Files 494 494
Lines 70032 70038 +6
======================================================
- Hits 39424 39420 -4
- Misses 27928 27937 +9
- Partials 2680 2681 +1 ☔ View full report in Codecov by Sentry. |
algorandskiy
reviewed
Nov 5, 2024
| @@ -652,6 +652,18 @@ func (l *Ledger) GetKnockOfflineCandidates(rnd basics.Round, proto config.Consen | |||
| if proto.StateProofInterval == 0 { | |||
| return nil, nil | |||
| } | |||
|
|
|||
| // special handling for rounds 0-240: return participating genesis accounts | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Addresses feedback for PR #6085 to make E2E and unit tests easier to use when testing incentives & heartbeats — don't wait until the first time the state proof voters tracker starts calculating & caching the "Top N voters" information (at 256-16=240 rounds). This adds special case handling for round 0 when calling GetKnockOfflineCandidates to fetch that data from the genesis accounts.
Test Plan
Will untangle a couple of tests for this change from other, bigger WIP test changes I described in #6085 (comment)