incentives: update GetKnockOfflineCandidates to return current OnlineAccountData when rnd < 240 #6165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cce
changed the title
jannotti
reviewed
Nov 6, 2024
Comment on lines
677
to
678
| // fetch fresh data up to this round from online account cache. These accounts should all | ||
| // be in cache, as long as proto.StateProofTopVoters < onlineAccountsCacheMaxSize. |
There was a problem hiding this comment.
This comment makes me wonder why the genesis accounts are expected to be here.
There was a problem hiding this comment.
The online account cache is loaded up with the output of AccountsReaderExt.OnlineAccountsAll at DB load / tracker initialization time (in onlineAccounts.initializeFromDisk)
There was a problem hiding this comment.
Ok, I'll merge and clean up comment.
There was a problem hiding this comment.
Maybe you're wondering how genesis accounts get into the tracker DB tables like the accountbase and onlineaccounts tables in the first place — when trackerDBInitialize sets up a fresh ledger with genesis accounts, it uses them to populate the ledger DB.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
@jannotti noticed that in #6159 the GetKnockOfflineCandidates function was not retrieving the current round's OnlineAccountData when
0 < rnd < 240because it was still returning the genesis balances — this fixes that.Test Plan
Updated TestDoubleLedgerGetKnockoffCandidates to change two balances in round 1 and assert it is returned afterwards for rounds < 240.