tech-debt: Update submodule, e2e tests #1388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #1388 +/- ##
===========================================
- Coverage 65.38% 65.33% -0.06%
===========================================
Files 79 79
Lines 11274 11274
===========================================
- Hits 7372 7366 -6
- Misses 3338 3342 +4
- Partials 564 566 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
| @@ -164,18 +164,6 @@ def firstFromS3Prefix( | |||
| haystack = [] | |||
| found_needle = False | |||
|
|
|||
| def report(): | |||
There was a problem hiding this comment.
Thank you...I hated this message
AlgoStephenAkiki
approved these changes
Dec 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updates the submodule to the most recent nightly build.
Also removed the needle in the haystack logging because it seems to cause more confusion than help. Updated the logging to still provide the same set of information. And I updated the circle CI rel-nightly e2e build tar to pull from.
Test Plan
Ran
e2elivelocally against the updated rel-nightly tar.